From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1CDA45E41 for ; Sat, 7 Dec 2024 09:04:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA6D940E4C; Sat, 7 Dec 2024 09:04:24 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2082.outbound.protection.outlook.com [40.107.94.82]) by mails.dpdk.org (Postfix) with ESMTP id 1215140613 for ; Sat, 7 Dec 2024 09:04:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wS1o15TlfINWhIB+al/8u0upBVN+ZdncSMPgBZWHFWz6UKY/qQgrcf31Y+hiDTLFYgP0RpkgnHiSmD5BeVxXMS7Z9BAfIqiRPyEqZbyXPnnOb6n2rkRyEOcfCBP0xSGi/yQyNwkYzUTH4aikEDZ6PumcEcexo2+VrzvJvz0BHuvB0VkQjUgYwKZxBCNpqXWJA9GZZk/cg8O8uBeta69kdn5oK7Qy7gqSwHOA9kkhIalrQ/VJPID9hagI3Mwjd0UMjpZQCi6bDxCdqnvaIVYe1Cj01bdQdVC4euINbU4OY8aZBoFZzETv1lOjig7aAk5qKnPL8sm+tyNq6ZCA7zp97g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VOuymXoMxKWQfAFZp5k8UXvJ6YS1v/KfrZYY6Kf70OQ=; b=nP0tNnbgXNaX8V5XnsUeL45QAeZHpCNwtBiB5m07+6eTw+eduJU1Da84fFGa6kzPxRET2UNH44vPd1xyZbVmtlDUsyCdx6tQbu9tdtfHUrsu7RSfM2fMpjmVsooaOdSqMHoixhX5vbDTDgqv915pXYaQxmiJe4ltkEOw+/KIBlFicKVG6Cw5PS9BwilhK21R4/Pv5sq4DoO1O2mApeSGVSsC3AZYUYwuyC2uKl0q12K+SPAM7Z+3Yc3dHZSuV9k8fDHFKA3FtBsPRbUowOi6ThCknlT9mBo6p+g0I9/6+/9rqyBXq5U/uXejpqH2LiDRIhbIb7imAOMTIwHklKvEjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VOuymXoMxKWQfAFZp5k8UXvJ6YS1v/KfrZYY6Kf70OQ=; b=svUbdVIF/GXBBlkYlZ/xvh4Dd4nz06TwwIKqVMDVun7O30HmiEKknMP2MjHV+IR6mm57DvDSj6K7HOlkai8iyaO8Ly6/Mbg7PoQQDF8Yzj5r02RIQBOC7HaTSjk5I+dTGr6O++gkmcKErDKDxLl0aE0YXoKPG6ueKwbSlg92WltPWL+FTLkWYX9ahTbaEOCxmHOU6mpZF5OEkaPUYytc+/Svd8UBeSbpsgFahJf3mCOiTOUTKwJ860ojqMSlfXe1io7eRgVcv1kx8CCmvswCcYs7cz4B+N3ADjrzdJQ6L/cAmWKqeNBwueHhugvrb091pqPGFrGLSFv3qTTvK3po6g== Received: from BYAPR11CA0071.namprd11.prod.outlook.com (2603:10b6:a03:80::48) by MN2PR12MB4094.namprd12.prod.outlook.com (2603:10b6:208:15f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.17; Sat, 7 Dec 2024 08:04:18 +0000 Received: from SJ1PEPF00001CE3.namprd05.prod.outlook.com (2603:10b6:a03:80:cafe::b4) by BYAPR11CA0071.outlook.office365.com (2603:10b6:a03:80::48) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.9 via Frontend Transport; Sat, 7 Dec 2024 08:04:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF00001CE3.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:04:17 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:04:08 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:04:07 -0800 From: Xueming Li To: Jiawen Wu CC: Xueming Li , dpdk stable Subject: patch 'net/txgbe: fix driver load bit to inform firmware' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 15:59:52 +0800 Message-ID: <20241207080055.488538-35-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE3:EE_|MN2PR12MB4094:EE_ X-MS-Office365-Filtering-Correlation-Id: 38d7a604-0080-4226-268c-08dd1695bf9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cBaVTAk3OUQnARn79YSeokP4oepjkxvw0rlwpYprnOu+dcExGVPjyKB8NFd4?= =?us-ascii?Q?vaZVfbKNDeL2AHZSfmrA1vlYBehp1Q+yfGWeI6P7oWnyjfywGOsThU7D4B4w?= =?us-ascii?Q?v6WkRd+SYYHBpaFbY1vk7TLTN61nSMsbFm/JwThFtZmMyutAP6hUGyxElG1m?= =?us-ascii?Q?KF+5X2GK+cUGb6c1/zPSsZRMtyanzLcDTVMIrQ8twXsvBwOtUBU3/7t8ht+q?= =?us-ascii?Q?2ZW3Car565vgrkF8Tfuoqx7GITU5fDR5QpxiHskIB9X9+2wg2uKWlMb8M3/1?= =?us-ascii?Q?aYdECxBQHLge8TTHbSneEmJbr99Kd1nhlSnI8zOkOfJUpXLcN/iGi8ldcm/A?= =?us-ascii?Q?RTuNVDnDxw/6nTLf+Ys+qF8709zv3e+q7IKQ2UEg8FuoqvwHw2Q8xhFnQt0Z?= =?us-ascii?Q?CyHEjCtUesGyeO2buHoD1a4rcPCzOrP51FMl12xAwCp/lYWU/8P+MXaluIOi?= =?us-ascii?Q?JpUke4+EkOn6awrNNj1CXmfrAVrN5xUK+8L5/zMi2/NTQ1TTU/nAyJ/CSyyp?= =?us-ascii?Q?HozJJg/meg7zzu4uDc0u5klp3Yzw2/mPEm+Wiy6P4avq7O+BqKP8NCDTXN5y?= =?us-ascii?Q?ZP6jYia8o0UeHX0xYX2pwxh3X6leJLZ+SeRQC2w7kVK9aZme3ogNEkOZjtXJ?= =?us-ascii?Q?hOfXP1KeuoD+cqWgtASV+Y+7Ppxc3W4Bu2b3TQYlBlHjGCvFFvL8SOnlVYEa?= =?us-ascii?Q?peb+9lyrJ1h9Y6CaUXXjbLyQZrIjfKNAczcEHYHonGODangRj2/mjjO6COvi?= =?us-ascii?Q?e5bXxobgjfbzewPFStwd0BbFqEzNqbNKsoNuOuY/6pJ5EVZblnSthztLWZJh?= =?us-ascii?Q?/9CEgY765Rur4UTpemnUMxJ10gYw4VMkSBP+tHR16Dn9HgAr/pHZZufE97ZT?= =?us-ascii?Q?f1WqsVdu6CLnmJ/bT95i09wr1dMMHDc7vniBPF8a8Q3jIui9LRraWhd/zDvl?= =?us-ascii?Q?YrVXveHpMLK8hhdkeLaI7gYnlDxRO52ghPMuS0n15nvhuAvABWumumyWhPyU?= =?us-ascii?Q?FqIzHAidLNCBJePOERdvggOwI+GDgFcsKTm2KIn8tybU6MpvtV0qYC/FEFcn?= =?us-ascii?Q?159rKrE0wH5iGTQKDUyrLXykoWWdgnrmHQ/rYOao3Dmt+vvD1Zyh7sErBUEf?= =?us-ascii?Q?e2JxiDLQYrgQS1NUeJlMNfUyQcOwJzEkvwpHkUMf5IzwAd6+iHuuTyt/perb?= =?us-ascii?Q?f6VJ36WTOYZbQB/PorT8rSA6TuCkAjUZyen98R9jwKXaKv1AYMMvypYXSaUn?= =?us-ascii?Q?o2gevz29wSy3Za+g0fbKYOY080fGZTwfXFh1n7AL0vPqjWG2FBuWMU/fU1Wv?= =?us-ascii?Q?0nEG5CF5nbG4ZhJJXaESQmAL2343CB5X+lKPOmdX2d+ZbqcSH2rpW02jDwdq?= =?us-ascii?Q?iUSJKd2s24TmMtwgx5EEU3mUTfXpz1iSYoKSos/Lm7nPDPlqlawq4SODHoFf?= =?us-ascii?Q?t/POkvCTHK3XHUL/jniUL0fiUwsVlhVm?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:04:17.5913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38d7a604-0080-4226-268c-08dd1695bf9d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4094 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=a6f62c575b8a25b727da665ee8659d31e8f1fb9c Thanks. Xueming Li --- >From a6f62c575b8a25b727da665ee8659d31e8f1fb9c Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:29:58 +0800 Subject: [PATCH] net/txgbe: fix driver load bit to inform firmware Cc: Xueming Li [ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ] Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: b1f596677d8e ("net/txgbe: support device start") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index a8bdc10232..9b44f11465 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -331,6 +331,8 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw) status = hw->mac.reset_hw(hw); ctrl_ext = rd32(hw, TXGBE_PORTCTL); + /* let hardware know driver is loaded */ + ctrl_ext |= TXGBE_PORTCTL_DRVLOAD; /* Set PF Reset Done bit so PF/VF Mail Ops can work */ ctrl_ext |= TXGBE_PORTCTL_RSTDONE; wr32(hw, TXGBE_PORTCTL, ctrl_ext); @@ -2059,6 +2061,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) ret = txgbe_dev_stop(dev); + /* Let firmware take over control of hardware */ + wr32m(hw, TXGBE_PORTCTL, TXGBE_PORTCTL_DRVLOAD, 0); + txgbe_dev_free_queues(dev); txgbe_set_pcie_master(hw, false); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:45.249952213 +0800 +++ 0034-net-txgbe-fix-driver-load-bit-to-inform-firmware.patch 2024-12-06 23:26:43.923044828 +0800 @@ -1 +1 @@ -From 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb Mon Sep 17 00:00:00 2001 +From a6f62c575b8a25b727da665ee8659d31e8f1fb9c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 2834468764..4aa3bfd0bc 100644 +index a8bdc10232..9b44f11465 100644 @@ -31 +33 @@ -@@ -2061,6 +2063,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) +@@ -2059,6 +2061,9 @@ txgbe_dev_close(struct rte_eth_dev *dev)