From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F78F45E41 for ; Sat, 7 Dec 2024 09:04:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82A6D40E4D; Sat, 7 Dec 2024 09:04:47 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2054.outbound.protection.outlook.com [40.107.243.54]) by mails.dpdk.org (Postfix) with ESMTP id CAF4C40281 for ; Sat, 7 Dec 2024 09:04:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sxJsLrGluZlilQwF4yTQdZRTgy199d5rPR/gIzrL3vjzC6NSR5gb3OoHv07jPgSvZHFBNPTw6tNUiem8OXJ90nG3RoAmQkClJBAi+a8utubjLKMzj2+HwSRjsHokn5vHcTEkJApaAb0Fv7IXd3R5LMr4zJXK1LE0Ea1uqQaImGOO19dcr0qLkkfD83uw1KjMi7e0cZIi7jw1gZPBcJOvUqaM5Alw5ZTae5ojSjBaG7vzfy/RsDuzLA7fQ7JuBvRFNkFXyMEFbixBB+mVW6ZsrFDgYhjCWYdXFtKLYhOy59oKj2vI559m/ngcNZyd1TNihmaMfxbEF5vH6hkWYpto9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0hBF7Iv7ku2YAYJRrEZF/mRaYnEoycGrMA57nhAdgI=; b=RnC7AcwQ65ozOx7+6d3InvYmGymVvHHhHCmlcBGkNqcT16Z2h1Z8+hA9ECq6hGy23Uv0rPl5clGiiBtRyycVWfryuHK6vTpfePZgI2iAYxxXqfsvB7yBZek21FfOGeJOQ/qoHhdWtfH9xdXyGozKo6vATyDXjTzi1LWt7EHVH5YFDhasvAIiurzNk4kMkFd4rt29kJSVatEfPKztpCLVNTGNBvuLj+Dnnh4x0CYGGn6dYwKEMjtlvqufXO5K7K9V68tJIfWMBpI8dZAvFxH3DitzomwGfjzH2FYRfQG0mLVgms34S86L8MKCoDhN9bVM5TGRE7mK3Gb07fXSjKb8Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I0hBF7Iv7ku2YAYJRrEZF/mRaYnEoycGrMA57nhAdgI=; b=nk4C5eRZ+cVaAwM7+d2ZE8qRrYNWmsiwpZtorQNhJWbrs3SzdH4YYaXPyvU2NETjAeO+fhX571fYgXQ3u5lJXCA30slqRrj/c/ADGONmXkYZO1hVWV59fwISmrwUGCGKF3imGOLpksQ/yUaAYgQI6Gf46pskmH8ngCGTaw8ZVEJIwbr+Wco6zUYs96U5LQki1kziSgZGTdZAVJpD+irxoCQ8buS6GGsxfhYcX1W8lXVk/o6LuZkK/bjhgUKt4ytaDWW5QYLaUQ6Au+CAKT4lt+ZAu0ofMwRSrVbxu3gj//hCk+v2Sh1QxlQJkg14BHdzcY/RwYmXA4+m9IDESnAt2Q== Received: from PH7P220CA0158.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:33b::34) by DM6PR12MB4188.namprd12.prod.outlook.com (2603:10b6:5:215::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.13; Sat, 7 Dec 2024 08:04:40 +0000 Received: from CY4PEPF0000E9DB.namprd05.prod.outlook.com (2603:10b6:510:33b:cafe::e) by PH7P220CA0158.outlook.office365.com (2603:10b6:510:33b::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.11 via Frontend Transport; Sat, 7 Dec 2024 08:04:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:04:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:04:28 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:04:26 -0800 From: Xueming Li To: Jiawen Wu CC: Xueming Li , dpdk stable Subject: patch 'net/ngbe: fix driver load bit to inform firmware' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 15:59:53 +0800 Message-ID: <20241207080055.488538-36-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DB:EE_|DM6PR12MB4188:EE_ X-MS-Office365-Filtering-Correlation-Id: cc3d0cce-54a8-4339-535e-08dd1695cc5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|376014|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KJCRYLiRD4PakbrxIllJ78fXXugdm6A47QapN4ifLVGk85zxi0/WwGHSwcdv?= =?us-ascii?Q?BByYwfnkhGsN4kYtPEJQDdPxGbsyA72wdO+Fquui17cO86F8GqWKu+IxLGtq?= =?us-ascii?Q?2TW85FbB1v3D9KgV+ImNmH4I9PBaGPKtAmaM6aigIS69XPDZyfWMzEAKjCLx?= =?us-ascii?Q?KcQZjPY2WTqgwtMwJ76gFisCfQlpLPEH64yPWxANvq7EWc3jW0X+r1jnEUrq?= =?us-ascii?Q?xtwIFfjZWsmVOwIrauW9aCQxm2/Geq3NKa4ZxjX0BCFZlLO8zLpeQZErmF7M?= =?us-ascii?Q?/b9ox7B7i/N9gJvtHjXHgZqSlLzBdYz9jS+eg7we3f5BkZ+bFPZBDNu+3iF+?= =?us-ascii?Q?IiK9NbmYPndwLYDmM0ymW1L3zkfFF03uB5QQzg+pSF9MG5JcbzKqkSfmViN/?= =?us-ascii?Q?IBTOx/bJdgN0GyLVHvWux6h26t1t6YsBHD5U55PROC4dQirr6ed458G/Cy6u?= =?us-ascii?Q?6VwRZzM+fUypnSeSwK0qhhB0yf0RFcR+HLcJehOYkXMS1OXs+vvAzqqLM0gZ?= =?us-ascii?Q?9WQeQr9h9H7AQPCAqcXpNHlWDT4L2/EalWysbXotEW5aDS602+3YqSafOTSc?= =?us-ascii?Q?U3MVFvtKYHcSscnP/zNCtkZP40t259o8DM0iX2zZxiNPrPlZmeuAujCIk35a?= =?us-ascii?Q?mpk2n2MfTeqFFaYeczhjIgaiyOY1p0mplMs6Uu6C0Us7rbRcXVDVJHh/5SPY?= =?us-ascii?Q?WVLk7URgMp+fPvbKO7uJWZxqsicXRPonhbjh+hgFLHspCbqIOWUfGemS4Pp9?= =?us-ascii?Q?bJn+M9GwWXiCJ+jGm7VSYx1hFgPIO7tQbbYEN2jlKjDqYbfGT0+2zYcSsaL5?= =?us-ascii?Q?iYO2Uui+h8Z9hGQQdpsfC5gX65uVA4q1yxuDZ5zeR9TZjSr14YdPHQoJKfNr?= =?us-ascii?Q?WSkO9lQQoqll4LGXP+x2nIVKPPx5mx96HDsqglGz8ersGVJD5TzYpb8fgaI4?= =?us-ascii?Q?a8UgCEJ6Fsu3ZZFT7Vq3C3q8BX2YABCb33udNaWz48ADth5xhqIJ5+Oak45w?= =?us-ascii?Q?jTZMRnfAUtL4VU3KFi7Sz5lkMgAq4Dks9NxxtGH+4une0ZKHcgCPXysGDHiG?= =?us-ascii?Q?yKXODqvYRpNFYxYPiVBAkB3NO4zrkyU6lHi+TDOpBsuU8MG0FwPyEOpGMMD9?= =?us-ascii?Q?nCRmRgO0OkrPEaFAXYK6v0q6Z6eo928n4c6F6MuiHSroLrWgqh4KYVxNJHGI?= =?us-ascii?Q?0+3L9/8xO/Lz1iPKba5VEPO5wBX/ZR6tMe2UGpodd7uiY/+GD8YroLhOB5my?= =?us-ascii?Q?sh01B4AUQ2pNuMKEcmmZVoDbTczw/HBaKp+i61+lyZRWcdQFmeCsiabpJQGT?= =?us-ascii?Q?y2FyftgJcwnvGTGKJ/w0DKVaB+CpN1Yb0BMxxIUuO9Oip6tl1Z6+N9ALBgu9?= =?us-ascii?Q?tccKFZ1TRlqRzKuRmzz9waLZ0akgsDJ2dUB2vI/eDYBnciqmRyohLbLx+hHM?= =?us-ascii?Q?vQwVC8sV10KGFwzbrhCFOEv2dIohNQSW?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:04:38.9860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc3d0cce-54a8-4339-535e-08dd1695cc5b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4188 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=e27b87fc9ce58d6f3ad1c19c90b447ca8feeed2a Thanks. Xueming Li --- >From e27b87fc9ce58d6f3ad1c19c90b447ca8feeed2a Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:30:04 +0800 Subject: [PATCH] net/ngbe: fix driver load bit to inform firmware Cc: Xueming Li [ upstream commit cb7be5b510ef0995fa171832f0e0994f667e2161 ] Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: 3518df5774c7 ("net/ngbe: support device start/stop") Fixes: cc63194e89cb ("net/ngbe: support close and reset device") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 4321924cb9..48b58284a6 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -263,6 +263,8 @@ ngbe_pf_reset_hw(struct ngbe_hw *hw) status = hw->mac.reset_hw(hw); ctrl_ext = rd32(hw, NGBE_PORTCTL); + /* let hardware know driver is loaded */ + ctrl_ext |= NGBE_PORTCTL_DRVLOAD; /* Set PF Reset Done bit so PF/VF Mail Ops can work */ ctrl_ext |= NGBE_PORTCTL_RSTDONE; wr32(hw, NGBE_PORTCTL, ctrl_ext); @@ -1269,6 +1271,9 @@ ngbe_dev_close(struct rte_eth_dev *dev) ngbe_dev_stop(dev); + /* Let firmware take over control of hardware */ + wr32m(hw, NGBE_PORTCTL, NGBE_PORTCTL_DRVLOAD, 0); + ngbe_dev_free_queues(dev); ngbe_set_pcie_master(hw, false); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:45.281260313 +0800 +++ 0035-net-ngbe-fix-driver-load-bit-to-inform-firmware.patch 2024-12-06 23:26:43.923044828 +0800 @@ -1 +1 @@ -From cb7be5b510ef0995fa171832f0e0994f667e2161 Mon Sep 17 00:00:00 2001 +From e27b87fc9ce58d6f3ad1c19c90b447ca8feeed2a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit cb7be5b510ef0995fa171832f0e0994f667e2161 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 353d17acc8..238533f2b8 100644 +index 4321924cb9..48b58284a6 100644 @@ -32 +34 @@ -@@ -1277,6 +1279,9 @@ ngbe_dev_close(struct rte_eth_dev *dev) +@@ -1269,6 +1271,9 @@ ngbe_dev_close(struct rte_eth_dev *dev)