From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63C7245E41 for ; Sat, 7 Dec 2024 09:04:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5814040281; Sat, 7 Dec 2024 09:04:46 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2048.outbound.protection.outlook.com [40.107.223.48]) by mails.dpdk.org (Postfix) with ESMTP id 0CD7340281 for ; Sat, 7 Dec 2024 09:04:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B+H6v+LEz/VjWkIP2APinLnvRLi0rhcd7nKFGgXIpl4JYzPNBqdr87H6XsukaiS5QLs968YlcEn9Y6ofegloX6IoK61NfmEy/1bicpvqnEldYqabV6eZNz8xLeHCzG1PrGiedZ5WQpv6i0B18xpP/DkvMcqcmNUMCMcQShDYa0x3Ut31qSJ1f3eEjTCvVnos3/BoLBfCHoytDwjvzvr37OYq7j21tfl6KGjO6KQAnh0SXqD55ZV3I7fpDCJhnziOmA2Fww1nNqibv/N1eh21iIbevfp7RqBsmg45mLPW8xQUSlfJyQ0KW6H3+Ranl+CVzPrFzlNSUs3TsWgZ5R7htQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iqzua0VL5PXcTISK9fZkShD8rCtVOBqaXGYIWFakkuY=; b=Pe4MeUGUg3K4VWph9oVqr4kkk71aj3SWANGUHSBs7Nv60hIU98YsA63mACZNrijJDpfd94Vx83WuHPsCHq/p+U2dqYLNdjCj5Sq+f8gpWgoQ0WEsJzwHXIT8yfC6cMKV2uvI40KNCrr6udYp2cWqCsuYWH70Au7y8Doe/4++BvswsjnidC+jg13I0sI3Q3TXO+aPS9A5iKhwbFBss7czhskA2HRl83WIDiMRTiOsyXTZowUxWc3awR+ulcH0IjyHnXlxJWfq8hQ6AvAL88pUeprYMj8opPIi4mw2JQgjSvuzq4UyhCzaPgj9kCjSrKn26blgExmsIFS5hAzErkKbLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iqzua0VL5PXcTISK9fZkShD8rCtVOBqaXGYIWFakkuY=; b=g7R4OCGQ0u4AYHiDZlEG1ZXnlhuL+XOhHLFgyw4AXrDjqfj9tr5CkPFJW2KjMhI3aGe5U8ITGjkHdqZb/8+qgjYCa4+1XxzVaEPV4DrpzFpUqaBWd5apd+IhmWIL4SPE2gZJ4Gz398nd7nBvXl5hSJKcnkV2/EV4t/mwf5yfy1CmxP1APfjpwAz8wMSNP/4Y9eJ1EIeTbyoOKFmjAWOBtept41PnPE+SJ6D9SwQrY3B0xk9jst1XXKsTFBv+o5HhE+vI2BtBnzQFB2JHDvLwdgCeWrEfIlIwkw0Nabc9Wsaw3b88G7t/rUnDrh7lQ5MCOqm6FdusC9eesYtHFL49YA== Received: from PH7P220CA0161.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:33b::20) by PH8PR12MB6868.namprd12.prod.outlook.com (2603:10b6:510:1cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.17; Sat, 7 Dec 2024 08:04:41 +0000 Received: from CY4PEPF0000E9DB.namprd05.prod.outlook.com (2603:10b6:510:33b:cafe::a7) by PH7P220CA0161.outlook.office365.com (2603:10b6:510:33b::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Sat, 7 Dec 2024 08:04:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:04:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:04:31 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:04:30 -0800 From: Xueming Li To: Jiawen Wu CC: Xueming Li , dpdk stable Subject: patch 'net/ngbe: fix interrupt lost in legacy or MSI mode' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 15:59:55 +0800 Message-ID: <20241207080055.488538-38-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DB:EE_|PH8PR12MB6868:EE_ X-MS-Office365-Filtering-Correlation-Id: 1dc68db7-3905-4d55-bb6a-08dd1695cd87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MpyretNHzG4SDa8iv6oFhVMCalDcyegH0oyj8MkkXbSDrxvOONDWyxpYhlKD?= =?us-ascii?Q?pwYVpZEEJmROhRP4AUPn6dk0AoFIwpVPqpsuXljNYQdtxRjxxwNyGlROW77e?= =?us-ascii?Q?obarm+73ZAfAYaaFYO+l9dvR9ZduwwPGigWEBoJjMRe9VqvLBkF08Dwg3TiB?= =?us-ascii?Q?k5XdVWhWvJ1r2tL3EGuLM+Y7Fs9OlnNbAVQs+RLBBaiCRAwhyHRTBVB+cLOX?= =?us-ascii?Q?DwLk29c2hbb7fE8r5liEfs3eY6LdRDTJ+bQsdL8tFnIKOtEs20fKhEw6HBb/?= =?us-ascii?Q?I0Vi1ccoArf0gBCgstL7uAwqZbPNut1j75uMI3rLu4hsQV8Ma3N0j0WA1WSj?= =?us-ascii?Q?xq83qhHXwgkG43LJGJGXnIOaPvERzJkULUgvs4fBtAQQXMHZLQRbJkvINQCK?= =?us-ascii?Q?r8LgaG8US3S/MgJSG0Yud2yb8I84ww+fX1gIljgxu95SZ+btkjZMwmXyISUJ?= =?us-ascii?Q?LOoHcfMqFzK5fiWxrx3okCrJQvTknLVhnREgg74YPKVZtqXOPLVQ5Zszmb59?= =?us-ascii?Q?WXAmgNh55raXP2c8+gIkHzxIaHMl1kZi8qIjuo9dP+GUAKRCLxdrS5WPhiIG?= =?us-ascii?Q?qAJEgywDTDnTE14GyKPYDvjBiKkErF7UEUPTk5btI5eOc+kX6IlY2UxPnOKp?= =?us-ascii?Q?EPI4PyK7HV3hiVOjRAopLLvM9m43BMDcrgPDOSs4FLmockKIXlsEaDynkzWL?= =?us-ascii?Q?EEsyFZQTkKZrsV3UgBKnkti/KCcjujYCgV41KaLjzOn5vC1wG9RwgixUZ7CB?= =?us-ascii?Q?9Cm5H7UAJQchJjCyADqoaKCqr1pC3C67mQWT03RQ1PIUO3cOL+VlvZv1TKqc?= =?us-ascii?Q?eSmZLN5xsYcEF8ilXvtmWKCB1f9Bmi/clgDicxLYu07Nu1CDAYdQmmm7mbYC?= =?us-ascii?Q?ni+ftMXEQfUlaAp90wdZPAfqEuzmXSh9fO+ICMTiCskiYHe2ZNwoV4TrXpJO?= =?us-ascii?Q?QKHALchz/+HTwjWkZX4bd1MaU0euQ2Ry+kq2Wfgo3NAetc0Q0NlPTOYNXU7n?= =?us-ascii?Q?sB6R/nVAkN42gUOAs10TDUFqrRaUTJl4PlSB3hS2s+q65XlfOwK+paMQiENT?= =?us-ascii?Q?YR6s6f16R9nBzckmPoSc9g+L7kE+y05YZARFiZ3tsQ7g3UvqNC9wyPLrcpGR?= =?us-ascii?Q?LISrKW4UgzCzS0K5DLwFbxOdqSof5P675HeEaVeIVZvmb6OC/sUQV589wxun?= =?us-ascii?Q?W9cvCMu0iFm96Zx+sJIJqGaHjFYGUvmnXQev3xhIrzUYTXtkkVp4bVLojj8L?= =?us-ascii?Q?1eTGWKDnv+scAm3GSL6ESB7pco6XPJTLSIAtrEp0mzHfabxpydQekbp8FhMN?= =?us-ascii?Q?nJnuKD8bU3pair4loSegksvapRIbjU4+mxYPlozb5wbNuRB60UjMyn5bpbyw?= =?us-ascii?Q?P7S24JWBhCoFom9rqkfyQfV2vrFX3K6+YHDINKX8cnS9D/SbMYXJOBXxnv3b?= =?us-ascii?Q?EQeBqf7HY3EZfn/Ytx4q11bJLt+QSnmh?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:04:40.9547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dc68db7-3905-4d55-bb6a-08dd1695cd87 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6868 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=fe2506753d5831153950339060b9b1c43aee13d5 Thanks. Xueming Li --- >From fe2506753d5831153950339060b9b1c43aee13d5 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:30:06 +0800 Subject: [PATCH] net/ngbe: fix interrupt lost in legacy or MSI mode Cc: Xueming Li [ upstream commit 68f04c0aa79316de333441e7efdadd2876412ffa ] When interrupt is legacy or MSI mode, shared interrupt may cause the interrupt cannot be re-enabled. So fix to read the shared interrupt. Fixes: b9246b8fa280 ("net/ngbe: support link update") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index e3772a7396..f48894bdb4 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -2168,6 +2168,19 @@ ngbe_dev_interrupt_get_status(struct rte_eth_dev *dev) struct ngbe_hw *hw = ngbe_dev_hw(dev); struct ngbe_interrupt *intr = ngbe_dev_intr(dev); + eicr = ((u32 *)hw->isb_mem)[NGBE_ISB_VEC0]; + if (!eicr) { + /* + * shared interrupt alert! + * make sure interrupts are enabled because the read will + * have disabled interrupts. + */ + if (!hw->adapter_stopped) + ngbe_enable_intr(dev); + return 0; + } + ((u32 *)hw->isb_mem)[NGBE_ISB_VEC0] = 0; + /* read-on-clear nic registers here */ eicr = ((u32 *)hw->isb_mem)[NGBE_ISB_MISC]; PMD_DRV_LOG(DEBUG, "eicr %x", eicr); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:45.343923112 +0800 +++ 0037-net-ngbe-fix-interrupt-lost-in-legacy-or-MSI-mode.patch 2024-12-06 23:26:43.933044828 +0800 @@ -1 +1 @@ -From 68f04c0aa79316de333441e7efdadd2876412ffa Mon Sep 17 00:00:00 2001 +From fe2506753d5831153950339060b9b1c43aee13d5 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 68f04c0aa79316de333441e7efdadd2876412ffa ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ -index c372fd928c..325a9d1eaf 100644 +index e3772a7396..f48894bdb4 100644 @@ -21 +23 @@ -@@ -2193,6 +2193,19 @@ ngbe_dev_interrupt_get_status(struct rte_eth_dev *dev) +@@ -2168,6 +2168,19 @@ ngbe_dev_interrupt_get_status(struct rte_eth_dev *dev)