From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E493D45E41 for ; Sat, 7 Dec 2024 09:05:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC23040281; Sat, 7 Dec 2024 09:05:36 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2049.outbound.protection.outlook.com [40.107.100.49]) by mails.dpdk.org (Postfix) with ESMTP id DD06B40281 for ; Sat, 7 Dec 2024 09:05:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VJCkyepPypHHTCglSTMNmEHMKYnHnqwjzpE00emBAgYnRrMqsUIq4m4DJF1XVZwGGDJGzMeznTH4SlFWtktC/FI6R4tXAG2vWXF+0L3Sls3XkAWXmI7SYEYXliBdJeCRenKItpjXL/KF4dI7vN/7ZsDLJuKMwoix5EgUCfiNtCpMQ8wjeTNWaxidcHeYD5qdk/yeUEgJbgt2NVmlgI2KcxOnKdTmTye1kyVhxyFbPxFpwJYl8q66aPxp/unNoGHmW8Mb3cZMk+djaq5AqkdFyncG2ORn3KtghUnJ0DNrhvHK7bk0qxzTL52CKrjiQsuV81kqGJmapyHVNSADKqM7AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+lf30+2jYkr1NhAiWQ/Sm7u4R3xXGCMyWn5DBA979yY=; b=c+EVfkd3CnHn2TUW8v6oElzgjTrbucDj9Sbql9WRGFM4BOlzIMIXHf465MsO0tA59UQFAkg8EA+pFS50Z6OXv+BfU3yX3xtOAW/JHIaDtXsWT/E3/iq/9RkzraziyszflzoXpi/sddT/JHCxvu60hAej785QX6oqPA8gcIb1PFv9CCCUvEF9YpeZAqNjAqmdLdcKER+xs4ryCXjSPRj0lIg91tBn0lCg4RTVm8JhttzmN0s6kYhxY2oBMdlSE943TUUAwMCGpIfJRB/VIkqZrrc+jU6Yk0nuZmGDtktDxDGPNxdiIXK9b63IYw9s3KS6pS27Fhsn7OA9q0ka91emLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lf30+2jYkr1NhAiWQ/Sm7u4R3xXGCMyWn5DBA979yY=; b=JB1InzrvYMTN75lrYdC3cP5RPp0GxM9kgAyBA//BCinOPg1xYpYJOoWgdKqo20Co5BjyNJjBBB+F26BHI2qzmlpUfrWDlrYMjLdzmeX+IEOUe9HP3L/oOdKF767gzifbgLGe+1awNdBW5ztmdwjyjKdg1Ir7uWc147lmLyY1vmTtERajrlIEYbigP3kuZsl9dJ7AGlUjye5FrSYXm0/8v81ZYt79f/VwC+BULBglHJWHpqNJscOuT3LZhgB220Y/WNMOP22IjE8E7L6xVzWeHXXGxXzHfTT4ki/xl1LfY1JgZ3ob+LjDkkqC/AhRmmTTXUcUlqNLtlEg2GHLyq+yHA== Received: from DS7PR03CA0261.namprd03.prod.outlook.com (2603:10b6:5:3b3::26) by MW3PR12MB4476.namprd12.prod.outlook.com (2603:10b6:303:2d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.11; Sat, 7 Dec 2024 08:05:32 +0000 Received: from CY4PEPF0000E9D6.namprd05.prod.outlook.com (2603:10b6:5:3b3:cafe::53) by DS7PR03CA0261.outlook.office365.com (2603:10b6:5:3b3::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Sat, 7 Dec 2024 08:05:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D6.mail.protection.outlook.com (10.167.241.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:05:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:05:22 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:05:21 -0800 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , dpdk stable Subject: patch 'crypto/openssl: fix potential string overflow' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 16:00:03 +0800 Message-ID: <20241207080055.488538-46-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D6:EE_|MW3PR12MB4476:EE_ X-MS-Office365-Filtering-Correlation-Id: a3ba8cfd-5738-49c2-d1f6-08dd1695ebb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?oile9I+51DjRnWv1cFHztsiMdk2Nv/8VYq43tLVXEcIgHjSViudIw9xcI9A/?= =?us-ascii?Q?12iGFtOHx6sr02P0H1MzQzyRoNxZfpSiT4bRyTjIsIgzRIekWFRWc1tepvRn?= =?us-ascii?Q?t5doK27gpbEbaQY7oT8vtbW6/HTWbtCi9MPURqqYTmdkKa42BkFj7qRXg5xN?= =?us-ascii?Q?cftvRUW0i3trurkNXJiN0Dx2IQYCJgaeIGgfSxmzv0mydut/C2j/UYw1Fx3S?= =?us-ascii?Q?0J+HbFrzWZr4e7dB9WM9ptcUJ2jygRZb4C5Ko5iURBb0pQufsS0YCkCFM8oR?= =?us-ascii?Q?fQ1R0SuP4D0top094zEV0+V0gKsXIAmsKjsdADSq1M2Z4qz01iSF+fFLgzSn?= =?us-ascii?Q?eTOiwr0aKlisJG4pKR5+y1hy5GUHn9yCSa3YcVpZxqzpO3iYK/eqZvbIfWPd?= =?us-ascii?Q?sH5scnLAG8UyjkUiWB2eXPMKUhErjVMUVkUNnWcCeONer0KA67BWngFw79hX?= =?us-ascii?Q?Pqr2HxLAypJwNUPtBaCyj1bRW5aXEJtKKnQd7HzzGl9lPq697nQF3WPD8uIa?= =?us-ascii?Q?Q7Cjw4c8XTt778xFtTas2ERPDZ3kIcMP5zj2b94xkprIHTYymMZbcPhYHc5f?= =?us-ascii?Q?SryNUrDH9T75MyBasApGrBdTqAecpajwdT7YQmumxT8rCjWvgWmUSwBbFv3A?= =?us-ascii?Q?sJ7IDIx/4x1BvEq657l5t7Se+0+7qH5RRwwV3CEeWo0+zwjsMadEleT0MHgv?= =?us-ascii?Q?B8SGY2sKK1Qb+41T+lFg9jpvWqtU/7vvv8Pcohsezd90W9i9bo+jNkmBfgp1?= =?us-ascii?Q?BJzz3geJymfHpra6Pe90mPqLX9naoPBpRsfszig8dV/0CklWVIL+1f18uIK3?= =?us-ascii?Q?t5W7Ay62zxizBn37P/WE31R2Wv/Od9kjW/dDndzSKVf8qu3blYjoNVSx4aHH?= =?us-ascii?Q?hZalakTSaIDcpweph1a3EFF3y8qpdorlOjFYTHT9AngeGuJR72Buo4AKZpiV?= =?us-ascii?Q?KfGx4SdGKoXBsQk4fLYwCBuZEK6OW2rBkQhFPm0UfSEdesWrxzvYL8k76j6u?= =?us-ascii?Q?r/rdrS4xan4C1nsu9o45IaaqGi/28vsH05+Q5/nCJqgyFHuWHBKaMymAKCHH?= =?us-ascii?Q?gd/oEaN1JJiZYk1BBCRGo3WC9w0Hsn5zUfnu0FHLpgWM8d0gK7V4mkB9PrRF?= =?us-ascii?Q?U5BLIvK8cMNCWwJ7MjYrxuTYKXW0w1TdFAu2vi5KToY1x6mfxK94QHpEwExE?= =?us-ascii?Q?LL0ipteD6vK2kDy4GUaAN6w80zXtHAnJW6wywi+wkrJh8fgc7VwNJw+LMyy4?= =?us-ascii?Q?FbtNkVWsXMDc6ofpXpIZP60uZqQi8jgeacKwkGcvy15WQCy4QWB4yAayZ3zP?= =?us-ascii?Q?BiXBN9ZlXvLirzpKOrQswU59RUJkvoeBdzIEW4jsXkZmbFIdgQXnrHpHzJpH?= =?us-ascii?Q?FPp+I71PzcpF47jw6CzoS3K0igrR67xYmad2n+2h85YQQIM8vShpdiOHuMw3?= =?us-ascii?Q?AiSwrPvXj/GqEpo2lyi+0l2/6lFe04ao?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:05:31.6171 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3ba8cfd-5738-49c2-d1f6-08dd1695ebb7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4476 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=5bda3f3b964cf700d81e203fa3a7fac459b26c60 Thanks. Xueming Li --- >From 5bda3f3b964cf700d81e203fa3a7fac459b26c60 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 17 Oct 2024 09:07:53 -0700 Subject: [PATCH] crypto/openssl: fix potential string overflow Cc: Xueming Li [ upstream commit c5819b0d96d1a24c25aa4324913fd2566eb19ae9 ] The algorithm name is a string and should be copied with strlcpy() rather than rte_memcpy(). This fixes a warning detected with clang and ASAN. Bugzilla ID: 1565 Fixes: 2b9c693f6ef5 ("crypto/openssl: support AES-CMAC operations") Signed-off-by: Stephen Hemminger --- drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 7538ae2953..017e74e765 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -677,7 +677,7 @@ openssl_set_session_auth_parameters(struct openssl_session *sess, else return -EINVAL; - rte_memcpy(algo_name, algo, strlen(algo) + 1); + strlcpy(algo_name, algo, sizeof(algo_name)); params[0] = OSSL_PARAM_construct_utf8_string( OSSL_MAC_PARAM_CIPHER, algo_name, 0); params[1] = OSSL_PARAM_construct_end(); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:45.597487009 +0800 +++ 0045-crypto-openssl-fix-potential-string-overflow.patch 2024-12-06 23:26:43.943044828 +0800 @@ -1 +1 @@ -From c5819b0d96d1a24c25aa4324913fd2566eb19ae9 Mon Sep 17 00:00:00 2001 +From 5bda3f3b964cf700d81e203fa3a7fac459b26c60 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c5819b0d96d1a24c25aa4324913fd2566eb19ae9 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 0616383921..b2442c7ebf 100644 +index 7538ae2953..017e74e765 100644