From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D7C345E41 for ; Sat, 7 Dec 2024 09:02:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52D2540281; Sat, 7 Dec 2024 09:02:06 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2072.outbound.protection.outlook.com [40.107.96.72]) by mails.dpdk.org (Postfix) with ESMTP id 5A38D40281 for ; Sat, 7 Dec 2024 09:02:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BB59Y/hnptnxAHujsoldBe2UkcjMR0w/+TPGkEt+Y7cKAwPiQoL2bZFJED62HpXe6Wo3xSSAVrgkNFlXTEv6HBwdCD01dkUv8gdRRwiam4jlOvz7bkKFESe8PcOboO11PdUNhEjhWWQd+pllmWbn4B/SZHUbr0HFtBewP9ul7J4XOqn1rH9QGZCVI5qQ1WbGSlIeOEv6LKZeQab7H8r83GpQJ2mXNwYbAJ2uvwxjw01gfP/LRLEU7zW5UHI37qbSj/xXJpDJRr4hFmvDa1TNDek8VHL8xunsbi3xznEoG6XPsBZQhvtQWCbebw4xqFMxB8M1Ys6Fujs0oHwGP5Zdbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dtmxaBV5K0WTrqt1AnXlYzciNxDXjlXdHDCoqdbDVGw=; b=gkvqBt+2Jy2Vm9IcKdp07a5FWljli9z1r6dFBfelenfxVe/oCzqmIcx9gmBbppPJ1aPNtBO4ZCGkMuwIRlwihdEvgt0GY8w8cGQh9H06I3NaqL4qc+JB8o70cHIJodtxzl7zYoVwo3Edx0fqHDFTMUdFdSgZ9XeJtJqE01YbbcGZsvVSnw5uLCVUpTVoFoIFPSyFEf3YuMjjZrmOnCLsjk/4zwIh3Rfjsf+4i5tR2rzBgbRa55KjB2ffYQ++IxFimZ3AVtq2zyUcDDdLHpW6bVWTgnJ+MJG3m0AU08rMgv6+FCunmZivGTPgBo8h1OVM8nA7xer7mkFpsFjTP+r9Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=perftech.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dtmxaBV5K0WTrqt1AnXlYzciNxDXjlXdHDCoqdbDVGw=; b=nA9IOuqlkVIsbBm7rbDQ+abat/xZTKJbLr0VGX88zHmSvRNvFuCTVJg+oqtwQcskJBJ5c2rKbw/azlkMH7mbkqC5YylW/IOLNOtS1V4pFSW1qq7TzOm3wad1A+LSYnCtnwmO0ipxGGBSAHnXEyc9gJ5gsfBfqK4+sbt0p9RxC8iK+SBmKAZWPHm/RgrrFZUBcdEhXsrKG10tGxVhlo89ohPwY6HiO/2yH9u7VGruj8+76rlMoQNRXSev7zbk/TDFar7AUn3g8RuyiiGYZTr+HJ5fLQ7SX4WYH/ZKSDtfwcXut/ZGd9Pa3XEtg9EjQf4usg4jwIpAaNC1zW9xSqUb6g== Received: from DM6PR17CA0026.namprd17.prod.outlook.com (2603:10b6:5:1b3::39) by DS7PR12MB5957.namprd12.prod.outlook.com (2603:10b6:8:7c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.20; Sat, 7 Dec 2024 08:01:57 +0000 Received: from CY4PEPF0000E9D5.namprd05.prod.outlook.com (2603:10b6:5:1b3:cafe::a1) by DM6PR17CA0026.outlook.office365.com (2603:10b6:5:1b3::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8207.19 via Frontend Transport; Sat, 7 Dec 2024 08:01:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D5.mail.protection.outlook.com (10.167.241.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:01:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:01:43 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:01:41 -0800 From: Xueming Li To: Lewis Donzis CC: Xueming Li , Stephen Hemminger , dpdk stable Subject: patch 'net/ixgbe: fix link status delay on FreeBSD' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 15:59:23 +0800 Message-ID: <20241207080055.488538-6-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D5:EE_|DS7PR12MB5957:EE_ X-MS-Office365-Filtering-Correlation-Id: 69e09dca-e8fc-4133-252f-08dd16956bad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6cvLA3qu6xLrkDIg2w+UK9D/F2fRe+cCsDqhIWP+I6X5bk6M7J14TBmbS8sG?= =?us-ascii?Q?JJCg7ScwTgl2P4A4s4fvRtM1ouifX6X2erwOoAO7b0kmm44E7M2KFYFihxTB?= =?us-ascii?Q?q+fqj+jEqBax3hwlibMoR5vxsQiHLG4We1eu4DpDexH9tDXONlV6k4NQ6X8N?= =?us-ascii?Q?u3Ub6xL4lGKtQQo11dmlAc18xiatskd95uGJnJEZEjIsprhZsll2HKdMnH3w?= =?us-ascii?Q?tPvGy0G1qZ1JIvOt/EUjGnaM4VS1hYnyTlfStq3JcxdL3zA3/ML36WzkPwV2?= =?us-ascii?Q?Y+9iJZyaSV7komVKMJD1AOPGRWr8QfkEvFadAxtXILeORF3T3WUj0I6KXeXZ?= =?us-ascii?Q?nNqZ+chXgYQw4ahAoYK08pdBrjQmWLn2KO9j1TY5ldTpExU0J+3ZiDcr5qSo?= =?us-ascii?Q?Q3OsK9+MM1+ScYpMk+UMBVjU2XkeszdIksDNq1ZMzsr0k7bOhhvX2lp88bLL?= =?us-ascii?Q?32KZbu7+tkNsYCYijECqlLT4tYJbmZPK5N/3dVedlnD1sojerhSlCG3dhzS3?= =?us-ascii?Q?MIfqWbHmTgvzCgsaHv3gEXI3gGbWiWdM0cqqpjpRC0KNs+2a0WAxDwWmJbtH?= =?us-ascii?Q?oUVfcAyIXv7UjUf3OwgPkY4K8AvoH3in48MlRD6WCYf4RmvBNCkjrQmV46t3?= =?us-ascii?Q?IBK3BSgRMelrDYFQE9/SI81WSFl9+WTNaz1IoPw1TlOG7zWJTPFRs3T3oEwC?= =?us-ascii?Q?8eMkkECsjxlagaG5n7xx7JYfHewSWyAkbhTtL5zsjb6Vd4veVBmwrD3hHb1y?= =?us-ascii?Q?YrSbnzgvrOnIUBVhZ9wUGsOOMUF12VWScnZX0js7PwbPn5hBeUeT1YsiQlyG?= =?us-ascii?Q?7K8k+CCrmVcHuvviF/psVTiMxOttToA5NyOOQmkPL/bnyGxIqGBv4D4CQTHt?= =?us-ascii?Q?54ybzdSDdeGLfOWCgBUB9/XfZc9f9N3fWqj/SXvfcxBrbCUYu+mgxrAHE9yg?= =?us-ascii?Q?JtMhzhAiEwIH2TIeLAhr1Mo2HYx/TCmFyF8g/GlBZEA15Rktp/zrQmVBS7IX?= =?us-ascii?Q?vQ7Xibd+c4kQydZH97pLWYswH7C7ePrWh72YsIKRlWjtdnUWeYNwDJNt+X2G?= =?us-ascii?Q?BcPU0YaJ3UUxl0/WXBbEGSPBPPpLiddU02viyC8I7DPFwcVipwNwk+XkIRp3?= =?us-ascii?Q?AILDlKPfplkp2+HOTnnpvDcsL8ML4cI98d4Z/fLnluY5wAmjP4Sb3gZRPFzL?= =?us-ascii?Q?WGuCCrS495bQ+00chmGaWni9F+NGAOrzNF61NVJdbNpbHV+c6JCPlezWLemO?= =?us-ascii?Q?P1HNqqXD2fMrfQlDIdABXoif+bcRvlw5doJAeXbQ3y6lWmDwFOTREEaNE4V/?= =?us-ascii?Q?kHUX4nw69nRw20och9yrX7s6wAExmvT/4CxsS2dsve4FCrYzlx10skiSvuAo?= =?us-ascii?Q?VL1GJAODMaIpSMafBIxf4N7xd8JwAmPIv8ecHi5JTeAGlWA4PoMnFN4ZkXBs?= =?us-ascii?Q?Ro/KKpTQ7f+1eONx+J/Siw2Ex8pusVsD?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:01:56.8301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69e09dca-e8fc-4133-252f-08dd16956bad X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5957 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=d30bef9034c7ebb54096d40326bcab0ed78e92d3 Thanks. Xueming Li --- >From d30bef9034c7ebb54096d40326bcab0ed78e92d3 Mon Sep 17 00:00:00 2001 From: Lewis Donzis Date: Tue, 22 Oct 2024 09:42:05 -0500 Subject: [PATCH] net/ixgbe: fix link status delay on FreeBSD Cc: Xueming Li [ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ] Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true, even if the API caller requested no waiting. Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD") Signed-off-by: Lewis Donzis Acked-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 3ac65ca3b3..f4ec485d69 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4305,11 +4305,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) wait = 0; -/* BSD has no interrupt mechanism, so force NIC status synchronization. */ -#ifdef RTE_EXEC_ENV_FREEBSD - wait = 1; -#endif - if (vf) diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait); else -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:44.310023424 +0800 +++ 0005-net-ixgbe-fix-link-status-delay-on-FreeBSD.patch 2024-12-06 23:26:43.843044829 +0800 @@ -1 +1 @@ -From f775386d92d68e534600fcff3fc4bcaa30d3e68c Mon Sep 17 00:00:00 2001 +From d30bef9034c7ebb54096d40326bcab0ed78e92d3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index ab37c37469..008760e315 100644 +index 3ac65ca3b3..f4ec485d69 100644 @@ -23 +25 @@ -@@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, +@@ -4305,11 +4305,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,