From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B481345E41 for ; Sat, 7 Dec 2024 09:09:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEC4740E4C; Sat, 7 Dec 2024 09:09:02 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2086.outbound.protection.outlook.com [40.107.100.86]) by mails.dpdk.org (Postfix) with ESMTP id 213E240DD7 for ; Sat, 7 Dec 2024 09:09:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dzn0QLS/HyWkU82f+LSjqXoScHlUHGWKHFtY/NZzSV/OCJ7vTppFRsZNfmhq5Mz4TGu4Ej9zJR95zcbMcQCGqsX6+0P7Oh8Qgvbb3I41b1a9k50NeUImxjXQ4n0UHQYevhhfY49/oTCbhW4A+DzN+fivL2nWtD/aVuqz0WB6O+sgUhWYtSFFAVoaXMqPcQf7f6qn2mMicERj9md2V4zK59NX+007T6X7kcAewXv4p46YEUMaeH0mvPfKoSPxNChYWZElIebUgnstsJDLDQyEUy4w8gw/gtzwf8LtWacpscGWUnqQrlXzmL/2DpGZt2z7NXmI7tym0nAJNK3xIFTfUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=raYJbImuCtu3XvojRimuAYAM1nTGSzK82nUrWfEFnHU=; b=GghLqZYGpXEy+ihmevc2gcSGQEt6Scwr9uJXsetMbK7tuCqk9uk73ra4VZ9UhqLNO1P/dDf7YW7V9/lxswsL9IEtyS/uXCYX0FsWYb67ynnjKH6D0aYbQgbV8YCZEDz4JDhaw5BNDFpnpA+qi7HaDdWAP4kJcdHRoNv1rj1lYEkC2DzrvvzBBriM4wiN18JTrxZEPbiJSFqJ2Y5Lw1QWEXp9CbQYAq/HBrZcHX6ts/6bH3QWA6VffZJm2YC+wC4ZNbVe45/hKgpJkhiAd3y55geotkSL9X4OTCnmkXTCBHUdB7++JDbIVqvSs0TQ2pve3gU4+vXFccw+oi14IHSqbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=emumba.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=raYJbImuCtu3XvojRimuAYAM1nTGSzK82nUrWfEFnHU=; b=HX61efJVKu1kaI/ZeftybA+fgYipEKKou+SV6Is1f6RVBiKg1NFvu5+94psRfNczuXost6egZHumhRT/Ttx9SApH9wxecpHxmLlFQJE8lp5soST4waCvmA5p457Ig12y5AQmWDhy8SfSVsd6BP+wwYiAkwyv/ZQNUuCEZOxY94r3axXuDFqH1thHkQgluMaLeQzkZvivSbniHovkpkrpJhAPOwPRPIgiswaa5rHQOLsuXN6bbYr3FNKknNkioF5MzlPP7z7nyiN2oNBOAefSjODpUkLtb/zp6uplZ/aMHxWoum5c0DgwhdvWZVue0w2e7S44vX94g8A5gNdxtJpnvg== Received: from BN9PR03CA0298.namprd03.prod.outlook.com (2603:10b6:408:f5::33) by DM4PR12MB7622.namprd12.prod.outlook.com (2603:10b6:8:109::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.20; Sat, 7 Dec 2024 08:08:57 +0000 Received: from BL02EPF00021F6C.namprd02.prod.outlook.com (2603:10b6:408:f5:cafe::ac) by BN9PR03CA0298.outlook.office365.com (2603:10b6:408:f5::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8182.16 via Frontend Transport; Sat, 7 Dec 2024 08:08:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6C.mail.protection.outlook.com (10.167.249.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:08:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:08:50 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:08:47 -0800 From: Xueming Li To: Fidaullah Noonari CC: Xueming Li , Stephen Hemminger , Chengwen Feng , "dpdk stable" Subject: patch 'app/procinfo: fix leak on exit' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 16:00:39 +0800 Message-ID: <20241207080055.488538-82-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6C:EE_|DM4PR12MB7622:EE_ X-MS-Office365-Filtering-Correlation-Id: 166e1530-b233-432c-6d0f-08dd16966642 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?afn5GvS6PEpxwr3GcIKN5hm6yx/EHMeB8pcjEWR4zo5FclE0+jGpW31buLKF?= =?us-ascii?Q?JGazMviBNP5Qp6Njdxe3nfY0NpjtMSAqvq2gWdYxTlMXg/HaZOveVuBTselM?= =?us-ascii?Q?VuE2yl/m3EfhyJE3H/jSNsFrAMDBxlWlQ2sppINCdFFvP145ja81puIFA3KG?= =?us-ascii?Q?VjkUaUKaUfN8A+xxBr8tPJ5l/P7bYXyOA2BZQY5fV0KTuM7pGSJfbFq0GH4a?= =?us-ascii?Q?GDmhKssPjM78zvcBGDiuG/fjTSJio/dRJRrldS6xh1w8l4QvGA+HcfheZIgM?= =?us-ascii?Q?VPReoAk0pdouwWeUNlQrz8OerNRxS0muamqfMUcLd/ghz+NxcM1nkmoym5XU?= =?us-ascii?Q?aZS/qtdS08Tq0pIoOW+CcpLEdS5PuQG8ezT9Z8QdFW9vIz//IF+PW1jEojOZ?= =?us-ascii?Q?2zjEwFf87nXwiguYgxXm3lV3h+qY29A0/6nTIh8+KKDiKEbZ32zt28USvV0X?= =?us-ascii?Q?A4A9IKXc5cCqW7iD0/6BBQkSHtUL3DrS7qljZ4HBWms9DnPLMP8ICoSlM/qL?= =?us-ascii?Q?csttldy0/NvuUsJ21nFQhZnFIG0Im1vu/guUXtHL4tgPX7+G2IO9V0rD9WjR?= =?us-ascii?Q?zDJarPyQ+ZFWRVbD1ajnSDVCIMneDQxWFqKnACOn6Azd8+DEFxengIcQecXi?= =?us-ascii?Q?SEo9NwnnUQC+Evc9DCE2OlbIp5JxKL1MU8P7QbqPCa0+TfZtEAiDIwet37ZX?= =?us-ascii?Q?kYtQrjM7L0Srnya83GOgzm9g8JCDO2PCN9EaUaTvaDbtJW1vkgsIVSOeLTpL?= =?us-ascii?Q?Q+5z9++WVynzt9lQsAKuLIqGNxIIuP0koBwwQ6So/ZNL6myo7uapjpuDu3I9?= =?us-ascii?Q?YkQNM/DLwCB/WLpDcVUYi4jpIua1QWtfNhbk6Lbd5uu+0O/Efze/TXhAJK/m?= =?us-ascii?Q?622z4pO1LUqy8Q8ld5+y+DzKcOMw1EdnnHT97QY4i8XFzEk8ocpaA7C4I8Kg?= =?us-ascii?Q?Ca6LmJ8pgv0401+LCuAaQzbqmJRt03/mQeSBCqVwibpGlurMyCxpltRniYXI?= =?us-ascii?Q?SSwxd4gZ+NGCa3KHMDfEiM0qzME7t4JpQzZbfIpQMI+It4+RkNxRbio/oRai?= =?us-ascii?Q?zUN7yxpF3gryEjtOdEGTwv+u6PJRkdOQ3IguMXK15u2mGp/dnS37z4ejmNDq?= =?us-ascii?Q?JVOljqpye9NLKvZpHNrDZKYiqOSzg0/sRH0TbZ5sEHAsdGSSQbpiJ2MrkV6L?= =?us-ascii?Q?o0uCw4zRaMTLkJ/bhgs79flpGNoxjScKoOEkxFAodb4Yb9HBbCo5CnbMvRfU?= =?us-ascii?Q?2aXXEqfn7S1gQQavxR8+Pb6q6sEE5diFQ7Ak1pMIAIkYw6piEkQHTlo1k/7h?= =?us-ascii?Q?RggJW01Ph0sTzH8aSbjLFV238JyxuCEnFTuxNZsmHcW/TPUZ/t/4Bc2MdiNl?= =?us-ascii?Q?v4MCD+cMaz1KtDW84n/d7K90fInAn9oSx0GpvILm3I0swmIc26ZAbSXmdM0A?= =?us-ascii?Q?9x23B4M+xcEugGzw3I38zsWV5WJtfsUP?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:08:57.0982 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 166e1530-b233-432c-6d0f-08dd16966642 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7622 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=8dffe1833feaac46a3a4c48c2b8469a2e2007cb7 Thanks. Xueming Li --- >From 8dffe1833feaac46a3a4c48c2b8469a2e2007cb7 Mon Sep 17 00:00:00 2001 From: Fidaullah Noonari Date: Thu, 3 Oct 2024 19:48:29 -0700 Subject: [PATCH] app/procinfo: fix leak on exit Cc: Xueming Li [ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ] When app is launched with -m proc-info exit without rte_eal_cleanup() causing memory leakage. This commit resolves the memory leakage issue and closes app properly. Bugzilla ID: 898 Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit") Fixes: 674bb3906931 ("app/procinfo: display eventdev xstats") Signed-off-by: Fidaullah Noonari Acked-by: Stephen Hemminger Acked-by: Chengwen Feng --- app/proc-info/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index b672aaefbe..4a558705cc 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -2166,11 +2166,11 @@ main(int argc, char **argv) if (mem_info) { meminfo_display(); - return 0; + goto cleanup; } if (eventdev_xstats() > 0) - return 0; + goto cleanup; nb_ports = rte_eth_dev_count_avail(); if (nb_ports == 0) @@ -2251,6 +2251,7 @@ main(int argc, char **argv) RTE_ETH_FOREACH_DEV(i) rte_eth_dev_close(i); +cleanup: ret = rte_eal_cleanup(); if (ret) printf("Error from rte_eal_cleanup(), %d\n", ret); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:46.802334304 +0800 +++ 0081-app-procinfo-fix-leak-on-exit.patch 2024-12-06 23:26:44.083044826 +0800 @@ -1 +1 @@ -From 8a171e52ed8b26f768ced79a22286914ebd30180 Mon Sep 17 00:00:00 2001 +From 8dffe1833feaac46a3a4c48c2b8469a2e2007cb7 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 6886eb373a..e1272164b1 100644 +index b672aaefbe..4a558705cc 100644 @@ -26 +28 @@ -@@ -2171,11 +2171,11 @@ main(int argc, char **argv) +@@ -2166,11 +2166,11 @@ main(int argc, char **argv) @@ -40 +42 @@ -@@ -2256,6 +2256,7 @@ main(int argc, char **argv) +@@ -2251,6 +2251,7 @@ main(int argc, char **argv)