From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F24545E41 for ; Sat, 7 Dec 2024 09:09:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28E9040EAB; Sat, 7 Dec 2024 09:09:35 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2074.outbound.protection.outlook.com [40.107.244.74]) by mails.dpdk.org (Postfix) with ESMTP id 9BD3E40281 for ; Sat, 7 Dec 2024 09:09:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xJNssUqdjjiHv/pZTiEI3qDWgOlX3En4xBmFndfmrpzz22lME31LXf+N85yvgKWNhwdXBXHfgd+zGjleQvpO893SY/l49EEMfLYWSWzkzRI4Jbrdcp+wdDFpIh7F3yh2TfLx8iL2jO2fVTYJmDLXZ3lK2GwTCdjNvym0npsM6gN+/nX+i9nIZXSCL/FCXQXksWt6zsdc93ocrGOf+MzeYuHc0M66dWovSWVeLwcfA2EvL6iJz8sq05esIrmUWyix7icMwO++nYQ504QMZT8kyHSovolKiuqSsa7/zax2YC+SdxdTRzWsSuCnif+yTewBx+jbOnF7y3ywC+QTJRMU6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CU+4FgF37lqMynRAHRXilYo+JMigPwwrnRk91W5uGkQ=; b=Tornh3XV4pCYALqYR6HJsS5d10WX8yZ3ozvr991GiBdzg0BTUR4HuiEI1S5lITm2Nt74v/EA+PH6iWXdcTTWNYbxurr4HoeXn+9pgIhbExQzGfPU6lNOAKH3gRYH9NjjY3h1zCs5K2pFN7J1vJEV15oEMzE3IqGMU+w4bHZCkT+kxGyvyTuLqdpTS8kn7XARaolPvzLABs6q6oWnNWJ0KRu+tC2GD5LBPppv1sX0PoYDtQbo+ngTgr955KZsW7KepxQzUbcCc/6B+63dJaHjp/xBn/A3tbsrU1LuHsCIWmDuN23FxD9jLzrjoiCK6yf7ShUXVcMo5nmA+18UCHyQ+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CU+4FgF37lqMynRAHRXilYo+JMigPwwrnRk91W5uGkQ=; b=En93LvqBuJQNgPGNyL0lP7kyuknuzISK3Cf2v2TlOOk3qrLQVZcs6JVocxYqh5Ct5GhKA/lZjKG1mTG6ecVgG3fX8YLOXbrlMJNSHvPK7xQMvqGjmiFkYHOQe0moaTzaqgHCNd3ppmqfK64kiuA/O82BxdexGVXDYS42PlztUgabuT/k4tb7DOBdCer0eHCT4bpqTMlb0xf6tm15YWxwCxYZeYwQkgDjTsPCcrtuLmqJ7NnQhRGoUBkrp/TYDArTh7esOpMQWb1J45v7HfDT1Wl/kN1xfi402v+ezSU2Yau+8YQGgt/SLDiwJtxTSIj2jWmmrBUPZzTbv1GLAxQP0w== Received: from BLAPR03CA0087.namprd03.prod.outlook.com (2603:10b6:208:329::32) by PH7PR12MB7939.namprd12.prod.outlook.com (2603:10b6:510:278::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.18; Sat, 7 Dec 2024 08:09:29 +0000 Received: from BL02EPF00021F6E.namprd02.prod.outlook.com (2603:10b6:208:329:cafe::aa) by BLAPR03CA0087.outlook.office365.com (2603:10b6:208:329::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Sat, 7 Dec 2024 08:09:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00021F6E.mail.protection.outlook.com (10.167.249.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:09:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:21 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:19 -0800 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , Bruce Richardson , Chengwen Feng , "dpdk stable" Subject: patch 'test/bonding: fix loop on members' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 16:00:46 +0800 Message-ID: <20241207080055.488538-89-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6E:EE_|PH7PR12MB7939:EE_ X-MS-Office365-Filtering-Correlation-Id: 91556c53-0c88-4293-881b-08dd16967922 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8w/ExgyTcDt7DtS2jkOmtnz3Mdidi/sR6I15UlJcBOr5nKdk+bWhwTB3YczX?= =?us-ascii?Q?J7ZWG0K/+xuu8vyVyIn4KYgI2vhISP2P7upL32OKY41iFL2nc162LKc0Kgt9?= =?us-ascii?Q?suSnrwTgY8/Fin+Tvp7whksyfduoj4LYQz03H3LoVOsMUHk3BAzLo15LG5h+?= =?us-ascii?Q?JwSQGBk86UbWom+ooXrtdyRCu778DKtjytKLzA/hMv2ZlGriqjy9JsD8JZnb?= =?us-ascii?Q?xGKJbGc0n/npLWILnOmfbeXWLIhk2A9acg8lwwHBmki0nGMmPUurUbGmd6UN?= =?us-ascii?Q?hZhKFp9vCVYWL9kjwtrHqLPyY6cfDKZDCGlUd1TTxz+QfKq0H33UHvIE6l3q?= =?us-ascii?Q?wjEXrkm6EgF/Y1L0lSrF3dnFSKGP60LfzHyEojoGcZ8MmWXl8m+dEdpwsgG+?= =?us-ascii?Q?iQPCxKY8koC90z4EJFlaxihvtgDgyky6TsiiCKFeX4GPDx8bK5IFihfCzvXO?= =?us-ascii?Q?4yr0trMYjJ3Rq8rLF9PxAc2LkmHul/KokySCCvFEwenRoHFgUtjk9PjWuig3?= =?us-ascii?Q?slP6RZg/mu3667442DigH1E/FVZcs8uDpTs/stICnx4FsqcAA30UGWWXaVH6?= =?us-ascii?Q?u0p5mYkVMpM4Eq/YdPBVc9fMSjOlA38laMe7quQX8u7tWio256kIz4xGGitq?= =?us-ascii?Q?PGYKq0rYMAByAa/VH+F9in17VZh3wYbo4xuNQZ8p6BGAB++ObA99Rz5nEhvA?= =?us-ascii?Q?NNcsFj0Up7D/XOJupw9Nr4q7GKKeD3Od3k1gL3u/rPT67nrT60klvemSgICT?= =?us-ascii?Q?2R5lasqJcCK1k8WvjMMl+725Ge8j+PUhJ6BFUlat+JmDuCmtikmzGv+QxDlE?= =?us-ascii?Q?XtT5iEMW4vANdoQz95WNqkGne42M+CZwPXGFvKgEIaoE4fzsiMD3qrcMIZoF?= =?us-ascii?Q?d4GFD8dl/b9aB6YZc51tiSWd7ndrMw/22V3Ppp8JhhKWN1QlQTXyLUB73UAE?= =?us-ascii?Q?f2l9A1mQvW8qxZYyAe5yv6FA5TFm0XrjJUUO/VKR3gLf4e+nqqZOdPY988MZ?= =?us-ascii?Q?6t5+b78w1pYbTiWPXEI07gIffnahnFNwolHEE7k5kqCW3sf3BB5Vk1tef8VQ?= =?us-ascii?Q?5y+tq1L9+gRyHTc/3F8wLbALc4mhr5iSh7gWD+mFObSC+O+nllkx00maPGT6?= =?us-ascii?Q?Qm6r1s8CKDRlMm1BCDgTbWeC5N8fTCto40zolioJ563Ln9YAGY37GBInBOES?= =?us-ascii?Q?0nnLSQMbncJq62VnJ5yAQ6DpYP4aC9xd6pIxqMZJNA7+pFCqWfakBK0PDXmk?= =?us-ascii?Q?r+Do/uurX/DDLEl8cjMSQ/bdQ9gw3mcg2sgHHo6zMSYaZ++BRPs97hhuaZo0?= =?us-ascii?Q?J4Zl5Cm6O9el3DZ9urm8JNPnmbQiLD55dFAX05uVB2YxtM/uVBC7libZm+bi?= =?us-ascii?Q?lAcL54wlf3M0ytzUFtd6zcI7OB76WxYSqf+iZgVpVeR2fzv0zzQWXz4S8uZJ?= =?us-ascii?Q?LP4lrQajz5SVekzU0eFJKmkU6uFlGkaU?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:09:28.7658 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91556c53-0c88-4293-881b-08dd16967922 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7939 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=7f673c3b33515090cab7d1d15d0f6459a3944b40 Thanks. Xueming Li --- >From 7f673c3b33515090cab7d1d15d0f6459a3944b40 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:22 -0800 Subject: [PATCH] test/bonding: fix loop on members Cc: Xueming Li [ upstream commit 112ce3917674b7e316776305d7e27778d17eb1b7 ] Do not use same variable for outer and inner loop in bonding test. Since the loop is just freeing the resulting burst use bulk free. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/test/test_link_bonding.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 4d54706c21..805613d7dd 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -2288,12 +2288,7 @@ test_activebackup_rx_burst(void) } /* free mbufs */ - for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) { - rte_pktmbuf_free(rx_pkt_burst[i]); - rx_pkt_burst[i] = NULL; - } - } + rte_pktmbuf_free_bulk(rx_pkt_burst, burst_size); /* reset bonding device stats */ rte_eth_stats_reset(test_params->bonding_port_id); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:47.017864407 +0800 +++ 0088-test-bonding-fix-loop-on-members.patch 2024-12-06 23:26:44.103044826 +0800 @@ -1 +1 @@ -From 112ce3917674b7e316776305d7e27778d17eb1b7 Mon Sep 17 00:00:00 2001 +From 7f673c3b33515090cab7d1d15d0f6459a3944b40 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 112ce3917674b7e316776305d7e27778d17eb1b7 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org