From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C05745E41 for ; Sat, 7 Dec 2024 09:09:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50E7340281; Sat, 7 Dec 2024 09:09:39 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061.outbound.protection.outlook.com [40.107.220.61]) by mails.dpdk.org (Postfix) with ESMTP id C554240281 for ; Sat, 7 Dec 2024 09:09:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gbw2RGuZrg6VcO2/SLn7lKTYBbE9mG2tclftzupQFt65yM+uhrSHXrxaIZIcw3nriDJhkljX1VkPl51tWoSZKIidiaOMZRMu71VwARzjh4POshmo7BxkJhg3tlxdtaFw9NplG89XVUMKQiwK3dRIdLj54Vx4xGsmW8PKrq2/8O+pNtlKxwGVUUkcclBdGPTXFchO43m9uHXo/Tx9BYPDDmuKYAZyeBMpIlTWpykT8Zd0nBqVRfJXqT3orC9pDUDhzCwjpx2Vj6FT6t0bja2bodtJYC5+t9KGNjNzsj7CRll+OnbLjHv/GzTxfXMrEyDBQS1Lqj5zCKWcpjMIWz1ryw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3mC9Q6+ZVSLIYS8l9zQoDR+X04JsVM2lpnmbM9xpb9g=; b=BOw6z645gVRHJSDLoBsi5c/kO9h3cjchfpRr0SzLkMuXVKhsAs/vpzGo93lXgBhNQU9vijN6sXZm7nTuAYSWq0CgzF60aip4Q51RcZf+iT3r6VHnQgswSqWefx8x6lNu2mdzSle0nIYnoz2rfSUNZgyGgATh9yhDx84V7B/6ibgKUZGK6Wdrv1U2lAbACYE0c15458+ZthnR3Q7hUBpjuf2DQZ9xN9MASBti9yTrgQOU+Jy4rWao08RU4SuprhQODYnGUATgZvn0HBVQij7tBDAhjgt3BCscqliLUkQZ9OfMLgxpkyAUeO7JjTxBy3QClcoLorjR9xeR4OpKu354eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3mC9Q6+ZVSLIYS8l9zQoDR+X04JsVM2lpnmbM9xpb9g=; b=FfodYdN7cKgb6SNUsMaDrMcjrXhYJzUtOS5g0Z5ksuAv4aAZE7GKGBunnBg3u6pVzijxqtk808fKlisLC2tXID7fyMDZDDyCCMZZHWEM0ptkGtzCcCjyviYdBjADFO24Oy9bBpVMyW28WyxDqZvgvzejqXInS1NHrI2P7bLjXHakGaPS3+1k0fkM3ZhKFAQuzeAwVE/JRyG5/WuhsMd5HtcWwLNvSl2NnBVcicMby96DRDNSGOxJf8a3j6YTrX5uNuM0I5TQbHoD+mk1AkBsi3PppLbuYYRINlx3YADIMPMMRdrX/H2zUBXUvrIdkbjk9sZzYh6UMdCd8BUCiNVPzw== Received: from BN9PR03CA0299.namprd03.prod.outlook.com (2603:10b6:408:f5::34) by MW4PR12MB7483.namprd12.prod.outlook.com (2603:10b6:303:212::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.20; Sat, 7 Dec 2024 08:09:33 +0000 Received: from BL02EPF00021F6C.namprd02.prod.outlook.com (2603:10b6:408:f5:cafe::80) by BN9PR03CA0299.outlook.office365.com (2603:10b6:408:f5::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8182.15 via Frontend Transport; Sat, 7 Dec 2024 08:09:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6C.mail.protection.outlook.com (10.167.249.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:09:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:23 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:21 -0800 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , Chengwen Feng , Bruce Richardson , dpdk stable Subject: patch 'test/bonding: fix MAC address comparison' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 16:00:47 +0800 Message-ID: <20241207080055.488538-90-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6C:EE_|MW4PR12MB7483:EE_ X-MS-Office365-Filtering-Correlation-Id: 37932be4-8ab7-4b23-4e5d-08dd16967ba9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QedtN48in7D8TQF/GqFtJD8z3SB14b9zHeWCTXFGnz239QYPF1ydNHsuv5a+?= =?us-ascii?Q?Nu6/Qf3578Qy4PzGawltoffIpnw9fqFC5TeghnuVOzZ1ErCQQutzym7USP7g?= =?us-ascii?Q?+iHINg+HqigMXuJtrU+k9AkuLjWhdy6mEq0YzXr8h/1gM0B3rBXsPjFpMBr8?= =?us-ascii?Q?0CbRWboafoM5P7oqP/aKpsdmIoZL0z5OvaOJk12hRnMRh2YsUAlOWzHGu7YM?= =?us-ascii?Q?zGat0pjN/UuaApUN6P5kmPW9TFdbUSdsSMIlqaFLl4IlDIKihjj2WRKmq89g?= =?us-ascii?Q?seUjtmeWW1X1/Tr0mLiLgUIcexJtQsHbgz/v/g/HR9hlftT3XslnJnB+0SEH?= =?us-ascii?Q?B9GfFO+94v42dKPLEo33pC6xzlG0PiyYxFVY4XsEd4/VA6v54ulLNRNSi7lh?= =?us-ascii?Q?kVYX5JmFK1rCk+UNlSlzIUqhp4dVGhu/7hCCSfZ/cl4dBVxqC71YvOFCrgGb?= =?us-ascii?Q?hpL8N3ki4SC+mU4L2OaWrQvPyuKbbG2nAiNefLqbdo05119K3V0Panvg17VU?= =?us-ascii?Q?Kjkl0w2LqfV5kIP+IJUARDLgonOVacHkyLU3hnS4Qthi7eqriuaYZxEYhBRu?= =?us-ascii?Q?hitKdEJsqyvNJylKsX8JUEtZz10YF/7t1EZFIGokOirduLZ9St7WGHs1l+mq?= =?us-ascii?Q?Q+aFmGkuiyrqQFTcUV4P55TZcVeiu4NTl1X9FbMmh+aKqhNTvAH8HbX8aV88?= =?us-ascii?Q?2YCOQa057M1ZTKjZAiDuBwbC89/zARiu16qslm8BtLta4KNGiBB2YYpyjn+6?= =?us-ascii?Q?zLxI2TMNPQUIGbB94qW2r1J8CRa8v27ZgY3LHb+m5kVlYbMtSZbVJOEUx6dE?= =?us-ascii?Q?RmGJUeA2BeIpFQ5SBPqV7Aq/NdA57Gcmzy7o67Lo9Hhrc3akk+R391iuA1q6?= =?us-ascii?Q?EOxAmMkHk7YXwj6XQ2nQKnCJXYLpHKgmvY3rSBIoAdfGmRv21MWLvf7sZkEc?= =?us-ascii?Q?xTO7171lnnkHRU+0CwCKx7BSbnCyBI7ueC+U9MC3IJzq7Phv0D3OWcuuNYXD?= =?us-ascii?Q?G4/i1vdAUU4Btc6KcyiOHHkiuOCzLcVTA1PdUxSsZTDlIlKirDBecEB6RGEh?= =?us-ascii?Q?NLNDcj37tfFRkvHmIY1zzmDfj+F78Br6bVYSWrgvFTodVz4EPZoPp4UdqQ9e?= =?us-ascii?Q?0LdePAGkAniDdYgc6+sQDtAEemDsDXCT3CRKTmOahA/agl1FwCyb9J7r+qa2?= =?us-ascii?Q?evGOX/9hHg1C9BFijglUmUcT5ZmHOS40zW7TQDq1+5xaMFjmkZO4EiBdhC9b?= =?us-ascii?Q?N7QHuHwwOjK2TfhVOoCsfBzcwV7IccUkHSgy5oXvzuGXNrto0PHnW250AT7/?= =?us-ascii?Q?xPNYjOJbkEqwgTUeazelc73tpH9BzU9otk73WpgImCt3gp9QoT5hKgK1okQp?= =?us-ascii?Q?Ozx1ML9949hva25bB6ODPqhhZgtZx/a1eGiH5sZa9uzuv+C8l2GMMRC5urLD?= =?us-ascii?Q?lKwdcPscN4JpS2jL1ZDZLJ6YNjV55Xq+?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:09:32.9889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37932be4-8ab7-4b23-4e5d-08dd16967ba9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7483 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2f96cd1d38b768bfeb06277ceb520709356aaece Thanks. Xueming Li --- >From 2f96cd1d38b768bfeb06277ceb520709356aaece Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:23 -0800 Subject: [PATCH] test/bonding: fix MAC address comparison Cc: Xueming Li [ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ] The first argument of 'memcmp' function was equal to the second argument. Therefore ASSERT would always be true. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 805613d7dd..b752a5ecbf 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -792,7 +792,7 @@ test_set_primary_member(void) &read_mac_addr), "Failed to get mac address (port %d)", test_params->bonding_port_id); - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr, + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr, sizeof(read_mac_addr)), "bonding port mac address not set to that of primary port\n"); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:47.044001707 +0800 +++ 0089-test-bonding-fix-MAC-address-comparison.patch 2024-12-06 23:26:44.103044826 +0800 @@ -1 +1 @@ -From f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 Mon Sep 17 00:00:00 2001 +From 2f96cd1d38b768bfeb06277ceb520709356aaece Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org