From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACBC145E41 for ; Sat, 7 Dec 2024 09:09:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A68D240E5E; Sat, 7 Dec 2024 09:09:57 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by mails.dpdk.org (Postfix) with ESMTP id 71FE340281 for ; Sat, 7 Dec 2024 09:09:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ynPSz3JFcAzSfRAqZRAiSpHSWXNr0Da7FUv6r0Q9Uyn9XG9UDz8/aCoGI0igMYeMHMKO3dsRMVK1exkRBpMHJck1lgjYFfhYVBa+elapp2ywZW4Sq6EwPOyBdUx2kfVtsTLSb7NOlE83DFjWw5odI21njnI4J34IIRHqvUS+D+MkL7blxXtsO55w9NeCdRyA7Fum0ksW5sEshR/DikvW8Hi1+w+mHHt4aPDdqAT31qTd92faE6yRQD742XKrTG4P6nKWSuEmOO3xYIFCfcrY/HttoYe3QzTr28dxSd2s5znfeFRW02wWDSPzjvtNA3Mwihl4tyZR92qOtA2YDdODxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mg7JOwxLBBRr8WcHS9wFhAFG0V8LiUG7EOEGwM94maU=; b=fhcKfFzEJ8y5mCk4t6kLQi+w+gpUWESklc1cDesizk6DiOsFtimvcjS8f9NXuAWTKBU5uQ+KJ/OkRKTgfBsDSZfaKGwDk/gf4q4UXirmXr+Hzux1aOnxl1/4x4O5wk4/iSWz/HPWeMfkks1jqWior8eP3hBzyxvwpXLTB3pJJwls3GK8maNxHAKWXKp9N+DQ06X64ffFoJm2vkngGJjA51fc8YRWzifbHDqq1G2OiRN9RKzc1W1HVSaR2lcO3+QbNs/A9d8ZGIQfCBcJvrQ3z++XT6/v0fJw5mqjGjSDiQ/DvGHCdxfDX4RkQgM0rXvwhGDNfBE1B60+QWbYV047uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mg7JOwxLBBRr8WcHS9wFhAFG0V8LiUG7EOEGwM94maU=; b=qX3kgdPjzlUJMNVu8sgRzfJ/rbHViF7q7/Zkifd7a+WXlFXx0fFXAMgqSGhFpiuZomx7qXJ+H7OWMELpjgnjkj+03Ctq7JPGrtYpqNwdvFLM+zCdycMF9k3bF7Nv76QL081mk8NMzk6Fk9CCjoTW5P/ym14fut3MYBcebMNjg4j3kXXk8v7Crhhl2dg1No1iB4j12RZhPmXVfmf4oQUwu0nojityvPlplAz444YB7ZLzGLhwnK3knoOO5EBktMtO13u+FQOaFxR1iF6FQfH7YSvIJugZ7ufENjLTdqsCTFIIhqbWwp32QKzOOq16czq7FWGdIcClPbeYE2+eLyfMJQ== Received: from BN9P220CA0026.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:13e::31) by PH7PR12MB5854.namprd12.prod.outlook.com (2603:10b6:510:1d5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.19; Sat, 7 Dec 2024 08:09:49 +0000 Received: from BL02EPF00021F6B.namprd02.prod.outlook.com (2603:10b6:408:13e:cafe::31) by BN9P220CA0026.outlook.office365.com (2603:10b6:408:13e::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Sat, 7 Dec 2024 08:09:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6B.mail.protection.outlook.com (10.167.249.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:09:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:45 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:43 -0800 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , Bruce Richardson , Abhinandan Gujjar , dpdk stable Subject: patch 'test/event: avoid duplicate initialization' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 16:00:49 +0800 Message-ID: <20241207080055.488538-92-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6B:EE_|PH7PR12MB5854:EE_ X-MS-Office365-Filtering-Correlation-Id: 68bf5e14-7997-4731-7b94-08dd16968544 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KmYWpUMefcSYmC39p0Og6HxWdcWF31ajCHFDcE+8ukjkD11sO+OIS0Njihp5?= =?us-ascii?Q?h8bs7rjSDpjxryDDegMHXlWC6EVr7zr2BgKwg4garl8NkavAC1DuUYMgOYol?= =?us-ascii?Q?NUxwp7LgrjB7co82lUTnD8z2xvV1jK1lOpsNuQzp9AtsjCcFzzz5Vu2rqVm0?= =?us-ascii?Q?X5J6dZBtfaL4p18856nc2ewufkBaeOzuMja7mQz9k+nPe4pivjyBWN2V8J0G?= =?us-ascii?Q?bYFsn0S4RnPfP5glkEaWtwGMisVkPjKuqSl2eWJyzbM3h07lEghR8bU1TtDH?= =?us-ascii?Q?GDiDog5ibhwvh0vOur9GV9vxSFi7KtQQSmvnMMuPUlbFWLcSrQ4NDn/V9hGH?= =?us-ascii?Q?c5sdmpRc1lNtryCZHueQsx7A6P3BrUYYY4GgLb/dABIhfiC3BFvM3WJQjfxn?= =?us-ascii?Q?gbcrLj+hQrj8nHEwDoawtDyIvJ2M9XgFHRhvXPGJcq3orx6dwrOTaKh/jCyF?= =?us-ascii?Q?z7RQWj3ge15bFZtjcWb96wotqc+5hyrtNE1lH3G885zRsI7jZchfAOw3kowq?= =?us-ascii?Q?dtwOu1qjdHG+SLKM48ziA0sL1uagqKZPta5aUuZLV3R2NmaStBo0LflQYk6K?= =?us-ascii?Q?utek98xo9CPzPsmpwYfnXH/INhPi8HO786QZjD9Nbj5NcY5+wGlnczcjUcWu?= =?us-ascii?Q?nfu5J+YP1cSoB8wDgEn2ftN+VVd61v2P4dkgebmhL53MiCmpPAiwxT66wAbX?= =?us-ascii?Q?vcht7vRc/gHOrcXRukbl6B3abDfPAFGXtO15jyObC2pjqY4Hbuxvb1cpElpg?= =?us-ascii?Q?SXii+ljIQzEdlxWsgpDhuuQ62ZLnxCBKadcQmToB1VpCXFcTrn1x1DQpSeaq?= =?us-ascii?Q?sA77lBr+xOj9lKNWc4PNn3It6q0IihFhNYdSQdGnmD7lWA8OBCABRQF3STn1?= =?us-ascii?Q?DoHXCc+umRFI46MDP+wG1nVGbpZvxmpVcHmjdwS8NZOcoOumTkud/R/Sa1cN?= =?us-ascii?Q?n//dalIpjRYl+0ZPXKqQgoENT1L+3xMZY+Wl6OGv5tUYxPzzqOojsATynK1r?= =?us-ascii?Q?NBWM98DtfYUZbiNfouon/RvxPiacObEAmzzslQb/N+ETELBKx0AJ6jekY9KI?= =?us-ascii?Q?Zd+ssuoH0SgC7RoUHTHXDBPes+1hBMpVt6VdIMbQSwmRQL7cAyGFQDTTZuPn?= =?us-ascii?Q?YezPO1zKjz983pJ9aO9G7/IfezJ3sTxUpH9Z+3ySBxe7T8rMrJ0B9Ct7UNNh?= =?us-ascii?Q?arJ9jNW0JnE0pvFm2rlQDSPS6VVJhCRuzSNGW5jscqJBlnEU31q5ZPfigVam?= =?us-ascii?Q?H7dGnES4Dh6uETu7zZOSCeYlqvHdRkWf1gIWunV7gFhySH3p0bvQMSY2bogW?= =?us-ascii?Q?/3CeJOZl6eKOYwBfR1S4glW/Fk6cqCLvOsp28f/18DCZmYVDowWy/J/osNEs?= =?us-ascii?Q?74N/FIh6oiWN1PSQU7DxZO221GpDMjI+VpkLI/vWCgmVw2lIqaPzLjjgtN16?= =?us-ascii?Q?JAq8e/1p8x6lcY/VpCrBqzgXNqsRBPWy?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:09:49.1210 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68bf5e14-7997-4731-7b94-08dd16968544 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5854 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=30e22a764cf9edbdcb4fd394d08d720b5ad79052 Thanks. Xueming Li --- >From 30e22a764cf9edbdcb4fd394d08d720b5ad79052 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:25 -0800 Subject: [PATCH] test/event: avoid duplicate initialization Cc: Xueming Li [ upstream commit 8c08b10d047ac64fb98709871b192698663af7d7 ] The event_dev_config initialization had duplicate assignments to the same element. Change to use structure initialization so that compiler will catch this type of bug. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Abhinandan Gujjar --- app/test/test_event_crypto_adapter.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c index 0c56744ba0..e733df738e 100644 --- a/app/test/test_event_crypto_adapter.c +++ b/app/test/test_event_crypto_adapter.c @@ -1154,21 +1154,17 @@ configure_cryptodev(void) static inline void evdev_set_conf_values(struct rte_event_dev_config *dev_conf, - struct rte_event_dev_info *info) + const struct rte_event_dev_info *info) { - memset(dev_conf, 0, sizeof(struct rte_event_dev_config)); - dev_conf->dequeue_timeout_ns = info->min_dequeue_timeout_ns; - dev_conf->nb_event_ports = NB_TEST_PORTS; - dev_conf->nb_event_queues = NB_TEST_QUEUES; - dev_conf->nb_event_queue_flows = info->max_event_queue_flows; - dev_conf->nb_event_port_dequeue_depth = - info->max_event_port_dequeue_depth; - dev_conf->nb_event_port_enqueue_depth = - info->max_event_port_enqueue_depth; - dev_conf->nb_event_port_enqueue_depth = - info->max_event_port_enqueue_depth; - dev_conf->nb_events_limit = - info->max_num_events; + *dev_conf = (struct rte_event_dev_config) { + .dequeue_timeout_ns = info->min_dequeue_timeout_ns, + .nb_event_ports = NB_TEST_PORTS, + .nb_event_queues = NB_TEST_QUEUES, + .nb_event_queue_flows = info->max_event_queue_flows, + .nb_event_port_dequeue_depth = info->max_event_port_dequeue_depth, + .nb_event_port_enqueue_depth = info->max_event_port_enqueue_depth, + .nb_events_limit = info->max_num_events, + }; } static int -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:47.096016608 +0800 +++ 0091-test-event-avoid-duplicate-initialization.patch 2024-12-06 23:26:44.103044826 +0800 @@ -1 +1 @@ -From 8c08b10d047ac64fb98709871b192698663af7d7 Mon Sep 17 00:00:00 2001 +From 30e22a764cf9edbdcb4fd394d08d720b5ad79052 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8c08b10d047ac64fb98709871b192698663af7d7 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index 9d38a66bfa..ab24e30a97 100644 +index 0c56744ba0..e733df738e 100644