From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4430D45E41 for ; Sat, 7 Dec 2024 09:10:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DA8540281; Sat, 7 Dec 2024 09:10:11 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2070.outbound.protection.outlook.com [40.107.237.70]) by mails.dpdk.org (Postfix) with ESMTP id 95C2340E50 for ; Sat, 7 Dec 2024 09:10:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UVpSeaUH78YTSU/N8r5i2fw7Wdkl0pJhdw0qeMVQ+bVRJvhNon5sFaLvuatxm8+5gw0v+jVFGZUGDTTDLQDn38Mmi6bQH7bQFhdyDDKdEfp4crjzYx9lI/+oTfNadpO41TtZFaz4uJSLpGhYIcmHsOSaLZzdKfQqgEHyRWB04TZRV+1AIcU1m7Od7CuLdRJFpimRgyZKCKCca+60AHE2pKyGHzwgpRt+vDaTJIzoZS8NSrh+BCC0sWFfPNX26wx0iWDGACPG7nut6cHnnZPWwZstuEk80hGb0CZYmX1+yDzJTKeZZacSPvq2yNK/B5ovkUeSXbWApRyAwbJ3Waw4Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYaQTZYp1MPkpFvjAphuCKVeLgapPvLb25bGcI5VOe4=; b=lOf8+WiXoHYgXzevYo+O2X2IA8M7KfMvXXzPUU2IIThuEQQ5lL0B0D2XU0BgB2jKFiQFRTpdlOzZ4ZPZqStchyThrlL+jJeNNaHd2RCPYEHPzAuflhVmZ/beflIktMPBE0hPh61+ceK3xePmMLezRybvK6X5nfX7rjKoT9Au/oupAOm2FAVENF9gDAfYuaBJZckTzFQnp5EB3paixnhhskrLaCLPvkNT7OuF2occ2eCrnOI2tEYn6Ma/5PFSZ24suG7E3yhWYsVlPqQ9ypIyBTC568s2CxDfz17c8SW62phMKJJPc7MBUDMsbmx18nJO0nqiaZZkvjf9MgmCgfLehA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYaQTZYp1MPkpFvjAphuCKVeLgapPvLb25bGcI5VOe4=; b=A0tsoAmkBIIXfsBEuENFwUvq6K7mFAFQqs3qV5YJo4LFEAKOcJIu3Nm/V49pCbywqOhnf69j6UGqVqHOF63qGGN6cdVXGamvaBJBwES87eZBSx73jBJk/0s8d6sqzHMad+PzZdc/3F3aWq2yRTWaZOPXhA48c5rJUBWeQDK8MC7pTUXit5RlPLPChJkE6IUmhg+WzTYCAileMn5csFXq2LbLsVlysb7MbfOvS2zdeOTWwEutymd40RGOk9DYU4OeyZ8A0Zahc6w4yL89skbxuu3k2+0nLHiLjqm/7miPZNJRu4Bpvu19d265cBDaKq9lIVfDnoRkG+BH7Qz3uMk5zw== Received: from MN2PR15CA0021.namprd15.prod.outlook.com (2603:10b6:208:1b4::34) by CYYPR12MB8871.namprd12.prod.outlook.com (2603:10b6:930:c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.12; Sat, 7 Dec 2024 08:10:06 +0000 Received: from BL02EPF00021F6E.namprd02.prod.outlook.com (2603:10b6:208:1b4:cafe::55) by MN2PR15CA0021.outlook.office365.com (2603:10b6:208:1b4::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8207.19 via Frontend Transport; Sat, 7 Dec 2024 08:10:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00021F6E.mail.protection.outlook.com (10.167.249.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:10:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:52 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:09:50 -0800 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , Bruce Richardson , Ajit Khaparde , Chengwen Feng , dpdk stable Subject: patch 'app/testpmd: remove redundant policy action condition' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 16:00:52 +0800 Message-ID: <20241207080055.488538-95-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6E:EE_|CYYPR12MB8871:EE_ X-MS-Office365-Filtering-Correlation-Id: 166dd282-9cb6-4c04-6c00-08dd16968ea8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Gab62vNMEzoD0r5Tj6n5uv8boOpmvLzKgf7gCmpY1RpJjBodpORsvLQbaYqN?= =?us-ascii?Q?J5nuHSMzsSzUjimhafXtUnrb00yxRVKOyBulfmUyfHdZNWU+iYj3jqj1kiSf?= =?us-ascii?Q?/u9A+u6GY9Y4oTC19C4ujbIjono1JBmBsebVHR/5QDRjvSSVPMDKW/67SxHV?= =?us-ascii?Q?e+mVOhUkEzTESV9jW0VUBTnzOk/T4gE5ZIdNnSKAqMSwUhBRUIkCArPmhkPg?= =?us-ascii?Q?3ENXCsrB45gH5OPy4ApQh5fFQqni2j/t6+YINhjGe3l89ILiTepWjHF/1qd5?= =?us-ascii?Q?nQuhF2Op2tKvwv9meGZVCD3ooxKINaUeGpgxnyV5H+n5AItkOwhshhAGrZnu?= =?us-ascii?Q?pwDmmx5lA3QNQb1GnJ/6ZC6/McwXf74sCZRr1/shPzt04qwx+BrXwXdF6SC2?= =?us-ascii?Q?SKLi16flJZzjg9JoXdMkBMsRZ2ZNbHs0HTiuzg8DT7S0tP+V/Cui8XG9Y7LF?= =?us-ascii?Q?Iq1/HnVFxh/GGjDQRl27iNOC+X7YnD6QPiuLN04OiKXvx6H9ixoTU6a0I+fN?= =?us-ascii?Q?ED8JAgMRtC2gkH8PTUBB0EIFlZ/maf9omRmy7z4n92mC11JL4fKZdwX955IU?= =?us-ascii?Q?078SwSRrZg3YlaPQOxE04xV7vf9Acx//fTbqaY0hv4h4JoWgrNLLGIxn0s37?= =?us-ascii?Q?ytcRzB1R55NROa0wqYG/R7zSG9Nim/2wpPaOE7TwVmT3zjHoaYnaYIFqj0Cj?= =?us-ascii?Q?cd0G0XB3Nj2JFMCecflq42wjvUi4T52PnNBfMQgc6+B6uYxB3mWjmX8p5k9Y?= =?us-ascii?Q?QvMSpBr3+elVpH7vgldsnRKkvAVfDj2eDA4OJmpuEj1NGF8FbY77XgyhF1D5?= =?us-ascii?Q?PSFcYRyR0S7KCyzt1msyF6ytPrkftljaRKl0rRWJJPbJ30a/IU9eNwzxWlg8?= =?us-ascii?Q?MkclspKUL7D12yA8c0kAA1OgUl8uaky6DiVFhtaYfZIwp3pNeDoSZDAY2z7L?= =?us-ascii?Q?XG06mTT+glQ2foXb24rcaZgMyFf4i9ld/drmowmZQJjDP8mIB2KD3elZV+xc?= =?us-ascii?Q?rMD6WEuGqqgKgB68QgaiOkO+RUqlxjfb7KQ4/4MYLO+0AVC6P1cSS4060J4J?= =?us-ascii?Q?VzoZiVTX2x8TnfFxRtVAK7DSaDJWwnfp9jJHhLgK6/ydAO1bSIrwlU0/OfI6?= =?us-ascii?Q?BOekwGRp9nPRjC29uH5RUxT1ThMQPc+KBAxg8yke5z2nYTViT9D1ylBnfiS/?= =?us-ascii?Q?ZuKwotZ3n2z2z4qUvbaOrPmTqcbonw1GzeSOqDMjZFKRcaSJbdGuaVgMnLZl?= =?us-ascii?Q?D0tYfCy4+E+TZhg9Un5E57gJVTBUUy1GDoRQX0AAOMK0agDvS1sfiMFCy0/M?= =?us-ascii?Q?qEP1+3Un9xOMYG1HBdcpP5Oxj9Ow3JhfuF01tJ09/cdKvusUIrtbpmy+vuuW?= =?us-ascii?Q?MU1mF3tdQmLSrXe9l72/DGx+xTwSaYaTs6YluLM7BWWs8fxUiv7EeOt7exbb?= =?us-ascii?Q?bG86PjYfZ8OIKzcQe8QocrBoocR90FZo?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:10:04.8755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 166dd282-9cb6-4c04-6c00-08dd16968ea8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8871 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=1fb0641a6dbe0f1210756dd4ba5d538c27d24132 Thanks. Xueming Li --- >From 1fb0641a6dbe0f1210756dd4ba5d538c27d24132 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:29 -0800 Subject: [PATCH] app/testpmd: remove redundant policy action condition Cc: Xueming Li [ upstream commit 4c2e7468426ae6be3f2a8f2d15e7d1222083eb9d ] The loop over policy actions will always exit when it sees the flow end action, so the next check is redundant. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Ajit Khaparde Acked-by: Chengwen Feng --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index ff2e9da324..9c3d668e56 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2219,7 +2219,7 @@ port_meter_policy_add(portid_t port_id, uint32_t policy_id, for (act_n = 0, start = act; act->type != RTE_FLOW_ACTION_TYPE_END; act++) act_n++; - if (act_n && act->type == RTE_FLOW_ACTION_TYPE_END) + if (act_n > 0) policy.actions[i] = start; else policy.actions[i] = NULL; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:47.175511108 +0800 +++ 0094-app-testpmd-remove-redundant-policy-action-condition.patch 2024-12-06 23:26:44.113044826 +0800 @@ -1 +1 @@ -From 4c2e7468426ae6be3f2a8f2d15e7d1222083eb9d Mon Sep 17 00:00:00 2001 +From 1fb0641a6dbe0f1210756dd4ba5d538c27d24132 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 4c2e7468426ae6be3f2a8f2d15e7d1222083eb9d ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -18,2 +20,2 @@ - app/test-pmd/config.c | 3 +-- - 1 file changed, 1 insertion(+), 2 deletions(-) + app/test-pmd/config.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) @@ -22 +24 @@ -index 28d45568ac..4e7fb69183 100644 +index ff2e9da324..9c3d668e56 100644 @@ -25 +27 @@ -@@ -2288,7 +2288,7 @@ port_meter_policy_add(portid_t port_id, uint32_t policy_id, +@@ -2219,7 +2219,7 @@ port_meter_policy_add(portid_t port_id, uint32_t policy_id, @@ -34,5 +35,0 @@ -@@ -7338,4 +7338,3 @@ show_mcast_macs(portid_t port_id) - printf(" %s\n", buf); - } - } --