From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D8E145E41 for ; Sat, 7 Dec 2024 09:10:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97D5D40281; Sat, 7 Dec 2024 09:10:35 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2074.outbound.protection.outlook.com [40.107.212.74]) by mails.dpdk.org (Postfix) with ESMTP id B696240281 for ; Sat, 7 Dec 2024 09:10:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nWtOBQLqSUD6Wih4mYXfWCMoskDrm1LceX7lG1utuLK1RO061Of+JKjLqzYcpjB0ns8/52ebFxwaxEWS7tFhpgHjxXfr9UbwaUhAIc72dN/uV8BCDiEoDfy/RiBtYDfds9Z+F4ffgYXtgGqe3Wa5l/097yiv7x0AnRs+MNHakhx+2k21KoR+NuWiL9FXTdx5N5gPCxtHKQaVdnbq6ye89yLNuOI4Q9H6mu89Iw7ipbzgqEY4Bsut5bdIZo7tx9dfwaV99Q0TkEYETy6gwOounAUTMHCFsByXeV45x8eDKuA3UrThGQbEZdmyVH1S8goXFNqp6V2k6lrcZPr9XzdPpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a7GUe6cohjiaRwxd5lTBtDHPxK98YFeq2c/CoaUNBMU=; b=v3MMBXumT3c5QAI1uQdvOS+4KL3abeHI4o2o4Kozdjc0Ci83FXFEwHUB2gQL3y6OxYtLpEVUDMxGh40C6JLSsKwYzerPtbixhLC/nhxdQ4ZlCxTwMMKHjSWK2moUDaOKuPAosoZQcLoKD37IUPVpMcyo27PAOjX3YISTOgGIu+S8ram8gsvY1FJmufyxVhIaVIDe+4Ckq8Jzf91X85o1BnSoEkWOnoZ2v2BJJhFBiPietmIXFVVeyCtXmOA8g9QMersEE3323fQHR2QxzXDR96DWeXAryxQajTzqZZhk+BKVjSBQkaGShinx22cp+MPmik+YLHZAhqI+JO+veK8E2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a7GUe6cohjiaRwxd5lTBtDHPxK98YFeq2c/CoaUNBMU=; b=KzPrz5kLQzbgs7j02ArEG4xrGQmgSDkmqox0kXjucop+Ebfdwrr4Eo1ERW2CZnmeq/+haU/19CiDHOS1j2UZnaq5RKgD9Gme58hFDOYGs83990A4XqqdkqS24YMyHufF4bAskPaivJAS+0MC0aNQl4ZsY1+jBMEEydUOwNSJ4mkU1VO1VmaOqW7d9vxlRwdupRpl1amdMDpaObwJKKSZhD2uv7l7K0qEV1vLXZXbbfDrCw3AbC8w4lbCiI1tItWHnNzogLYgKVOfkBqir1AX8vgMDnIqFcyNGEpN1G+eXW9P0VEKIa3Zi7qqrOgPsQyvVo+7K/iVdKbwKMjBm2+7Iw== Received: from BLAPR03CA0018.namprd03.prod.outlook.com (2603:10b6:208:32b::23) by CH3PR12MB7715.namprd12.prod.outlook.com (2603:10b6:610:151::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.12; Sat, 7 Dec 2024 08:10:31 +0000 Received: from BL02EPF00021F68.namprd02.prod.outlook.com (2603:10b6:208:32b:cafe::d7) by BLAPR03CA0018.outlook.office365.com (2603:10b6:208:32b::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Sat, 7 Dec 2024 08:10:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F68.mail.protection.outlook.com (10.167.249.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:10:30 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:10:14 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:10:12 -0800 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , Ferruh Yigit , dpdk stable Subject: patch 'doc: correct definition of stats per queue feature' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 16:00:54 +0800 Message-ID: <20241207080055.488538-97-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F68:EE_|CH3PR12MB7715:EE_ X-MS-Office365-Filtering-Correlation-Id: 77734028-c7d5-403d-b5f1-08dd16969e26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YEEQo/eQTIPPPBuRyxl5H+lsT9tii5MR9AXLQcxS99mATHOqQ/ibl3LsBJOB?= =?us-ascii?Q?yb8c7ui8WunKFJ/7O0AM8TmHc5M7bhIJW6BI0cO7wojnH+B/E9mvKutPABDI?= =?us-ascii?Q?dDHLbkq71TGOKFinImPibK9CC/6jhf2f7TIrIGnvPUuRoKVXWaIMxr25nyZi?= =?us-ascii?Q?TW/MD/aLXlBXw3BNqvJUDmaxFQcdk1bEPGca8bZoqs7Nt2+IS0beIbk4qykN?= =?us-ascii?Q?zxvwmOJ4bJZ1iyL2dsot19DCyl+ja8isNsxosFP05Fuzr/63DhZCepsGKD2B?= =?us-ascii?Q?j4XTEc05lYtj9X2XVbieUm/W/YHGr+dG90pmOEB64qKm4ZsonYs/LLePRWNV?= =?us-ascii?Q?LHD/s7ntvDpXLj9qOYuyRS+PxsdN9tiQz5WQP160jgxj3YXVkMkMmGMK1UUf?= =?us-ascii?Q?lG0zGrYfeWSfdHwM0vXlrkg+0v8iMeFfbucF0NhT35EVSE09+m22tSw4KCPW?= =?us-ascii?Q?HLbyQa9Qn0sUq5tMybya18DAdgw/UGizX2tLcFftJaCHNk1Jzw9Fx88Afr5D?= =?us-ascii?Q?Q4jsMgOcTm/kPHApqu5559sHBj6BBnYLZLAenEAUvuOSpyd/ymUOs7p2w+b+?= =?us-ascii?Q?D9THNTLjp7fclLRUizNmZGP0udW0ALFFTJUdfg65hneg8k/6AIlUc8hq90br?= =?us-ascii?Q?dSyOqMMGz1X2KFT+i+B86RKY5dx+g/jWG+f7jD5x0XFl5TJX+oO/971vHa0I?= =?us-ascii?Q?6ZYZh9B2TtBDInFO4PlKuwHR8cVxU4bOn1OKWJyzRUtrtAHoUpGEq1F1xYJT?= =?us-ascii?Q?IMvfCzEOTQYLSUBtCyQAtIiqz6LMRVaUQEZE+yQs6k+fZvXjY/Vw+ZkHqH9G?= =?us-ascii?Q?pS1WXz8oq3wE/6anG/oHrdX3I3RVPRZgIVSi1hA3OifD3/VpzlnBdh/XoQgi?= =?us-ascii?Q?W0nfGBIG8DqEDB77HrzoAS08H6BUT5PcJvzcBExTzw/IKZACZ/lPmgwz1h07?= =?us-ascii?Q?FO6r9gJ8ZeF8GNnqoaYV1k1ZnNhoxN3+5xkoXoO7Ev1JRXK96LI/ae+CwkFn?= =?us-ascii?Q?srs+PsoKbLXeTE15+brOghPEyCsZAPhNKlMmqFG+keDXVTqMDAAkXFdQp8Os?= =?us-ascii?Q?OtNYT42sUWCu5iB9CAadV+jFqm2MHg3S3oGqf6hKBaUbIZaZP5ImOVgtdY2L?= =?us-ascii?Q?OexzypG9hLbupKwbECi2TToOP46UCs0pOMK+FA+53MljfPu/rjTaj0MJprb+?= =?us-ascii?Q?CUNcfA/xZpdHh08x1l1Z718Y/z36Dfu7GdkxJOv7fCFVkIpOCTH+sRF/QwmO?= =?us-ascii?Q?ZXygosldpEjbB/Nh0gYkvjNp7Cwa998wsvib39vxQopzVDYLIqU0hamFFmfK?= =?us-ascii?Q?kd/ujc3D12zPOZ7Scxs+PfLqnPYEynrSGjRMed2KYS2hrZTs5kMcGt/DDiUP?= =?us-ascii?Q?cAUTVI0HO8xT7QTdftaBXuWDRNcuT0TAqCo2JNeTCWXUS8xp61eGJ/b07/lw?= =?us-ascii?Q?syrMmlmkzFAuUTXQlQxhBRvN0t6ojdeo?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:10:30.8689 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77734028-c7d5-403d-b5f1-08dd16969e26 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F68.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7715 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=4b216d36bd1c83e1e82ac46129de26cbb8f9ac99 Thanks. Xueming Li --- >From 4b216d36bd1c83e1e82ac46129de26cbb8f9ac99 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 10 Oct 2024 18:38:27 -0700 Subject: [PATCH] doc: correct definition of stats per queue feature Cc: Xueming Li [ upstream commit 71eae7fe3eac90b70200460c714d1c13ee43dc25 ] Change the documentation to match current usage of this feature in the NIC table. Moved this sub heading to be after basic stats because the queue stats reported now are in the same structure. Although the "Stats per Queue" feature was originally intended to be related to stats mapping, the overwhelming majority of drivers report this feature with a different meaning. Hopefully in later release the per-queue stats limitations can be fixed, but this requires and API, ABI, and lots of driver changes. Fixes: dad1ec72a377 ("doc: document NIC features") Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- doc/guides/nics/features.rst | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index cf9fabb8b8..7b48e4e991 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -716,14 +716,32 @@ Basic stats Support basic statistics such as: ipackets, opackets, ibytes, obytes, imissed, ierrors, oerrors, rx_nombuf. -And per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. - These apply to all drivers. * **[implements] eth_dev_ops**: ``stats_get``, ``stats_reset``. * **[related] API**: ``rte_eth_stats_get``, ``rte_eth_stats_reset()``. +.. _nic_features_stats_per_queue: + +Stats per queue +--------------- + +Supports per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. +Statistics only supplied for first ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` (16) queues. +If driver does not support this feature the per queue stats will be zero. + +* **[implements] eth_dev_ops**: ``stats_get``, ``stats_reset``. +* **[related] API**: ``rte_eth_stats_get``, ``rte_eth_stats_reset()``. + +May also support configuring per-queue stat counter mapping. +Used by some drivers to workaround HW limitations. + +* **[implements] eth_dev_ops**: ``queue_stats_mapping_set``. +* **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``, + ``rte_eth_dev_set_tx_queue_stats_mapping()``. + + .. _nic_features_extended_stats: Extended stats @@ -738,18 +756,6 @@ Supports Extended Statistics, changes from driver to driver. ``rte_eth_xstats_get_names_by_id()``, ``rte_eth_xstats_get_id_by_name()``. -.. _nic_features_stats_per_queue: - -Stats per queue ---------------- - -Supports configuring per-queue stat counter mapping. - -* **[implements] eth_dev_ops**: ``queue_stats_mapping_set``. -* **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``, - ``rte_eth_dev_set_tx_queue_stats_mapping()``. - - .. _nic_features_congestion_management: Congestion management -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:47.249632509 +0800 +++ 0096-doc-correct-definition-of-stats-per-queue-feature.patch 2024-12-06 23:26:44.123044826 +0800 @@ -1 +1 @@ -From 71eae7fe3eac90b70200460c714d1c13ee43dc25 Mon Sep 17 00:00:00 2001 +From 4b216d36bd1c83e1e82ac46129de26cbb8f9ac99 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 71eae7fe3eac90b70200460c714d1c13ee43dc25 ] @@ -19 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +30 @@ -index 0508f118fe..8bd448139e 100644 +index cf9fabb8b8..7b48e4e991 100644 @@ -31 +33 @@ -@@ -729,14 +729,32 @@ Basic stats +@@ -716,14 +716,32 @@ Basic stats @@ -66 +68 @@ -@@ -751,18 +769,6 @@ Supports Extended Statistics, changes from driver to driver. +@@ -738,18 +756,6 @@ Supports Extended Statistics, changes from driver to driver.