From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8280A45E5C for ; Mon, 9 Dec 2024 15:02:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 688BB4025D; Mon, 9 Dec 2024 15:02:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 096AD4025D for ; Mon, 9 Dec 2024 15:01:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733752919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=btg41k844HBt82MbaQFEVjA4wjfLo/Kt0F1akiND2IY=; b=GiV2VKX/nH/u39R3GWqIIRsiA6Yex2FEGUZVOnxxr9aUKzfCngk8dwcKPKnnx01C7RS07d /021O7AXhuVkPKvsEyOcpTz5XhbHMbmTwxTvNvL5kcSl+gStvVdl84EV0mvmJjfNvZfPfV jUsCnBK0LzUpaQgVw4NrVFC/3uF2OJ0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-1z1dwtWRNg-z1ZynASSghA-1; Mon, 09 Dec 2024 09:01:56 -0500 X-MC-Unique: 1z1dwtWRNg-z1ZynASSghA-1 X-Mimecast-MFC-AGG-ID: 1z1dwtWRNg-z1ZynASSghA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A9AB19560B5; Mon, 9 Dec 2024 14:01:54 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.129]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 10965195605A; Mon, 9 Dec 2024 14:01:51 +0000 (UTC) From: David Marchand To: stable@dpdk.org, luca.boccassi@gmail.com Cc: David Hunt , Konstantin Ananyev , Huisong Li , Sivaprasad Tummala Subject: [22.11] power: fix log message when checking lcore ID Date: Mon, 9 Dec 2024 15:01:42 +0100 Message-ID: <20241209140142.2955898-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KT2PKrXAR_eZaBeaMWswmOyMxiQff0ed_qcCMmJEUr0_1733752914 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Caught while inspecting changes backported in 22.11 LTS branch. The POWER_LOG() macro in the main branch automatically appends a \n which is not done by RTE_LOG(). Fixes: a73f3a97ff25 ("power: fix mapped lcore ID") Signed-off-by: David Marchand --- lib/power/power_acpi_cpufreq.c | 2 +- lib/power/power_common.c | 2 +- lib/power/power_cppc_cpufreq.c | 2 +- lib/power/power_pstate_cpufreq.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 8068c6d98b..0937cddba2 100644 --- a/lib/power/power_acpi_cpufreq.c +++ b/lib/power/power_acpi_cpufreq.c @@ -258,7 +258,7 @@ power_acpi_cpufreq_init(unsigned int lcore_id) } if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { - RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u", lcore_id); + RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\n", lcore_id); return -1; } diff --git a/lib/power/power_common.c b/lib/power/power_common.c index e2a8c33604..6e68a8f6d5 100644 --- a/lib/power/power_common.c +++ b/lib/power/power_common.c @@ -212,7 +212,7 @@ int power_get_lcore_mapped_cpu_id(uint32_t lcore_id, uint32_t *cpu_id) lcore_cpus = rte_lcore_cpuset(lcore_id); if (CPU_COUNT(&lcore_cpus) != 1) { RTE_LOG(ERR, POWER, - "Power library does not support lcore %u mapping to %u CPUs", + "Power library does not support lcore %u mapping to %u CPUs\n", lcore_id, CPU_COUNT(&lcore_cpus)); return -1; } diff --git a/lib/power/power_cppc_cpufreq.c b/lib/power/power_cppc_cpufreq.c index 9a77811087..83b30d366e 100644 --- a/lib/power/power_cppc_cpufreq.c +++ b/lib/power/power_cppc_cpufreq.c @@ -362,7 +362,7 @@ power_cppc_cpufreq_init(unsigned int lcore_id) } if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { - RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u", lcore_id); + RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\n", lcore_id); return -1; } diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c index baa1835fbc..5799102c2b 100644 --- a/lib/power/power_pstate_cpufreq.c +++ b/lib/power/power_pstate_cpufreq.c @@ -564,7 +564,7 @@ power_pstate_cpufreq_init(unsigned int lcore_id) } if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { - RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u", lcore_id); + RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\n", lcore_id); return -1; } -- 2.47.0