From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7908F45E85 for ; Thu, 12 Dec 2024 14:24:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C11740269; Thu, 12 Dec 2024 14:24:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 32C8B40269 for ; Thu, 12 Dec 2024 14:24:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734009853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SluNQd3Mu1VVFwmc73+H8EXBgSuPbZam9WLtvP5v8Ts=; b=hi8EuO8e/RwDxmESPTBCAl5c1pWNeMKdSpbi6iHe6AuQm1KezUqfzQXxmZj2wjUcrr/lLA A/g89T64eg0GKjorNZ7HENpcKVb2qyyPM9knI2HbxzA3PGfhTc8Z+mrQe+0GMRv6TmfoC8 HFWV/oDxsyi07rwiKjwlr+r/O04L94c= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-xwtnyPVsPPyVCaJ65UaWgA-1; Thu, 12 Dec 2024 08:24:10 -0500 X-MC-Unique: xwtnyPVsPPyVCaJ65UaWgA-1 X-Mimecast-MFC-AGG-ID: xwtnyPVsPPyVCaJ65UaWgA Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D1D31955F10; Thu, 12 Dec 2024 13:24:09 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.129]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 55AA41956086; Thu, 12 Dec 2024 13:24:08 +0000 (UTC) From: David Marchand To: stable@dpdk.org, xuemingl@nvidia.com Subject: [23.11 2/2] power: fix log message when checking lcore ID Date: Thu, 12 Dec 2024 14:23:58 +0100 Message-ID: <20241212132358.602485-2-david.marchand@redhat.com> In-Reply-To: <20241212132358.602485-1-david.marchand@redhat.com> References: <20241212132358.602485-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LXJkhdNJfCkU0lTqDRXVyTU7MgYln_DB7SpoYpp37Ic_1734009849 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Caught while inspecting changes backported in 23.11 LTS branch. The POWER_LOG() macro in the main branch automatically appends a \n which is not done by RTE_LOG(). Fixes: 1afa4c7c5ea6 ("power: fix mapped lcore ID") Signed-off-by: David Marchand --- lib/power/power_amd_pstate_cpufreq.c | 2 +- lib/power/power_common.c | 4 ++-- lib/power/power_pstate_cpufreq.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_pstate_cpufreq.c index 7b8e77003f..ff63e91183 100644 --- a/lib/power/power_amd_pstate_cpufreq.c +++ b/lib/power/power_amd_pstate_cpufreq.c @@ -377,7 +377,7 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id) } if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { - RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u", lcore_id); + RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\n", lcore_id); return -1; } diff --git a/lib/power/power_common.c b/lib/power/power_common.c index 8ffb49ef8f..ee0c264c8d 100644 --- a/lib/power/power_common.c +++ b/lib/power/power_common.c @@ -211,8 +211,8 @@ int power_get_lcore_mapped_cpu_id(uint32_t lcore_id, uint32_t *cpu_id) lcore_cpus = rte_lcore_cpuset(lcore_id); if (CPU_COUNT(&lcore_cpus) != 1) { - RTE_LOG(ERR, POWER, "Power library does not support lcore %u mapping to %u CPUs", lcore_id, - CPU_COUNT(&lcore_cpus)); + RTE_LOG(ERR, POWER, "Power library does not support lcore %u mapping to %u CPUs\n", + lcore_id, CPU_COUNT(&lcore_cpus)); return -1; } diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c index 890875bd93..fa9ef2aa8a 100644 --- a/lib/power/power_pstate_cpufreq.c +++ b/lib/power/power_pstate_cpufreq.c @@ -565,7 +565,7 @@ power_pstate_cpufreq_init(unsigned int lcore_id) } if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { - RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u", lcore_id); + RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\n", lcore_id); return -1; } -- 2.47.0