From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E8E545E8F for ; Fri, 13 Dec 2024 15:33:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10D7440B9E; Fri, 13 Dec 2024 15:33:32 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 59823409FA; Fri, 13 Dec 2024 15:33:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734100409; x=1765636409; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=fBHMZApYaZdZH0xMabka2Vjd8SXfsB5HwnRfqMSiuQo=; b=Cwy8AoAemRAxiSBjrIexAIFewCouRf5xMr4QdGX3cH+8mQiQng7S4qi+ knXygRYe9Nx0ipC99AtH2tUKy8gFtoTqAiVUUaztsYzwhVrjOFt9Iztsp 9GLOdIUG7z+W5RUpmXI5djROSDiL6N6XG1Ijy4EMHnyBT5aTz46Qye39t oIz6KLMe8RYnKvYisNcMC8CQ3EkoAMK119IwMgj1c4AEw6nkNQbY7a7y7 Aqf4aUL4gpPq++wLje14eXpv97+6PTUXBORQEHQlmRoM2OT0pXhsC3fOM sazYEe93zXiz8Bazp9NNteTMyWp0SYag+d712065gV2acVKaalS81OzTf g==; X-CSE-ConnectionGUID: 3WpPe9RiRMKbKzsoVRHerA== X-CSE-MsgGUID: ETJCIv7hSPGPEDEpoW9Dhg== X-IronPort-AV: E=McAfee;i="6700,10204,11285"; a="33880266" X-IronPort-AV: E=Sophos;i="6.12,231,1728975600"; d="scan'208";a="33880266" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2024 06:33:28 -0800 X-CSE-ConnectionGUID: 1/zXrPAaQ7SpIJuoUv1Nmw== X-CSE-MsgGUID: mBQYaCJsT0+Ha0QBgKYCPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,231,1728975600"; d="scan'208";a="96437494" Received: from silpixa00401197coob.ir.intel.com (HELO silpixa00401385.ir.intel.com) ([10.237.214.45]) by fmviesa007.fm.intel.com with ESMTP; 13 Dec 2024 06:33:26 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Vladimir Medvedkin , Ian Stokes , Qi Zhang , Wenzhuo Lu , Yiding Zhou , Zhichao Zeng Subject: [PATCH] net/iavf: remove reset of Tx prepare function ptr Date: Fri, 13 Dec 2024 14:33:19 +0000 Message-ID: <20241213143319.686365-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The iavf driver only contains a single Tx prepare function, so when selecting the Tx path, there is no need to reset and reassign the function pointer in the ethdev structure. This fixes an issue where the pointer was reset to NULL, but never assigned back later on function selection. Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") Fixes: 08eb6a9cc2e1 ("net/iavf: fix Tx L4 checksum") Fixes: 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- drivers/net/iavf/iavf_rxtx.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 6a093c6746..98a1d3f69d 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -4173,7 +4173,6 @@ iavf_set_tx_function(struct rte_eth_dev *dev) if (!use_sse && !use_avx2 && !use_avx512) goto normal; - dev->tx_pkt_prepare = NULL; if (use_sse) { PMD_DRV_LOG(DEBUG, "Using Vector Tx (port %d).", dev->data->port_id); @@ -4190,7 +4189,6 @@ iavf_set_tx_function(struct rte_eth_dev *dev) goto normal; } else { tx_burst_type = IAVF_TX_AVX2_OFFLOAD; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX2 OFFLOAD Vector Tx (port %d).", dev->data->port_id); } @@ -4203,17 +4201,14 @@ iavf_set_tx_function(struct rte_eth_dev *dev) dev->data->port_id); } else if (check_ret == IAVF_VECTOR_OFFLOAD_PATH) { tx_burst_type = IAVF_TX_AVX512_OFFLOAD; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX512 OFFLOAD Vector Tx (port %d).", dev->data->port_id); } else if (check_ret == IAVF_VECTOR_CTX_PATH) { tx_burst_type = IAVF_TX_AVX512_CTX; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX512 CONTEXT Vector Tx (port %d).", dev->data->port_id); } else { tx_burst_type = IAVF_TX_AVX512_CTX_OFFLOAD; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX512 CONTEXT OFFLOAD Vector Tx (port %d).", dev->data->port_id); } @@ -4251,7 +4246,6 @@ iavf_set_tx_function(struct rte_eth_dev *dev) PMD_DRV_LOG(DEBUG, "Using Basic Tx callback (port=%d).", dev->data->port_id); tx_burst_type = IAVF_TX_DEFAULT; - dev->tx_pkt_prepare = iavf_prep_pkts; if (no_poll_on_link_down) { adapter->tx_burst_type = tx_burst_type; -- 2.43.0