[PATCH 0/2] clear out Coverity issues 384444 & 451221

[PATCH 0/2] clear out Coverity issues 384444 & 451221

[Ariel Otilibili]

Hello,

This series clears out the Coverity issues 384444 & 451221.

Being one-liners, as advised by David Marchand, it is backported onto stable.

Thank you,

Link: https://inbox.dpdk.org/dev/CAJFAV8yEaWSX2kdiANWuKx7zsvTEnrVoVjnZAOQ_ocdzM8ZTAw@mail.gmail.com/

Ariel Otilibili (2):
  examples/flow_filtering: remove unused variable
  drivers/net/sfc: remove unused value

 drivers/net/sfc/sfc_repr.c                            | 2 --
 examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 -
 2 files changed, 3 deletions(-)

-- 
2.47.1

[PATCH 1/2] examples/flow_filtering: remove unused variable

[Ariel Otilibili]

Coverity issue: 451221
Fixes: 16158f3490 ("examples/flow_filtering: introduce use cases snippets")
Cc: Ori Kam <orika@nvidia.com>
Cc: stable@dpdk.org
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/flow_filtering/snippets/snippet_match_ipv4.c b/examples/flow_filtering/snippets/snippet_match_ipv4.c
index 808208e7b0..65fb045e8b 100644
--- a/examples/flow_filtering/snippets/snippet_match_ipv4.c
+++ b/examples/flow_filtering/snippets/snippet_match_ipv4.c
@@ -76,7 +76,6 @@ snippet_ipv4_flow_create_actions_template(uint16_t port_id, struct rte_flow_erro
 		.ingress = 1,
 	};
 
-	tactions[0].type = RTE_FLOW_ACTION_TYPE_QUEUE;
 	tactions[0].type = RTE_FLOW_ACTION_TYPE_END;
 
 	/* This sets the masks to match the actions, indicating that all fields of the actions
-- 
2.47.1

[PATCH 2/2] drivers/net/sfc: remove unused value

[Ariel Otilibili]

Coverity issue: 384444
Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: stable@dpdk.org
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 drivers/net/sfc/sfc_repr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index c2e5d4eb9e..a0712bf9fb 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -769,9 +769,7 @@ static void
 sfc_repr_close(struct sfc_repr *sr)
 {
 	SFC_ASSERT(sfc_repr_lock_is_locked(sr));
-
 	SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED);
-	sr->state = SFC_ETHDEV_CLOSING;
 
 	/* Put representor close actions here */
 
-- 
2.47.1