patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yunjian Wang <wangyunjian@huawei.com>
Cc: <dev@dpdk.org>, <maxime.coquelin@redhat.com>,
	<chenbox@nvidia.com>, <jerry.lilijun@huawei.com>,
	<xiawei40@huawei.com>, <wangzengyuan@huawei.com>,
	<stable@dpdk.org>
Subject: Re: [PATCH 1/1] vhost: fix a double fetch when dequeue offloading
Date: Thu, 19 Dec 2024 08:15:32 -0800	[thread overview]
Message-ID: <20241219081532.345c7536@hermes.local> (raw)
In-Reply-To: <91dc12662805a3867413940f856ba9454b91c579.1734588243.git.wangyunjian@huawei.com>

On Thu, 19 Dec 2024 14:38:28 +0800
Yunjian Wang <wangyunjian@huawei.com> wrote:

> -			hdr = (struct virtio_net_hdr *)((uintptr_t)buf_vec[0].buf_addr);
> +			rte_memcpy((void *)(uintptr_t)&tmp_hdr,
> +				(void *)(uintptr_t)buf_vec[0].buf_addr,
> +				sizeof(struct virtio_net_hdr));
>  		}

Do not introduce more rte_memcpy of a fixed size.
You don't need that many casts!
Why can you not use a structure assignment here.

  parent reply	other threads:[~2024-12-19 16:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19  6:38 Yunjian Wang
2024-12-19  8:24 ` David Marchand
2024-12-19 11:02   ` Wangyunjian(wangyunjian,TongTu)
2024-12-19 16:15 ` Stephen Hemminger [this message]
2024-12-20  2:17   ` Wangyunjian(wangyunjian,TongTu)
2024-12-20  4:59     ` Stephen Hemminger
2024-12-20  3:49 ` [PATCH v2 " Yunjian Wang
2024-12-20 17:10   ` Stephen Hemminger
2024-12-20 16:35 ` [PATCH " Stephen Hemminger
2024-12-23  2:45   ` Wangyunjian(wangyunjian,TongTu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241219081532.345c7536@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=wangzengyuan@huawei.com \
    --cc=xiawei40@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).