patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ariel Otilibili <otilibil@eurecom.fr>
To: dev@dpdk.org
Cc: Ariel Otilibili <otilibil@eurecom.fr>,
	stable@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH 1/1] common/sfc_efx/base: remove unreachable code
Date: Sat, 21 Dec 2024 14:27:07 +0100	[thread overview]
Message-ID: <20241221132830.1100648-2-otilibil@eurecom.fr> (raw)
In-Reply-To: <20241221132830.1100648-1-otilibil@eurecom.fr>

The default switch case ends with a goto; meaning these instructions are
never reached.

Coverity issue: 121742
Fixes: 19b64c6ac3 ("net/sfc/base: import libefx base")
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
--
Cc: stable@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
 drivers/common/sfc_efx/base/efx_mon.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_mon.c b/drivers/common/sfc_efx/base/efx_mon.c
index ee449ef5eb..5706171abd 100644
--- a/drivers/common/sfc_efx/base/efx_mon.c
+++ b/drivers/common/sfc_efx/base/efx_mon.c
@@ -80,9 +80,6 @@ efx_mon_init(
 		goto fail2;
 	}
 
-	emp->em_emop = emop;
-	return (0);
-
 fail2:
 	EFSYS_PROBE(fail2);
 
-- 
2.47.1


  reply	other threads:[~2024-12-21 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-21 13:27 [PATCH 0/1] " Ariel Otilibili
2024-12-21 13:27 ` Ariel Otilibili [this message]
2024-12-21 17:42   ` [PATCH 1/1] " Andrew Rybchenko
2024-12-21 18:20     ` Ariel Otilibili-Anieli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241221132830.1100648-2-otilibil@eurecom.fr \
    --to=otilibil@eurecom.fr \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).