patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] Fix unused memseg length for memory issue
@ 2024-12-26  8:10 Yang Ming
  0 siblings, 0 replies; only message in thread
From: Yang Ming @ 2024-12-26  8:10 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, Yang Ming, stable

Fix the issue where OS memory is mistakenly freed with rte_free
by setting the length (len) of unused memseg to 0.

When eal_legacy_hugepage_init releases the VA space for unused
memseg lists, it does not reset their length to 0. As a result,
mlx5_mem_is_rte may incorrectly identify OS memory as DPDK
memory. This can lead to mlx_free calling rte_free on OS memory,
causing an "EAL: Error: Invalid memory" log and failing to free
the OS memory.

This issue is occasional and occurs when the DPDK program’s
memory map places the heap address range between 0 and len(32G).
In such cases, malloc may return an address less than len,
causing mlx5_mem_is_rte to incorrectly treat it as DPDK memory.

Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.burakov@intel.com
Cc: stable@dpdk.org

Signed-off-by: Yang Ming <ming.1.yang@nokia-sbell.com>
---
 lib/eal/linux/eal_memory.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c
index 45879ca743..9dda60c0e1 100644
--- a/lib/eal/linux/eal_memory.c
+++ b/lib/eal/linux/eal_memory.c
@@ -1472,6 +1472,7 @@ eal_legacy_hugepage_init(void)
 		mem_sz = msl->len;
 		munmap(msl->base_va, mem_sz);
 		msl->base_va = NULL;
+		msl->len = 0;
 		msl->heap = 0;
 
 		/* destroy backing fbarray */
-- 
2.34.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-12-26  8:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-26  8:10 [PATCH] Fix unused memseg length for memory issue Yang Ming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).