From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81607460D6 for ; Tue, 21 Jan 2025 18:11:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD39C40657; Tue, 21 Jan 2025 18:11:50 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id D5C0D40430; Tue, 21 Jan 2025 18:11:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737479508; x=1769015508; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8Dw50e2JYN3N+IYpumlFD1XzVif+BX+OQhQW7NV1Tew=; b=oKxUU9GRvKNQzvf7z88qwWCN2/YUy2f33J5G7RADdLgjj7BK1/ud9ygr /Dx9dWKMzyNgFAcHydtV5NzS+I2l7t1cp9xVgXhJKy0fldgRLazzMpvlC uIolR2QlFZPHMM7GLA4JWR0cM37IfCk5kmOc1J+MUTovE5YLQsXYz34n1 CaRr8qnvGoES/a3xukfAAi2g+5W7peEbrjmwNrhY6tk53gkILNhV+rNe0 hotTEQZrUQq09HpHr40xyzdgg7lHVuM38w20sh12+bbEpQC+s/9Ssair2 KCenZS6PqBHn/Om1qHyfE3CeWGQlm/OMxXS4AeawlWHP2uGA+J2yBW8k5 g==; X-CSE-ConnectionGUID: vvTucusARoKWLikDWvsQQA== X-CSE-MsgGUID: ep3QRlpNSu2I0GI0tk5uuA== X-IronPort-AV: E=McAfee;i="6700,10204,11322"; a="38070563" X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="38070563" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2025 09:11:47 -0800 X-CSE-ConnectionGUID: wQoDGKhWS9y1ggOgtVteQg== X-CSE-MsgGUID: 0WRcBc1URhuYH5sSSHTtWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="106978635" Received: from silpixa00401197coob.ir.intel.com (HELO silpixa00401385.ir.intel.com) ([10.237.214.45]) by fmviesa008.fm.intel.com with ESMTP; 21 Jan 2025 09:11:46 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Pravin Pathak , Bruce Richardson , stable@dpdk.org Subject: [PATCH] event/dlb2: fix event weight handling in SSE code path Date: Tue, 21 Jan 2025 17:11:35 +0000 Message-ID: <20250121171135.2705818-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Commit 6e2e98d6775b ("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function to match the changes made to the AVX-512 version. Bugzilla ID: 1616 Fixes: 6e2e98d6775b ("event/dlb2: support independent enqueue") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- drivers/event/dlb2/dlb2_sse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/event/dlb2/dlb2_sse.c b/drivers/event/dlb2/dlb2_sse.c index 248d7519d5..f2e1f9fb7e 100644 --- a/drivers/event/dlb2/dlb2_sse.c +++ b/drivers/event/dlb2/dlb2_sse.c @@ -190,11 +190,11 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[3].data = ev[3].u64; /* will only be set for DLB 2.5 + */ - if (qm_port->cq_weight) { - qe[0].weight = ev[0].impl_opaque & 3; - qe[1].weight = ev[1].impl_opaque & 3; - qe[2].weight = ev[2].impl_opaque & 3; - qe[3].weight = ev[3].impl_opaque & 3; + if (qm_port->dlb2->enable_cq_weight) { + qe[0].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[0]); + qe[1].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[1]); + qe[2].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[2]); + qe[3].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[3]); } break; @@ -205,6 +205,7 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[i].cmd_byte = cmd_byte_map[qm_port->is_directed][ev[i].op]; qe[i].sched_type = sched_type[i]; + qe[i].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[i]); qe[i].data = ev[i].u64; qe[i].qid = queue_id[i]; qe[i].priority = EV_TO_DLB2_PRIO(ev[i].priority); -- 2.43.0