From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 020C8461A0 for ; Wed, 5 Feb 2025 17:25:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EA3C40672; Wed, 5 Feb 2025 17:25:11 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 0B8AE40648 for ; Wed, 5 Feb 2025 17:25:06 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2f9bac7699aso3482545a91.1 for ; Wed, 05 Feb 2025 08:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738772705; x=1739377505; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2P5RCKeZRHk7jkRn4otybzGL+FUsq+KHiovxUWGDHec=; b=ZMx4qoUtJM54K+Z9ucmdqfC4FNBiOVt8grmdQP6zhPkjGEjavNJgaokUxT89gIsRw7 1qm+XyFXbCrvy8sbm8akNcKypPFbgPfP+CQVxvekCmScxWWDRhlEvykjNIXBDB3qLI1R Mhqi6BFMzy0tGMQ7+m/GoITJJzyU6aboPoxday3Ud472ty52YmzaWByVwhl7+jqe2fgE mY6GbdNAL+FAnuPkuFk5s6G9abd+kOmdpc5r48NYWMBSl+v6vp7J+kyA7DZJ9trUGS/C PvZuyNlxxDfpDImwPKp0K5OvtbCc+NzBcZ5fjQMv775ObLet+aN25cWUBfSGy+zq73yG hA2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738772705; x=1739377505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2P5RCKeZRHk7jkRn4otybzGL+FUsq+KHiovxUWGDHec=; b=Is9DWeOVTjeV2sIn+Ho1RlSNxVpjzI5AZSyt3BT+J7yjGG7PH2AYPqFbvkrJMG6Pxi 0CY16icMxPj5K4e4zeG97AoJshV1RGkVvKGt6sw2okPgIL349mqg9sYngtgtElkV26NJ 3pe5qc4CkkHtYzpIJsrJgKv4OyH44Bc13DT4/tPCGOGNvvkRGqsgrLO9vHnOYO77HxGh ZIPZ+exjA5fHpqOis08Cfgoq09Gumloje4+wUonpnU2pjZ4kl9g5DB6BgFZu+F28tuH4 a2yCu3YFdKJtubL4vGehFhoBcI1NnpxIe83ilKzDcVdwv3WDeEIAzXWpcuAs5Cgck5LR KMTA== X-Forwarded-Encrypted: i=1; AJvYcCWVNq+9dfX//UvVyeIGG3taqc3mVnLZxfhqUAaus6BjoLWDuSSgmKyOaMeic7BrvH/F/P/lKxk=@dpdk.org X-Gm-Message-State: AOJu0YxbEBXzbvmNDe5pCTQDECGdc4tm7GsVN/akJjZg+K2Fhx6E/kQX 9qo6fM1YGxK9kPfxyb3AihVN3nSarwGjeETx8uQE2bnmAHGuoWHS3PPG3B1ZcbE= X-Gm-Gg: ASbGncvhvmcruxylr3hVysR4LEl/XwHajnCP2j2HjeWz+wPeslJa6+ZgbtpGNIbVCXX Lt71G5WMNiO7/W9G9/4uIah1pAU0JvgTV9qQtdWmejBDeZbveq8r82kvzv98F84/ZQV5lEbhGJR H+o1rm1AeL9c3vO0jbvRKVU678htFjCg0XMrBa8LF6AY7Xv8rJExEbWWOQdJoaCL4TC5r56p9jz 4LWOvt1eZ9qFxbPb6HIRWTg2QX0XK7la6vF0dnkMjNpWtpjGY6J1YgU5dEz4HaSZfVSXDBhi4y6 8QQeIpZ8sQFnHMzHvHyDFkO9KeY3FCGszEnvfRRCfHKuexGxa5xcExS0eWZxWzp5iOsG X-Google-Smtp-Source: AGHT+IHUBfVgojk05hKsnLKT9TKXICYPb7zP76ukH1Y+FZ7XjR4JKxKyM4/5QSBAw7mFsFMfCttTQw== X-Received: by 2002:a17:90b:2ec8:b0:2ee:dd79:e046 with SMTP id 98e67ed59e1d1-2f9e076c07bmr5047954a91.13.1738772705095; Wed, 05 Feb 2025 08:25:05 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f9c314b64fsm2138965a91.1.2025.02.05.08.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 08:25:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , xuemingl@nvidia.com, stable@dpdk.org, Tyler Retzlaff , Gaetan Rivet Subject: [PATCH v3 06/19] eal: fix out of bounds access in devargs Date: Wed, 5 Feb 2025 08:23:07 -0800 Message-ID: <20250205162448.161161-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250205162448.161161-1-stephen@networkplumber.org> References: <20241115060738.313190-1-stephen@networkplumber.org> <20250205162448.161161-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The code for parsing layers in devargs could reference past the end of layers[] array on stack. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 9a1a9e4a2ddd ("devargs: support path value with global device syntax") Cc: xuemingl@nvidia.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index a64805b268..dd857fc839 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -88,7 +88,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, s = devargs->data; while (s != NULL) { - if (nblayer > RTE_DIM(layers)) { + if (nblayer >= RTE_DIM(layers)) { ret = -E2BIG; goto get_out; } -- 2.47.2