From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08A83461A0 for ; Wed, 5 Feb 2025 18:20:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 706F640665; Wed, 5 Feb 2025 18:20:14 +0100 (CET) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id E7A7C40651 for ; Wed, 5 Feb 2025 18:20:12 +0100 (CET) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-724f4d99bc7so17339a34.1 for ; Wed, 05 Feb 2025 09:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776012; x=1739380812; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UWuAYBaKgdX+Un9qXrfMRRvrRrfbiYfltFAhwI4YYjU=; b=EGQnrqfW1S+ej/YpRY0CgwSlKhCMTcb5FQPq7JZn49rgmBzFqYedEfdRQ44e8nXwHA kN5wgvybVYrIA78NDdEo/NW85bG2otlvWagCeP6HTgfh0ENPVKFGMZMHU5ivl/9Zwklr LQntXZY1KaKWzf39Xacn095oZMim/3ZyDNwzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776012; x=1739380812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UWuAYBaKgdX+Un9qXrfMRRvrRrfbiYfltFAhwI4YYjU=; b=NTecgKfFjCP0T5LrFNDlJAwuQLOUwSlNHe4DtMxjDRDhCr23LB9++fZZBXN/wS8ToQ jJJn+H8xieYfahGDhmn60r92WCk/G5itP723Sba1IOhUl6UNUdPMU1VAC7JT2ClkEPlK HvO4uju6uaXzd1z9ASIMWbKu0QM3DUuEjb4gAj+rtvVPIGWLTD6076XCJ9ZP0o5VJ74i G5odIs931yxcq0OIl+kiPcPITRqAPqlTJlT/Sy/3XC3muer3oydHb4INYpJ6fxJr15y1 jysXBB2qN68OhDdpGM9MNmLKQbILTgbxVxmcyTtaEShiDaUkY90KbrbNLww0JH226RGU ebrQ== X-Forwarded-Encrypted: i=1; AJvYcCXxx0a2G2hFq1BnLHWMN/lXxcUOLeE+CbjS+eKTwtYpUMbxYTquEJNuWdbm5MI6wWEutqG/hAg=@dpdk.org X-Gm-Message-State: AOJu0YyfQ/jSarouu6jDDxu3feipgik1ocKNCRcP/zhogEfjul0xlYb2 gFRPdliuP3NyaaQbdIdocH1++522G0hjkrFmJyaG0ojFBWzIbPIoXwGi8w0tuPzI1TxjGE43SYU = X-Gm-Gg: ASbGnctQbRgAkCu6/yNwPtdq4HauHxfhyzNj/XiX2HuDTdtXUCgh1kod6jdRrupp+Se HGb5C6mAHVSkOXKr2nv7n5t5JYuglDDFSHisXsEzWMWE3li4gSsno2d41bvNjqNii0ks8O/lNj4 lH1kTx9gNkOGrHeR95KKbvYj6PO4wzYn25Iv6sXJ9y+BcVTVALfteUEvq+owNm676BZCUF1uMK+ FhGDTwR+P/W8rluOF7hxOVRpQGZ29olUlicJeCYAskAMo/1DJXjibJ7bftTIA58LVJmVyoHtiIX i5qwj3VuQWi7xuucu4qfstvW2Uc5HDpItH53apM/KoZJTJ7XykVu2JABSJVHz4rPpPMBnnNx9+J dBrlmtIX9 X-Google-Smtp-Source: AGHT+IG77WQaBQZ8y0P6leCDQoBeW9cQFuJeID2hfjfB+XnLIkGxwlL/IGev08fVgNa3V+ybkQBhZw== X-Received: by 2002:a05:6830:4487:b0:71e:f1:3e1 with SMTP id 46e09a7af769-726a4145e06mr2659586a34.3.1738776012198; Wed, 05 Feb 2025 09:20:12 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:11 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, stable@dpdk.org Subject: [PATCH 03/11] net/bnxt: fix Rx handler Date: Wed, 5 Feb 2025 09:19:56 -0800 Message-Id: <20250205172004.50395-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Fix the code accounting the status of compressed CQE handler. The code was inside the block handling the normal CQE mode. Moved the code out. Without this the Rx datapath was broken for compressed CQEs in scalar mode. Fixes: 5c980062d895 ("net/bnxt: support compressed Rx CQE") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 5b43bcbea6..b53d9a917a 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -1390,14 +1390,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, } else if ((CMP_TYPE(rxcmp) >= CMPL_BASE_TYPE_RX_TPA_START_V2) && (CMP_TYPE(rxcmp) <= CMPL_BASE_TYPE_RX_TPA_START_V3)) { rc = bnxt_rx_pkt(&rx_pkts[nb_rx_pkts], rxq, &raw_cons); - if (!rc) - nb_rx_pkts++; - else if (rc == -EBUSY) /* partial completion */ - break; - else if (rc == -ENODEV) /* completion for representor */ - nb_rep_rx_pkts++; - else if (rc == -ENOMEM) - nb_rx_pkts++; } else if (!BNXT_NUM_ASYNC_CPR(rxq->bp)) { evt = bnxt_event_hwrm_resp_handler(rxq->bp, @@ -1407,6 +1399,14 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, goto done; } + if (!rc) + nb_rx_pkts++; + else if (rc == -EBUSY) /* partial completion */ + break; + else if (rc == -ENODEV) /* completion for representor */ + nb_rep_rx_pkts++; + else if (rc == -ENOMEM) + nb_rx_pkts++; raw_cons = NEXT_RAW_CMP(raw_cons); /* * The HW reposting may fall behind if mbuf allocation has -- 2.39.5 (Apple Git-154)