From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B41E9461C0 for ; Sat, 8 Feb 2025 01:21:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75FFA40270; Sat, 8 Feb 2025 01:21:29 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 9784F40270 for ; Sat, 8 Feb 2025 01:21:27 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21670dce0a7so62916735ad.1 for ; Fri, 07 Feb 2025 16:21:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738974086; x=1739578886; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9gfcKWJRl6EcJd6OfVeypd/BvyC1gS6+trm1hs7KIyI=; b=ZQT98XOPjeDyHhsFAD6TnquZEN3Ze7fsDPn4yxxCPPfDTtw7iVh8MP8YTJgaa3szSZ mIRvq/sB9AcS5HQN6E7m8/WKTjQBDpHizyXKtvrLVaX8QvD2a5v6QUFkgzTXS4XL4O5v KycU4M1RCAvZoj9LuN3A0DmOuMXcdcjkxgAnq8Tdg2T68osO/BtWGTbUvJj7a3YDo2SD bbCEmrFD7sLwwwTd/06lXXP/En7PLKdT+QvJegpYZNwXV3ZBTnsSEexdZ6XyxFs8xMtb u8TpNm5/kjcMPBEbL1SbEEt5Z2ovovzv31EtLaHGMD1VZaoU0+VpGIhkI2YJgEXH+zcQ 6E5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738974086; x=1739578886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gfcKWJRl6EcJd6OfVeypd/BvyC1gS6+trm1hs7KIyI=; b=Tf4GhAwCQ42OqLwPY5fAqVo2VwlSg6flclr4SqSGVk4tCWPI4vhR3AHccDWIYxGp+Q qa7x/IU6Utki5vGAGDB7WzmVMeR6g3YoMJsJNNL/TqgFW4WuiTIIHUMhSfxkk0DdpV3w ceI8t4SqLdLb9bm/oqfFJmaNtOFWYHxmRkwXspZMw/LPQDvVhOHxswInph8+DUGpJruj fbOyRA+FG0FEY39KOmElHUmfkjdtn9XLJwalSfMyb0jXGLiYkmNqY0XOHAhnxHF26P7R 6WgQYqr64xIonjeG7DVBAbnBuKpqRA4VT6IDMcKNU4fTFY6JIKuMFRR/ZhoXuBUNK0yd vEfA== X-Forwarded-Encrypted: i=1; AJvYcCWwW4nK7B9AP6nq35M334Ai/b/4Gs4fUx/5J8SOWrwZJ6gVo5hQl0VAed+CiTb3Rhu3wF8kf+8=@dpdk.org X-Gm-Message-State: AOJu0Yyrh/v8IEQ6rCEjOoPMeHCs5wUTD5p7oqOeApMLMkFvAp2fVIqP qXlzwl45eTIH0B4bvrghmJ4Pwna1un4Nb47eK1i3X84TFW/cuXDyhx4VpGzKxR8= X-Gm-Gg: ASbGncvNQfQY9Bx6OWzAEx4rfI9W7lPtRnXTv87tC9voWxo0Q6xlmv7Q0VydiLWYk2t beBYiR6RMidbhGhCzzoAjLZ4ANxwRYlJp4IRlYhy4FH9wqZV6HOQ1BFW05tQ7ByPsMU8kgoFhQq 9W4S4habAVWUuvrAC+IVTXK7qq4Pt030JpeGCEW5yhrqK5TezGhMLzm9LV0+Bw6SurpNmJfy2zu wR4UIayC5MmtdGT7Qk0Kx3kVbtH6lE4H3vlpHGCX9YvoVd/8IJRsQKnzfwYAnkcRqw6JigV2Tmz sM9AzUQphj0VXiKHtnqtHMvSVFEoioeXQHrG/FHKNzN33Wvcazjdxm2XLHZxPSG/SHwM X-Google-Smtp-Source: AGHT+IFnRvsuOimGvDtczkkXjTJKj8piouCg9x7nYEXp17G4cB4+wBsEjx8bKIg1YcKFjdnZeNj/mA== X-Received: by 2002:a17:902:d50f:b0:21f:78f:c178 with SMTP id d9443c01a7336-21f4e6cea22mr86052955ad.3.1738974086621; Fri, 07 Feb 2025 16:21:26 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3656125esm36620485ad.95.2025.02.07.16.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2025 16:21:26 -0800 (PST) Date: Fri, 7 Feb 2025 16:21:24 -0800 From: Stephen Hemminger To: longli@linuxonhyperv.com Cc: Ferruh Yigit , Andrew Rybchenko , Wei Hu , dev@dpdk.org, Long Li , stable@dpdk.org Subject: Re: [PATCH] net/mana: use mana_local_data for tracking usage data for primary process Message-ID: <20250207162124.112f0c00@hermes.local> In-Reply-To: <1738970505-7864-1-git-send-email-longli@linuxonhyperv.com> References: <1738970505-7864-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 7 Feb 2025 15:21:45 -0800 longli@linuxonhyperv.com wrote: > + /* At least one eth_dev is probed, init shared data */ > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > + rte_spinlock_lock(&mana_shared_data_lock); > + mana_local_data.primary_cnt++; > + rte_spinlock_unlock(&mana_shared_data_lock); > + } else { > + rte_spinlock_lock(&mana_shared_data_lock); > + mana_local_data.secondary_cnt++; > + rte_spinlock_unlock(&mana_shared_data_lock); > + > + rte_spinlock_lock(&mana_shared_data->lock); > + mana_shared_data->secondary_cnt++; > + rte_spinlock_unlock(&mana_shared_data->lock); If all you are doing is wanting a MP safe counter, use atomic operations instead of the overhead of a spin lock.