From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A385F461FC for ; Wed, 12 Feb 2025 01:39:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9605640652; Wed, 12 Feb 2025 01:39:19 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 706CC402BB for ; Wed, 12 Feb 2025 01:39:17 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21f48ab13d5so104442985ad.0 for ; Tue, 11 Feb 2025 16:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739320756; x=1739925556; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=k5tPzGE2HWYCbyiS2V+d0yyuICrl4X6mb8/8hGL11/U=; b=N3AzouCnF2e8NwB4mcxQXD7ZqJBAQvHoiFjqzifdctiIheE9sZUcASwoP/ThGIXA+t 4gyYpOuUNfNtkt2oG2uc60yKiXyWNI6DEFL5XQm3bv85HR5yD6QMyb+kw7IAtIZL8Tta NeHhdkWLAAh5mWSFaPA0GoESW3I0emht0vnqYi1Sg5KDx4kPjNoYa8ObvyR/z7fy3J3W uZ7APcEGc5GCtEHF6smUIgMa7hONnR2lwylTH1lxGhNsL3SSzq+cizLdSJHPxhlEVz4T 84tTbyBVydp6K688cji2ffwj5U+eOX+iOjPvjP/5KrZh4XNZ5A8IGgBKY3zywlXacizP suCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739320756; x=1739925556; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k5tPzGE2HWYCbyiS2V+d0yyuICrl4X6mb8/8hGL11/U=; b=nAOvajtrvLRbA9XamzrzwXrfWPuQxbJqmAprMabTLM6TV5Izoa9xdI+++8ALz8VRmq ydkWGjBJ/G82yKRF2nGO0KgqsaykIKuC2ZtAKpyhNPRq7gB/l38WoCdyiLuVOaxt1Q00 9gOBQTV9Ink4UeidNo/GecJQNAx3VMomxNRdpqKqo/aKPalwfKyfNSpe7y6y7tjApYpD 1jz0kKE2CtJ2p4BK3yMdidDOax0kU8DXVilE5v/UB7BE0uRx5NcvAoVVHp4MYY2D0ZAL ckPS4tVkCztwiO9Z2HtncMPfNNcmt5dakEDi0n47hmXJUUUkzIhm08X/xeFC1tK+C7P9 Yl2A== X-Forwarded-Encrypted: i=1; AJvYcCVTOymvc9SbA8ArRq8pCXdMlcfSXiJgOWAp/qMPb70rmh7defQLO5hIww6WNO2mUKNErwBotOU=@dpdk.org X-Gm-Message-State: AOJu0YzrWXOPjYdGrF03z9xDTzR01BmFahz5wR5GUb4DkEiK98U8DaJ6 Bt0b1yxMrZ+vWjnFCu/scJgiUnAELgntjGBot4Xigu+k3cDVvHNAZLCJDBiisiQ= X-Gm-Gg: ASbGncu64HyBEU3He7oO9vPwDg6rciPJWnPVEdBrORQ5mav8XHtE5nX6nJOMBMdfXHS BM4DolqFjdOSLH2TI6Di7s7V5WcM80pTt+39aFw+sbLedXhRgs88eqHNnuo8k5m/5n4LAcTW3H2 yjs6m0257QLlFuwbt9lpb2/jOcKDvIoJbwFDjRInndwdzLkbT7g8P64Vk2cCKEJ87wn/B93KBqq yfgYbi0XHbb3vjPYeM/clO7G5bhh/wnhaU2l76qXKaH0jesx+/J3a/MavednEd+TMESYctGAT4t uPPEot6doCC8WMCiIna5GRIGLYajrw1+KtsXA/JUz3nSbXpzrsXk+xe/30x1jOYD+CH5 X-Google-Smtp-Source: AGHT+IEj7wEu6IGzYolM/th4bGZdnMHijTJSWgUlHjbymhWPmgz3mqL3DLywIvStwrN/QDAwaCcV0A== X-Received: by 2002:a17:903:32cb:b0:21c:17b2:d345 with SMTP id d9443c01a7336-220bbb11376mr18385805ad.3.1739320756465; Tue, 11 Feb 2025 16:39:16 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fbf5b93282sm86500a91.1.2025.02.11.16.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 16:39:16 -0800 (PST) Date: Tue, 11 Feb 2025 16:39:13 -0800 From: Stephen Hemminger To: Shani Peretz Cc: , , Chenbo Xia , Nipun Gupta , Gaetan Rivet Subject: Re: [PATCH v6 1/4] bus/pci: fix registration of PCI device Message-ID: <20250211163913.281f9cc6@hermes.local> In-Reply-To: <20250206105428.237346-1-shperetz@nvidia.com> References: <20250206000838.23428-5-shperetz@nvidia.com> <20250206105428.237346-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 6 Feb 2025 12:54:24 +0200 Shani Peretz wrote: > When registering a new PCI device, the device->name field stored > the user-provided string from devargs (e.g., "08:00.0" or "0000:08:00.0"). > This approach led to inconsistencies when registering new devices. > > This patch fix this issue by saving the parsed PCI in device->name, > so when a new PCI device is registering the name displayed in the device > list will be the parsed version. > > Fixes: 23eaa9059ec2 ("bus/pci: use given name as generic name") > > Cc: stable@dpdk.org > Signed-off-by: Shani Peretz This part looks good, second part needs work. Acked-by: Stephen Hemminger