From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6EF346211 for ; Thu, 13 Feb 2025 11:03:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2D5942F73; Thu, 13 Feb 2025 11:03:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 50BF642F51 for ; Thu, 13 Feb 2025 11:03:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739441032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i4o+yxyrEesPQVArvEupO2+mZIENkWInSgaH0rppVn0=; b=OLdMr+AA/jruhodvx8BaryCG+3GGkYbY+aVZn5Q8mGbOMQFhHn2LnjG7puhnp/WXt6GOB0 58cd7+xgj3JgfHynROUgEWaI8+ealhW6Hr6pWH9QvNpYFzIvc9iCGskFlrQZHvknLXIDfc 8ckdmPkuerejJnedbpzQCAy1T0FZ/CA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-cZoW21keOAa4pTjcQArrFw-1; Thu, 13 Feb 2025 05:03:49 -0500 X-MC-Unique: cZoW21keOAa4pTjcQArrFw-1 X-Mimecast-MFC-AGG-ID: cZoW21keOAa4pTjcQArrFw Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE35C18EB2D3; Thu, 13 Feb 2025 10:03:47 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7E9E91800570; Thu, 13 Feb 2025 10:03:46 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Subject: patch 'net/cpfl: fix representor parsing log' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:59:12 +0000 Message-ID: <20250213095933.362078-105-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QGj4C7G7-1iSEwxEDr3uEsLV8UI2jMAEoJJPi8StzIQ_1739441027 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/272df7dc62b967bc5cc552bc340443069f4e7c41 Thanks. Kevin --- >From 272df7dc62b967bc5cc552bc340443069f4e7c41 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 5 Feb 2025 08:23:03 -0800 Subject: [PATCH] net/cpfl: fix representor parsing log [ upstream commit 7501478b95fc79b178fc525246482215a6018651 ] The log message would always refer to str variable which is NULL here. Looks like author intended to print original parameter. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 65899b9e6538 ("net/cpfl: parse representor devargs") Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 6f6707a0bd..1817221652 100644 --- a/drivers/net/cpfl/cpfl_ethdev.c +++ b/drivers/net/cpfl/cpfl_ethdev.c @@ -1581,5 +1581,5 @@ parse_repr(const char *key __rte_unused, const char *value, void *args) done: if (str == NULL) { - PMD_DRV_LOG(ERR, "wrong representor format: %s", str); + PMD_DRV_LOG(ERR, "wrong representor format: %s", value); return -1; } -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:45.630558831 +0000 +++ 0105-net-cpfl-fix-representor-parsing-log.patch 2025-02-12 17:29:34.616947517 +0000 @@ -1 +1 @@ -From 7501478b95fc79b178fc525246482215a6018651 Mon Sep 17 00:00:00 2001 +From 272df7dc62b967bc5cc552bc340443069f4e7c41 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7501478b95fc79b178fc525246482215a6018651 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/cpfl/cpfl_ethdev.c | 2 +- + drivers/net/cpfl/cpfl_ethdev.c | 2 +- @@ -19 +20 @@ -diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c b/drivers/net/intel/cpfl/cpfl_ethdev.c +diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c @@ -21,2 +22,2 @@ ---- a/drivers/net/intel/cpfl/cpfl_ethdev.c -+++ b/drivers/net/intel/cpfl/cpfl_ethdev.c +--- a/drivers/net/cpfl/cpfl_ethdev.c ++++ b/drivers/net/cpfl/cpfl_ethdev.c