From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0565546211 for ; Thu, 13 Feb 2025 11:03:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1B9942F77; Thu, 13 Feb 2025 11:03:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 89E7442F35 for ; Thu, 13 Feb 2025 11:03:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739441034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sppHV7ktuCyyYGraaaJxpu4As19gOyPQF+Nor6YUq8s=; b=hwQ3D2km5VXYW9lKX9XDACJVx21+m91FoliSpDiiyCo3WmQbIP457uN+Iwj1Pm2UN8aTgJ Njcoq3oXyJFlDrXR0FQgcKRlcs7hfer0qOmLZ/An/11ilO7IeSLCkvu5r6jBs9z7J44JKC qV96mOyLkI+i2reFHuzhlJ9M2cdg/ug= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-_zl8cPTjNBqQRHAibE9agg-1; Thu, 13 Feb 2025 05:03:52 -0500 X-MC-Unique: _zl8cPTjNBqQRHAibE9agg-1 X-Mimecast-MFC-AGG-ID: _zl8cPTjNBqQRHAibE9agg_1739441031 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 772AE1801A0D; Thu, 13 Feb 2025 10:03:51 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 209C11800359; Thu, 13 Feb 2025 10:03:49 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Subject: patch 'eal: fix devargs layers parsing out of bounds' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:59:14 +0000 Message-ID: <20250213095933.362078-107-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: v3Du30npK0Sn1zy5BTuUIr-E3yPeHKaYuQUhCQHwUf8_1739441031 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5550f484d4bea1e6ab69e6c82be991c5ee64f4d7 Thanks. Kevin --- >From 5550f484d4bea1e6ab69e6c82be991c5ee64f4d7 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 5 Feb 2025 08:23:07 -0800 Subject: [PATCH] eal: fix devargs layers parsing out of bounds [ upstream commit 42f91490ebc97a816ea11ce9c995f455c169a77a ] The code for parsing layers in devargs could reference past the end of layers[] array on stack. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 9a1a9e4a2ddd ("devargs: support path value with global device syntax") Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index a64805b268..dd857fc839 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -89,5 +89,5 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, while (s != NULL) { - if (nblayer > RTE_DIM(layers)) { + if (nblayer >= RTE_DIM(layers)) { ret = -E2BIG; goto get_out; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:45.822921830 +0000 +++ 0107-eal-fix-devargs-layers-parsing-out-of-bounds.patch 2025-02-12 17:29:34.618947529 +0000 @@ -1 +1 @@ -From 42f91490ebc97a816ea11ce9c995f455c169a77a Mon Sep 17 00:00:00 2001 +From 5550f484d4bea1e6ab69e6c82be991c5ee64f4d7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 42f91490ebc97a816ea11ce9c995f455c169a77a ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org