From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 294FA46211 for ; Thu, 13 Feb 2025 11:03:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24ECC42F45; Thu, 13 Feb 2025 11:03:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1EA8042F7A for ; Thu, 13 Feb 2025 11:03:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739441035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3PyEUQ5iwiJxkeEN9P+dwYOxnH8Mub+nIhY3FLfNCpA=; b=ilNeAQi5BJfzC/CducaqOYqZEABTlRmPE7JIpoedWKOVxPN7oLlINaXiOm8tft8pPbKaKR inzPTGoPGfRa1dOX5YtED2Njvt8mPtFK37RzZHFUL5+XStnwZrNnFNL8qt6WKBkU5qb+yt FrVQ1lb9x8S65Q0i678yj5GVaED8+ns= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-YkkbOmAnMg64IWpnfNP1QA-1; Thu, 13 Feb 2025 05:03:54 -0500 X-MC-Unique: YkkbOmAnMg64IWpnfNP1QA-1 X-Mimecast-MFC-AGG-ID: YkkbOmAnMg64IWpnfNP1QA Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A3641800374; Thu, 13 Feb 2025 10:03:53 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 08EB41800365; Thu, 13 Feb 2025 10:03:51 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Subject: patch 'net/qede: fix debug messages array' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:59:15 +0000 Message-ID: <20250213095933.362078-108-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oYGFwYlHeKrRQB3Pv4bYLlkPFBpV7mubDqoucEU641A_1739441033 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ce8ae4502c61d15f14cbeb2a95f41ff482b8928b Thanks. Kevin --- >From ce8ae4502c61d15f14cbeb2a95f41ff482b8928b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 5 Feb 2025 08:23:08 -0800 Subject: [PATCH] net/qede: fix debug messages array [ upstream commit 60c68da0392e31ea4c163e0be8f1236a00cd350c ] The array of debug status strings did not match possible enum values. Add the missing element and a static assert to make sure the table has all possible values. For more complete description see. Link: https://pvs-studio.com/en/blog/posts/cpp/1176/ Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection") Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_debug.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c index 18f2d988fb..1d3147b724 100644 --- a/drivers/net/qede/qede_debug.c +++ b/drivers/net/qede/qede_debug.c @@ -5,4 +5,5 @@ */ +#include #include #include "base/bcm_osal.h" @@ -83,4 +84,5 @@ static const char * const s_mem_group_names[] = { "TASK_CFC_MEM", }; +static_assert(RTE_DIM(s_mem_group_names) == MEM_GROUPS_NUM, "memory group string mismatch"); /* Idle check conditions */ @@ -5615,4 +5617,6 @@ static const char * const s_status_str[] = { "The filter/trigger constraint dword offsets are not enabled for recording", + /* DBG_STATUS_NO_MATCHING_FRAMING_MODE */ + "No matching frame mode", /* DBG_STATUS_VFC_READ_ERROR */ @@ -5760,4 +5764,5 @@ static const char * const s_status_str[] = { "When triggering on Storm data, the Storm to trigger on must be specified" }; +static_assert(RTE_DIM(s_status_str) == MAX_DBG_STATUS, "status string table mismatch"); /* Idle check severity names array */ -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:45.925334407 +0000 +++ 0108-net-qede-fix-debug-messages-array.patch 2025-02-12 17:29:34.628947588 +0000 @@ -1 +1 @@ -From 60c68da0392e31ea4c163e0be8f1236a00cd350c Mon Sep 17 00:00:00 2001 +From ce8ae4502c61d15f14cbeb2a95f41ff482b8928b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 60c68da0392e31ea4c163e0be8f1236a00cd350c ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org