From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7E1946211 for ; Thu, 13 Feb 2025 11:04:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0A5A42F6D; Thu, 13 Feb 2025 11:04:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F1DAF42F8D for ; Thu, 13 Feb 2025 11:04:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739441057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s21GWi4OgB6XSUneZpfaZp8MBYP/vcZyNNhSSz1Es3k=; b=EguhuxkRL/nzYsL5StUFB/mkcMu/MjlLIApTmxxI+NCdUSmmP2NhDAGbF2SNaTVqQPl9wt OCg2VZUHJXOn77cnCVCyIWyE7/4wjOFOeLWT0a8Zo9dI/hQ2UgVc6jbYa2jej6zjYyirdH 93MEXYN2Nr3TleJHzUIYbl6zBY0bAQA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-wuzrMnd3MYOw9WmUDSJqRw-1; Thu, 13 Feb 2025 05:04:15 -0500 X-MC-Unique: wuzrMnd3MYOw9WmUDSJqRw-1 X-Mimecast-MFC-AGG-ID: wuzrMnd3MYOw9WmUDSJqRw_1739441055 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD0B31800877; Thu, 13 Feb 2025 10:04:14 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B95D01800365; Thu, 13 Feb 2025 10:04:13 +0000 (UTC) From: Kevin Traynor To: Ariel Otilibili Cc: dpdk stable Subject: patch 'eal/linux: remove useless assignments' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:59:26 +0000 Message-ID: <20250213095933.362078-119-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lG2zH9UkrEq5J013DumGdq86llh_XtOmFEdILpX6iAc_1739441055 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/627dd0d91a8ea518ebd49a16259eda9d14e2d091 Thanks. Kevin --- >From 627dd0d91a8ea518ebd49a16259eda9d14e2d091 Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Mon, 13 Jan 2025 18:19:20 +0100 Subject: [PATCH] eal/linux: remove useless assignments [ upstream commit 36128ec5d93591700b72f3fc01bfe6216eaee905 ] Found by static analysis: In dev_uev_socket_fd_create(), fd is assigned before a return, and not used. The same for the variables buf and i in dev_uev_parse(). Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Signed-off-by: Ariel Otilibili --- lib/eal/linux/eal_dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index e63f24d108..be97f56424 100644 --- a/lib/eal/linux/eal_dev.c +++ b/lib/eal/linux/eal_dev.c @@ -130,5 +130,4 @@ dev_uev_socket_fd_create(void) err: close(fd); - fd = -1; return ret; } @@ -166,6 +165,4 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) */ if (!strncmp(buf, "libudev", 7)) { - buf += 7; - i += 7; return -1; } -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:47.064526492 +0000 +++ 0119-eal-linux-remove-useless-assignments.patch 2025-02-12 17:29:34.661947785 +0000 @@ -1 +1 @@ -From 36128ec5d93591700b72f3fc01bfe6216eaee905 Mon Sep 17 00:00:00 2001 +From 627dd0d91a8ea518ebd49a16259eda9d14e2d091 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 36128ec5d93591700b72f3fc01bfe6216eaee905 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org