From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31BC846211 for ; Thu, 13 Feb 2025 11:04:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A09A42F61; Thu, 13 Feb 2025 11:04:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A8D7942F6D for ; Thu, 13 Feb 2025 11:04:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739441062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DeXy2GTLL/PdV46e9gxO8a8PKFbURTvNX/ZbN87Wg60=; b=G7UopMeJ0NciybGXyV0Itd784llNfQHUknhcHxJr69ZPyOP4AxaQyl1Zpd+0hsg6KX8CL8 lImn5GXl+yGk6BSuVZlTzEtmHT6eQ3vRmQGWPQ3B21d7Se2mZM6dq2nczuO8TIgqm1PyRJ L4rQ5E5qnoT7weU+OfnGzc2Jt+D2IAo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-198_68EAMPaJ-KwCzsGQpg-1; Thu, 13 Feb 2025 05:04:18 -0500 X-MC-Unique: 198_68EAMPaJ-KwCzsGQpg-1 X-Mimecast-MFC-AGG-ID: 198_68EAMPaJ-KwCzsGQpg_1739441057 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5FED819373DC; Thu, 13 Feb 2025 10:04:17 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 857141800359; Thu, 13 Feb 2025 10:04:15 +0000 (UTC) From: Kevin Traynor To: Ariel Otilibili Cc: Chengwen Feng , Konstantin Ananyev , dpdk stable Subject: patch 'mempool: fix errno in empty create' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:59:27 +0000 Message-ID: <20250213095933.362078-120-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CRsZiOfEfwWOS7PmcIz95ND3zpWoem-0i3RN1JYoPj4_1739441057 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5382502b316065bbb1abe1fdfbd97cc77bf0125f Thanks. Kevin --- >From 5382502b316065bbb1abe1fdfbd97cc77bf0125f Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Mon, 20 Jan 2025 13:21:55 +0100 Subject: [PATCH] mempool: fix errno in empty create [ upstream commit a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 ] When returning from rte_mempool_set_ops_byname(), rte_errno is not set for error exits. The API requires rte_errno to be set in that case. Bugzilla ID: 1559 Fixes: c2c6b2f41305 ("mempool: fix default ops for an empty mempool") Signed-off-by: Ariel Otilibili Acked-by: Chengwen Feng Acked-by: Konstantin Ananyev --- lib/mempool/rte_mempool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index d8e39e5c20..1e4f24783c 100644 --- a/lib/mempool/rte_mempool.c +++ b/lib/mempool/rte_mempool.c @@ -929,6 +929,8 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size, ret = rte_mempool_set_ops_byname(mp, "ring_mp_mc", NULL); - if (ret) + if (ret) { + rte_errno = -ret; goto exit_unlock; + } /* -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:47.162088341 +0000 +++ 0120-mempool-fix-errno-in-empty-create.patch 2025-02-12 17:29:34.663947797 +0000 @@ -1 +1 @@ -From a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 Mon Sep 17 00:00:00 2001 +From 5382502b316065bbb1abe1fdfbd97cc77bf0125f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org