From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE5B046211 for ; Thu, 13 Feb 2025 11:00:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6FB240287; Thu, 13 Feb 2025 11:00:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9737442EC0 for ; Thu, 13 Feb 2025 11:00:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HV1TaZ7HXsrhDr0y+mF3+toVEEFQ3rIRWDEp6bbhDuM=; b=Gw32LuRnfLydKUiDmADd0/pqnAFOMCJudze75uT3c7fzrpAqm0Dno/LSTTspzJ0Ror5Hz8 TOj34p+L0wBZKhNmEQ/JlFYzSKapzlG+YFjax8dU01JhIJdQb46abiEKrkTCxfnlNvW/4T ooc9bXGLWbVuzxgJixkqrC4t0IxAGgk= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-X0CMVgi2NMmQySVkpT5KtQ-1; Thu, 13 Feb 2025 05:00:29 -0500 X-MC-Unique: X0CMVgi2NMmQySVkpT5KtQ-1 X-Mimecast-MFC-AGG-ID: X0CMVgi2NMmQySVkpT5KtQ Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7312719039C1; Thu, 13 Feb 2025 10:00:28 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4013F1800365; Thu, 13 Feb 2025 10:00:26 +0000 (UTC) From: Kevin Traynor To: Ariel Otilibili Cc: dpdk stable Subject: patch 'net/sfc: remove unnecessary assignment' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:57:46 +0000 Message-ID: <20250213095933.362078-19-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: I3f5tS1JyOcbpcxQTN0GFziKp3uaNCWwxmotgwD1djQ_1739440828 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/08bb999893c0dfc8283c92fa63621d47697ee8ce Thanks. Kevin --- >From 08bb999893c0dfc8283c92fa63621d47697ee8ce Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Wed, 15 Jan 2025 13:11:51 +0100 Subject: [PATCH] net/sfc: remove unnecessary assignment [ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ] The same field was being set twice. Coverity issue: 384444 Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure") Signed-off-by: Ariel Otilibili --- drivers/net/sfc/sfc_repr.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c index c2e5d4eb9e..2c1421b959 100644 --- a/drivers/net/sfc/sfc_repr.c +++ b/drivers/net/sfc/sfc_repr.c @@ -770,9 +770,5 @@ sfc_repr_close(struct sfc_repr *sr) { SFC_ASSERT(sfc_repr_lock_is_locked(sr)); - SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED); - sr->state = SFC_ETHDEV_CLOSING; - - /* Put representor close actions here */ sr->state = SFC_ETHDEV_INITIALIZED; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:36.644087311 +0000 +++ 0019-net-sfc-remove-unnecessary-assignment.patch 2025-02-12 17:29:34.187944957 +0000 @@ -1 +1 @@ -From de87641d5c004ef505d58d542a66d66f6a1cb2be Mon Sep 17 00:00:00 2001 +From 08bb999893c0dfc8283c92fa63621d47697ee8ce Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org