From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8935146211 for ; Thu, 13 Feb 2025 11:00:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85D4142ED3; Thu, 13 Feb 2025 11:00:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5FADD42ED3 for ; Thu, 13 Feb 2025 11:00:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LrT2LlaWkv/1J5s7j6AsRVCazuH9KkzClJDc6GcQh6c=; b=U8h+p9EP4O86oE7jiu/F4v4+dEi6jOoYQDc2t5v+ufeq6y69PHtQUPcjWcUQJSSU5gZZ76 nrQlsprARmO6lT136sbEvzitJlEhwkc7EQmfskrQXuuf7wYGCbYF+qQ14jC45g9HF50rYL mmCiZxFIFOrLD5oKAxVYAO36DRvaNug= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-c5cFrdBzP82c6AEU8zgmRQ-1; Thu, 13 Feb 2025 05:00:41 -0500 X-MC-Unique: c5cFrdBzP82c6AEU8zgmRQ-1 X-Mimecast-MFC-AGG-ID: c5cFrdBzP82c6AEU8zgmRQ Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A3FB193578F; Thu, 13 Feb 2025 10:00:40 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 395C31800360; Thu, 13 Feb 2025 10:00:37 +0000 (UTC) From: Kevin Traynor To: Lukasz Krakowiak Cc: Yuan Wang , Bruce Richardson , dpdk stable Subject: patch 'net/ixgbe/base: fix TSAM checking return value' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:57:51 +0000 Message-ID: <20250213095933.362078-24-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bCzl8z8kFgEN9Aym-rDmIfifjWVVZGHVD6_X8LI8NY4_1739440840 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/194e3b363dbe1cd002bb5b5bb5535999bfcf6d73 Thanks. Kevin --- >From 194e3b363dbe1cd002bb5b5bb5535999bfcf6d73 Mon Sep 17 00:00:00 2001 From: Lukasz Krakowiak Date: Tue, 14 Jan 2025 18:10:11 +0800 Subject: [PATCH] net/ixgbe/base: fix TSAM checking return value [ upstream commit 0699ce484da324b60572a906cf7d013394f074e2 ] The error return value of ixgbe_get_fw_tsam_mode function, (IXGBE_NOT_IMPLEMENTED) is be a large integer that does not match the desired bool type. Rework to return false on error instead. Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device") Signed-off-by: Lukasz Krakowiak Signed-off-by: Yuan Wang Acked-by: Bruce Richardson --- drivers/net/ixgbe/base/ixgbe_api.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c index b4920867bc..ffff670dd3 100644 --- a/drivers/net/ixgbe/base/ixgbe_api.c +++ b/drivers/net/ixgbe/base/ixgbe_api.c @@ -1169,6 +1169,7 @@ s32 ixgbe_set_fw_drv_ver(struct ixgbe_hw *hw, u8 maj, u8 min, u8 build, bool ixgbe_get_fw_tsam_mode(struct ixgbe_hw *hw) { - return ixgbe_call_func(hw, hw->mac.ops.get_fw_tsam_mode, (hw), - IXGBE_NOT_IMPLEMENTED); + if (hw->mac.ops.get_fw_tsam_mode) + return hw->mac.ops.get_fw_tsam_mode(hw); + return false; } -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:37.205232776 +0000 +++ 0024-net-ixgbe-base-fix-TSAM-checking-return-value.patch 2025-02-12 17:29:34.265945422 +0000 @@ -1 +1 @@ -From 0699ce484da324b60572a906cf7d013394f074e2 Mon Sep 17 00:00:00 2001 +From 194e3b363dbe1cd002bb5b5bb5535999bfcf6d73 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0699ce484da324b60572a906cf7d013394f074e2 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org