From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19A8E46211 for ; Thu, 13 Feb 2025 11:00:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1561B42EBD; Thu, 13 Feb 2025 11:00:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AFCC742ED0 for ; Thu, 13 Feb 2025 11:00:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GvOZc79je6kmZIJhJ7aj49r+cpCPJhPPMP2vPJADaKk=; b=Zxgo9Ny17tzHOASVY4ib/i+fnaagskIwlaYd6+IerxdZAZmZ2059k9ai5/d4+G9IjB26z1 TV8sYdlZaFSG2sZt+/1AhQlIyR4hlRXhaAYKcHiAU5jnpH1UAVQzcGFNquPDryRDB0t6Cn RE6n66FMKZ+MHabcxOdAUTwH2aTxUvA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-5LxmVTWpNZWMQoejksUcUA-1; Thu, 13 Feb 2025 05:00:50 -0500 X-MC-Unique: 5LxmVTWpNZWMQoejksUcUA-1 X-Mimecast-MFC-AGG-ID: 5LxmVTWpNZWMQoejksUcUA_1739440849 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 676351955F28; Thu, 13 Feb 2025 10:00:49 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D24011800570; Thu, 13 Feb 2025 10:00:47 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/iavf: remove reset of Tx prepare function pointer' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:57:55 +0000 Message-ID: <20250213095933.362078-28-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9bb2GGejAFXp7I1t8mgBgFxFGIfeGks3b4MQ1u4hjkE_1739440849 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/15e0157ef8e74951738e46c913b52961ace7076c Thanks. Kevin --- >From 15e0157ef8e74951738e46c913b52961ace7076c Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 13 Dec 2024 14:33:19 +0000 Subject: [PATCH] net/iavf: remove reset of Tx prepare function pointer [ upstream commit 41be96c907607bc709654f71901913f1534264f8 ] The iavf driver only contains a single Tx prepare function, so when selecting the Tx path, there is no need to reset and reassign the function pointer in the ethdev structure. This fixes an issue where the pointer was reset to NULL, but never assigned back later on function selection. Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") Fixes: 08eb6a9cc2e1 ("net/iavf: fix Tx L4 checksum") Fixes: 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512") Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- drivers/net/iavf/iavf_rxtx.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 6a093c6746..98a1d3f69d 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -4174,5 +4174,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev) goto normal; - dev->tx_pkt_prepare = NULL; if (use_sse) { PMD_DRV_LOG(DEBUG, "Using Vector Tx (port %d).", @@ -4191,5 +4190,4 @@ iavf_set_tx_function(struct rte_eth_dev *dev) } else { tx_burst_type = IAVF_TX_AVX2_OFFLOAD; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX2 OFFLOAD Vector Tx (port %d).", dev->data->port_id); @@ -4204,15 +4202,12 @@ iavf_set_tx_function(struct rte_eth_dev *dev) } else if (check_ret == IAVF_VECTOR_OFFLOAD_PATH) { tx_burst_type = IAVF_TX_AVX512_OFFLOAD; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX512 OFFLOAD Vector Tx (port %d).", dev->data->port_id); } else if (check_ret == IAVF_VECTOR_CTX_PATH) { tx_burst_type = IAVF_TX_AVX512_CTX; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX512 CONTEXT Vector Tx (port %d).", dev->data->port_id); } else { tx_burst_type = IAVF_TX_AVX512_CTX_OFFLOAD; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, "Using AVX512 CONTEXT OFFLOAD Vector Tx (port %d).", dev->data->port_id); @@ -4252,5 +4247,4 @@ normal: dev->data->port_id); tx_burst_type = IAVF_TX_DEFAULT; - dev->tx_pkt_prepare = iavf_prep_pkts; if (no_poll_on_link_down) { -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:37.635423523 +0000 +++ 0028-net-iavf-remove-reset-of-Tx-prepare-function-pointer.patch 2025-02-12 17:29:34.287945554 +0000 @@ -1 +1 @@ -From 41be96c907607bc709654f71901913f1534264f8 Mon Sep 17 00:00:00 2001 +From 15e0157ef8e74951738e46c913b52961ace7076c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 41be96c907607bc709654f71901913f1534264f8 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index f7df5f21f2..457b5a5655 100644 +index 6a093c6746..98a1d3f69d 100644