From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7220F46211 for ; Thu, 13 Feb 2025 11:00:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D8DB40287; Thu, 13 Feb 2025 11:00:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D563D40287 for ; Thu, 13 Feb 2025 11:00:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jk+ZLw9UR7PK/MhyfM2MwWf4DlbkUsyaEE3z0odImLI=; b=PT9vcpeLziJETpNKh0DYmkt4MgZgsOViHJokMlgAY9mH6OY/KmBARfelZTHa6Fgp/IysmO IXw5wyN81E8H4so1R4vT4768eoEUg2WwQTcipuFSUrX0HekEkRbaKOi/oXGxK0BWW7Ngmj 0ReiOFQhnHtNnWZpsBMWt4tC7+ab854= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-VWeyFvCeMr-zxfYTrAbpHg-1; Thu, 13 Feb 2025 05:00:54 -0500 X-MC-Unique: VWeyFvCeMr-zxfYTrAbpHg-1 X-Mimecast-MFC-AGG-ID: VWeyFvCeMr-zxfYTrAbpHg Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 66F881800373; Thu, 13 Feb 2025 10:00:53 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 22A501800365; Thu, 13 Feb 2025 10:00:51 +0000 (UTC) From: Kevin Traynor To: Nawal Kishor Cc: dpdk stable Subject: patch 'common/cnxk: fix atomic load in batch ops' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:57:57 +0000 Message-ID: <20250213095933.362078-30-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lpivTDRxfvdOxzP6EGAS44ALifz0x3GpOf0gsRCusEI_1739440853 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8ed2702aff3abf17e78b3582d220a28ea9f4641e Thanks. Kevin --- >From 8ed2702aff3abf17e78b3582d220a28ea9f4641e Mon Sep 17 00:00:00 2001 From: Nawal Kishor Date: Mon, 2 Dec 2024 22:27:39 +0530 Subject: [PATCH] common/cnxk: fix atomic load in batch ops [ upstream commit 73d38682fddd614d95942442c20b3a1de211bb4c ] In roc batch alloc wait code, __ATOMIC_RELAXED is changed to __ATOMIC_ACQUIRE in order to avoid potential out of order loads. Fixes: 50d08d3934ec ("common/cnxk: fix batch alloc completion poll logic") Signed-off-by: Nawal Kishor --- .mailmap | 1 + drivers/common/cnxk/roc_npa.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 07ae8c48fc..58811dac34 100644 --- a/.mailmap +++ b/.mailmap @@ -1079,4 +1079,5 @@ Nathan Brown Nathan Law Nathan Skrzypczak +Nawal Kishor Neel Patel Neil Horman diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa.h index f7cb4460e7..8525038810 100644 --- a/drivers/common/cnxk/roc_npa.h +++ b/drivers/common/cnxk/roc_npa.h @@ -256,5 +256,5 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line, unsigned int wait_us) * of the 128 byte cache line. */ - while (((__atomic_load_n(cache_line, __ATOMIC_RELAXED) >> 5) & 0x3) == + while (((__atomic_load_n(cache_line, __ATOMIC_ACQUIRE) >> 5) & 0x3) == ALLOC_CCODE_INVAL) if (wait_us && (plt_tsc_cycles() - start) >= ticks) -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:37.842671336 +0000 +++ 0030-common-cnxk-fix-atomic-load-in-batch-ops.patch 2025-02-12 17:29:34.296945607 +0000 @@ -1 +1 @@ -From 73d38682fddd614d95942442c20b3a1de211bb4c Mon Sep 17 00:00:00 2001 +From 8ed2702aff3abf17e78b3582d220a28ea9f4641e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 73d38682fddd614d95942442c20b3a1de211bb4c ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 1ed47e1cad..8524952d24 100644 +index 07ae8c48fc..58811dac34 100644 @@ -22 +23 @@ -@@ -1080,4 +1080,5 @@ Nathan Brown +@@ -1079,4 +1079,5 @@ Nathan Brown