From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0261E46211 for ; Thu, 13 Feb 2025 11:01:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F251442EEF; Thu, 13 Feb 2025 11:01:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DF35D42EEF for ; Thu, 13 Feb 2025 11:01:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CSgDgwH/gWqvTR0TRgvGzFBJPEPUipo9ahY8qfBflPY=; b=dZCnhqca6pkHBpm6VcX8Ue2jyouhVB7dS8B5yOaOOKPI7YG/vz/YGXJq0JlabDMt1R9Mv/ x80PnMDAbdSBqEfz09qzy9UlUZhjXhIB/fNZyb95Z4LY3QBj/n9suZnBPifj2LoToiv0sd siqrpL5hr76Ed1EvL4rM1fJwTXViIZs= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-cKEQsOObOaKV7k1EN8LJyQ-1; Thu, 13 Feb 2025 05:01:37 -0500 X-MC-Unique: cKEQsOObOaKV7k1EN8LJyQ-1 X-Mimecast-MFC-AGG-ID: cKEQsOObOaKV7k1EN8LJyQ Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3F48E1800360; Thu, 13 Feb 2025 10:01:36 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5562A1800360; Thu, 13 Feb 2025 10:01:34 +0000 (UTC) From: Kevin Traynor To: Piotr Krzewinski Cc: Harry van Haaren , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , dpdk stable Subject: patch 'service: fix getting service lcore attributes' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:16 +0000 Message-ID: <20250213095933.362078-49-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ohyMCzV2MNQgh-RRWLYXpY7G4CNRCrVxGoOkYWA0PQk_1739440896 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9191c6d2c7133d016194bc72f52f8b51aed440ec Thanks. Kevin --- >From 9191c6d2c7133d016194bc72f52f8b51aed440ec Mon Sep 17 00:00:00 2001 From: Piotr Krzewinski Date: Fri, 20 Dec 2024 15:29:38 +0100 Subject: [PATCH] service: fix getting service lcore attributes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 1ecb19eb4f44f984f15068834ef0c530f24ae697 ] Perf test service_perf_autotest was failing after introduction of lcore variables. Fixed getting of idle_ and error_ service call statistics. Fixes: b24bbaedbba2 ("service: keep per-lcore state in lcore variable") Signed-off-by: Piotr Krzewinski Acked-by: Harry van Haaren Reviewed-by: Mattias Rönnblom --- .mailmap | 1 + lib/eal/common/rte_service.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 7d9b19d51f..56550db0f8 100644 --- a/.mailmap +++ b/.mailmap @@ -1201,4 +1201,5 @@ Piotr Bartosiewicz Piotr Bronowski Piotr Gardocki +Piotr Krzewinski Piotr Kubaj Piotr Kwapulinski diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c index dad3150df9..1821746337 100644 --- a/lib/eal/common/rte_service.c +++ b/lib/eal/common/rte_service.c @@ -880,5 +880,5 @@ static uint64_t lcore_attr_get_service_idle_calls(uint32_t service_id, unsigned int lcore) { - struct core_state *cs = &lcore_states[lcore]; + struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states); return rte_atomic_load_explicit(&cs->service_stats[service_id].idle_calls, @@ -889,5 +889,5 @@ static uint64_t lcore_attr_get_service_error_calls(uint32_t service_id, unsigned int lcore) { - struct core_state *cs = &lcore_states[lcore]; + struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states); return rte_atomic_load_explicit(&cs->service_stats[service_id].error_calls, -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:39.785050645 +0000 +++ 0049-service-fix-getting-service-lcore-attributes.patch 2025-02-12 17:29:34.351945936 +0000 @@ -1 +1 @@ -From 1ecb19eb4f44f984f15068834ef0c530f24ae697 Mon Sep 17 00:00:00 2001 +From 9191c6d2c7133d016194bc72f52f8b51aed440ec Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 1ecb19eb4f44f984f15068834ef0c530f24ae697 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 19bbdbc0c8..df68fc7d34 100644 +index 7d9b19d51f..56550db0f8 100644 @@ -28 +29 @@ -@@ -1203,4 +1203,5 @@ Piotr Bartosiewicz +@@ -1201,4 +1201,5 @@ Piotr Bartosiewicz