From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42E5346211 for ; Thu, 13 Feb 2025 11:01:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C35B42EF5; Thu, 13 Feb 2025 11:01:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 33A8842EF1 for ; Thu, 13 Feb 2025 11:01:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cL79eLAwvB+CBOqMbEYu1cMDGvQy7d9xbQbPkBBkG2s=; b=BOHwfVdOgP5uRDPKGSCmXtUROzvDWkPxUFl150flzhRuYMetSnDUy715+VamuEp19JiNmm dtt6FBvPtkbnggeKhhUz4MI2VT+4fW4BNcvwYEKWxMPfNo3QJoddzZ7PdDFVigrrFCF1xs +Lpu6PLhRwJDeZ1bLYeaDq12URTtX04= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-3NnGm2HvNhGOsGpE4IfJdQ-1; Thu, 13 Feb 2025 05:01:43 -0500 X-MC-Unique: 3NnGm2HvNhGOsGpE4IfJdQ-1 X-Mimecast-MFC-AGG-ID: 3NnGm2HvNhGOsGpE4IfJdQ_1739440902 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 85CA118EAB3C; Thu, 13 Feb 2025 10:01:42 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 444CA1800360; Thu, 13 Feb 2025 10:01:40 +0000 (UTC) From: Kevin Traynor To: Luca Vizzarro Cc: dpdk stable Subject: patch 'dts: fix MTU set command' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:19 +0000 Message-ID: <20250213095933.362078-52-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RPIlwH3qkUQgicS6GNhxME63-EpyzhbXcpr7JChC2sc_1739440902 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/79dd2b794e9f97e1e8a1d6e5825056450f35d00b Thanks. Kevin --- >From 79dd2b794e9f97e1e8a1d6e5825056450f35d00b Mon Sep 17 00:00:00 2001 From: Luca Vizzarro Date: Tue, 7 Jan 2025 13:55:30 +0000 Subject: [PATCH] dts: fix MTU set command [ upstream commit 0882424ffc9989df9804d62cef7f58f97bde3f67 ] There are some PMDs that in order to set a scatter-offload-compatible MTU size, they need to have started at least once since the startup of testpmd. This fixes the behaviour of the command to start and stop the ports before changing the MTU to ensure this happened Fixes: 9910db35962b ("dts: add MTU config methods to testpmd shell") Signed-off-by: Luca Vizzarro --- dts/framework/remote_session/testpmd_shell.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index d187eaea94..c01ee74b21 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -1837,4 +1837,5 @@ class TestPmdShell(DPDKShell): ) + @requires_started_ports @requires_stopped_ports def set_port_mtu(self, port_id: int, mtu: int, verify: bool = True) -> None: @@ -1843,5 +1844,7 @@ class TestPmdShell(DPDKShell): Some PMDs require that the port be stopped before changing the MTU, and it does no harm to stop the port before configuring in cases where it isn't required, so ports are stopped - prior to changing their MTU. + prior to changing their MTU. On the other hand, some PMDs require that the port had already + been started once since testpmd startup. Therefore, ports are also started before stopping + them to ensure this has happened. Args: -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:40.089205424 +0000 +++ 0052-dts-fix-MTU-set-command.patch 2025-02-12 17:29:34.356945965 +0000 @@ -1 +1 @@ -From 0882424ffc9989df9804d62cef7f58f97bde3f67 Mon Sep 17 00:00:00 2001 +From 79dd2b794e9f97e1e8a1d6e5825056450f35d00b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0882424ffc9989df9804d62cef7f58f97bde3f67 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org