From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 611EB46211 for ; Thu, 13 Feb 2025 11:01:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C02B40287; Thu, 13 Feb 2025 11:01:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 815C040287 for ; Thu, 13 Feb 2025 11:01:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sCUXWihUWeZWA9in/glFvYRwiO99MdkQUFqf2TLxcFY=; b=COOEOXCwstZCEvPIYI3jXTrkxviXT5pBkqG3wFTTA1h7TimR9EzBnzwdhdkKECnKOnPNQM dVIskYf0J5BPahf/wvbdrr3X8moL9ZxYBPPNE0ALEyOqz2Dw9bUdw/RV9ggwNvxDg73kxJ CfoIxdI183zcRUSMY7HQu6eUh87dnLE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-7KcEh1CdPjSlxmO7zfqLTA-1; Thu, 13 Feb 2025 05:01:46 -0500 X-MC-Unique: 7KcEh1CdPjSlxmO7zfqLTA-1 X-Mimecast-MFC-AGG-ID: 7KcEh1CdPjSlxmO7zfqLTA Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC479190F9C9; Thu, 13 Feb 2025 10:01:44 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4C8981800360; Thu, 13 Feb 2025 10:01:42 +0000 (UTC) From: Kevin Traynor To: Dean Marx Cc: Luca Vizzarro , dpdk stable Subject: patch 'dts: fix pass rate edge case in results' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:20 +0000 Message-ID: <20250213095933.362078-53-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -cp2FnBfu0OBlqtg--WobP0G8LypYjdnjSpBeqlrir0_1739440905 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4ffa336f68f8e11d712f970338be9ef764038136 Thanks. Kevin --- >From 4ffa336f68f8e11d712f970338be9ef764038136 Mon Sep 17 00:00:00 2001 From: Dean Marx Date: Wed, 15 Jan 2025 10:43:45 -0500 Subject: [PATCH] dts: fix pass rate edge case in results [ upstream commit 5dc5b2a5f67e655554b60a11e2f9f63ab13ad8d3 ] Add condition to results.json pass rate generation method which returns 0 as the pass rate when the suite is skipped, rather than causing a divide by 0 error. Fixes: 9f8a257235ac ("dts: improve test run result statistics") Signed-off-by: Dean Marx Reviewed-by: Luca Vizzarro --- dts/framework/test_result.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/dts/framework/test_result.py b/dts/framework/test_result.py index ba7c1c9804..45fc2e8241 100644 --- a/dts/framework/test_result.py +++ b/dts/framework/test_result.py @@ -325,11 +325,8 @@ class BaseResult: A dictionary with the PASS/FAIL ratio of all test cases. """ - return { - "PASS_RATE": ( - float(test_run_summary[Result.PASS.name]) - * 100 - / sum(test_run_summary[result.name] for result in Result if result != Result.SKIP) - ) - } + cases_not_skipped = sum( + test_run_summary[result.name] for result in Result if result != Result.SKIP + ) + return {"PASS_RATE": test_run_summary[Result.PASS.name] * 100.0 / max(cases_not_skipped, 1)} -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:40.189651005 +0000 +++ 0053-dts-fix-pass-rate-edge-case-in-results.patch 2025-02-12 17:29:34.357945971 +0000 @@ -1 +1 @@ -From 5dc5b2a5f67e655554b60a11e2f9f63ab13ad8d3 Mon Sep 17 00:00:00 2001 +From 4ffa336f68f8e11d712f970338be9ef764038136 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5dc5b2a5f67e655554b60a11e2f9f63ab13ad8d3 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org