From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1648946211 for ; Thu, 13 Feb 2025 11:02:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BF8942EFE; Thu, 13 Feb 2025 11:02:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 124DB42EE7 for ; Thu, 13 Feb 2025 11:02:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/nNB3QGgJYDEP00oArd2y4LP0k+KYZgFVtCft/xghqk=; b=HWI46Sh7pM0T9+dsdQTQcdAj92yGti1+BY/xoozmZPXhQuhc43H+m7gJIRvg7rv9N5Ampu GGze8PcMRsVJFAzLZL4VmQqEEnSljBZpD1GbCMNYKSBLq2klH67QpQ5w9guc/Ms01cKbkc S18OpfdMx6sjLXCJeVKDlAEGrLnAzHE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-j7HVpN2zMUaFr4afm_rDTw-1; Thu, 13 Feb 2025 05:02:07 -0500 X-MC-Unique: j7HVpN2zMUaFr4afm_rDTw-1 X-Mimecast-MFC-AGG-ID: j7HVpN2zMUaFr4afm_rDTw Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4495180087C; Thu, 13 Feb 2025 10:02:06 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DA3701800570; Thu, 13 Feb 2025 10:02:04 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Anatoly Burakov , Frode Nordahl , dpdk stable Subject: patch 'power: defer lcore variable allocation' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:29 +0000 Message-ID: <20250213095933.362078-62-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gP4eFWa26frIWvvE4Fq31lnPlvzE__kTWZmuVLHp87c_1739440927 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5803893830512c9ebc2c4c3ac81b895e478c6893 Thanks. Kevin --- >From 5803893830512c9ebc2c4c3ac81b895e478c6893 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 10 Feb 2025 22:31:56 +0100 Subject: [PATCH] power: defer lcore variable allocation [ upstream commit 108d30ab8d7a63fea4842c6079fe2669af17ae11 ] The lcore variable in this code unit is only used through rte_power_ethdev_pmgmt_queue_*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Signed-off-by: David Marchand Acked-by: Anatoly Burakov Acked-by: Frode Nordahl --- lib/power/rte_power_pmd_mgmt.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c index a2fff3b765..369ce3c354 100644 --- a/lib/power/rte_power_pmd_mgmt.c +++ b/lib/power/rte_power_pmd_mgmt.c @@ -73,4 +73,20 @@ struct __rte_cache_aligned pmd_core_cfg { static RTE_LCORE_VAR_HANDLE(struct pmd_core_cfg, lcore_cfgs); +static void +init_lcore_cfgs(void) +{ + struct pmd_core_cfg *lcore_cfg; + unsigned int lcore_id; + + if (lcore_cfgs != NULL) + return; + + RTE_LCORE_VAR_ALLOC(lcore_cfgs); + + /* initialize all tailqs */ + RTE_LCORE_VAR_FOREACH(lcore_id, lcore_cfg, lcore_cfgs) + TAILQ_INIT(&lcore_cfg->head); +} + static inline bool queue_equal(const union queue *l, const union queue *r) @@ -518,4 +534,5 @@ rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id, uint16_t port_id, } + init_lcore_cfgs(); lcore_cfg = RTE_LCORE_VAR_LCORE(lcore_id, lcore_cfgs); @@ -619,4 +636,6 @@ rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id, /* no need to check queue id as wrong queue id would not be enabled */ + + init_lcore_cfgs(); lcore_cfg = RTE_LCORE_VAR_LCORE(lcore_id, lcore_cfgs); @@ -769,14 +788,6 @@ rte_power_pmd_mgmt_get_scaling_freq_max(unsigned int lcore) RTE_INIT(rte_power_ethdev_pmgmt_init) { - unsigned int lcore_id; - struct pmd_core_cfg *lcore_cfg; int i; - RTE_LCORE_VAR_ALLOC(lcore_cfgs); - - /* initialize all tailqs */ - RTE_LCORE_VAR_FOREACH(lcore_id, lcore_cfg, lcore_cfgs) - TAILQ_INIT(&lcore_cfg->head); - /* initialize config defaults */ emptypoll_max = 512; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:41.113460121 +0000 +++ 0062-power-defer-lcore-variable-allocation.patch 2025-02-12 17:29:34.390946168 +0000 @@ -1 +1 @@ -From 108d30ab8d7a63fea4842c6079fe2669af17ae11 Mon Sep 17 00:00:00 2001 +From 5803893830512c9ebc2c4c3ac81b895e478c6893 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 108d30ab8d7a63fea4842c6079fe2669af17ae11 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org