From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09E6446211 for ; Thu, 13 Feb 2025 11:00:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0506D42ECA; Thu, 13 Feb 2025 11:00:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BA62D42ECA for ; Thu, 13 Feb 2025 11:00:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AaVepz6jmmlh6Zru8M/4W4q/1ouK/QEG8f2Wh0jWwYk=; b=C62tsWUcknAgvMIb1uEhoOYMOerEoeCqjQPrVHd55TJwGVK+XpKx9/zsHxJh3s5NE/gLPM PQBftM/1z6X5gi2d1KhbPLpDVb4E9pg2TG1meVGeuWNLSbSXJiQV1dAXTqEOM8TJl0kfla 2SAMJBitJkZx/1/xxkUtHs2fkKWfiYg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-IJgmkwiJOty2kkaJuVL-2w-1; Thu, 13 Feb 2025 05:00:03 -0500 X-MC-Unique: IJgmkwiJOty2kkaJuVL-2w-1 X-Mimecast-MFC-AGG-ID: IJgmkwiJOty2kkaJuVL-2w Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B77D180099A; Thu, 13 Feb 2025 10:00:02 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 990FD1800570; Thu, 13 Feb 2025 10:00:00 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: David Marchand , dpdk stable Subject: patch 'crypto/cnxk: fix build with GCC 15' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:57:34 +0000 Message-ID: <20250213095933.362078-7-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: A6hLABH5sc1-B5y5NZsZrJF8tJuDyT9EJ_hNGjUPJgk_1739440802 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/6e0d453c34146d4faabe1ab28d49c55e11ff542c Thanks. Kevin --- >From 6e0d453c34146d4faabe1ab28d49c55e11ff542c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 20 Jan 2025 15:23:38 -0800 Subject: [PATCH] crypto/cnxk: fix build with GCC 15 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 224e37a6a442b6a1f6d179b1756383f1a80cf3ed ] GCC 15 produces warnings about uninitialized variables. In file included from ../lib/mbuf/rte_mbuf.h:36, from ../lib/cryptodev/rte_crypto.h:15, from ../lib/cryptodev/rte_cryptodev.h:19, from ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:5: In function ‘pdcp_chain_sg1_prep’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1621:11, inlined from ‘fill_pdcp_chain_params’ at ../drivers/crypto/cnxk/cnxk_se.h:3114:8, inlined from ‘cpt_sym_inst_fill’ at ../drivers/crypto/cnxk/cnxk_se.h:3364:9, inlined from ‘cn9k_cpt_inst_prep’ at ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:93:10: ../lib/eal/include/rte_common.h:469:38: warning: ‘fc_params.meta_buf.vaddr’ may be used uninitialized [-Wmaybe-uninitialized] 469 | #define RTE_PTR_ADD(ptr, x) ((void*)((uintptr_t)(ptr) + (x))) | ^~~~~~~~~~~~~~~~ ../drivers/common/cnxk/roc_platform.h:47:34: note: in expansion of macro ‘RTE_PTR_ADD’ 47 | #define PLT_PTR_ADD RTE_PTR_ADD | ^~~~~~~~~~~ ../drivers/crypto/cnxk/cnxk_se.h:900:19: note: in expansion of macro ‘PLT_PTR_ADD’ 900 | m_vaddr = PLT_PTR_ADD(m_vaddr, ROC_SE_OFF_CTRL_LEN + PLT_ALIGN_CEIL(hdr_len, 8)); | ^~~~~~~~~~~ In file included from ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:20: ../drivers/crypto/cnxk/cnxk_se.h: In function ‘cn9k_cpt_inst_prep’: ../drivers/crypto/cnxk/cnxk_se.h:3008:33: note: ‘fc_params.meta_buf.vaddr’ was declared here 3008 | struct roc_se_fc_params fc_params; | ^~~~~~~~~ In function ‘pdcp_chain_sg1_prep’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1621:11, inlined from ‘fill_pdcp_chain_params’ at ../drivers/crypto/cnxk/cnxk_se.h:3114:8, inlined from ‘cpt_sym_inst_fill’ at ../drivers/crypto/cnxk/cnxk_se.h:3364:9, inlined from ‘cn9k_cpt_inst_prep’ at ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:82:10: ../lib/eal/include/rte_common.h:469:38: warning: ‘fc_params.meta_buf.vaddr’ may be used uninitialized [-Wmaybe-uninitialized] 469 | #define RTE_PTR_ADD(ptr, x) ((void*)((uintptr_t)(ptr) + (x))) | ^~~~~~~~~~~~~~~~ ../drivers/common/cnxk/roc_platform.h:47:34: note: in expansion of macro ‘RTE_PTR_ADD’ 47 | #define PLT_PTR_ADD RTE_PTR_ADD | ^~~~~~~~~~~ ../drivers/crypto/cnxk/cnxk_se.h:900:19: note: in expansion of macro ‘PLT_PTR_ADD’ 900 | m_vaddr = PLT_PTR_ADD(m_vaddr, ROC_SE_OFF_CTRL_LEN + PLT_ALIGN_CEIL(hdr_len, 8)); | ^~~~~~~~~~~ ../drivers/crypto/cnxk/cnxk_se.h: In function ‘cn9k_cpt_inst_prep’: ../drivers/crypto/cnxk/cnxk_se.h:3008:33: note: ‘fc_params.meta_buf.vaddr’ was declared here 3008 | struct roc_se_fc_params fc_params; | ^~~~~~~~~ Fixes: d3bff77cc371 ("crypto/cnxk: separate out PDCP chain datapath") Signed-off-by: Stephen Hemminger Acked-by: David Marchand --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index 7262a49945..649e38c495 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -3006,5 +3006,5 @@ fill_pdcp_chain_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess, uint32_t ci_data_length, ci_data_offset, a_data_length, a_data_offset; struct rte_crypto_sym_op *sym_op = cop->sym; - struct roc_se_fc_params fc_params; + struct roc_se_fc_params fc_params = { }; struct rte_mbuf *m_src, *m_dst; uint8_t cpt_op = sess->cpt_op; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:35.395580012 +0000 +++ 0007-crypto-cnxk-fix-build-with-GCC-15.patch 2025-02-12 17:29:34.137944659 +0000 @@ -1 +1 @@ -From 224e37a6a442b6a1f6d179b1756383f1a80cf3ed Mon Sep 17 00:00:00 2001 +From 6e0d453c34146d4faabe1ab28d49c55e11ff542c Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 224e37a6a442b6a1f6d179b1756383f1a80cf3ed ] + @@ -54 +55,0 @@ -Cc: stable@dpdk.org