From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D29746211 for ; Thu, 13 Feb 2025 11:02:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3856942F04; Thu, 13 Feb 2025 11:02:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 42AE742F04 for ; Thu, 13 Feb 2025 11:02:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hDrPFy3JE498RZYs4Ehs2+hw7iGSK5Nsod6WXOSan3g=; b=S8iV17rmMnGeC6EICXwryq07leWpuFPnrh+czufGGa5rz/ZNFhyvOHNtpa1ztYdQX0N6Sl Z/Dce0eq0rYzsN0yNNHihLxI8gd/31l2Jbivun+SUUNaZFk7ZJGyYpZ7CbMyQbE3yoyqI0 FvaitTkfc6ObXrgs+41rHWuHKjKfsNs= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-FrMvw637OVunb3GeheGAVA-1; Thu, 13 Feb 2025 05:02:26 -0500 X-MC-Unique: FrMvw637OVunb3GeheGAVA-1 X-Mimecast-MFC-AGG-ID: FrMvw637OVunb3GeheGAVA Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AECB7180087E; Thu, 13 Feb 2025 10:02:25 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2ECC41800360; Thu, 13 Feb 2025 10:02:23 +0000 (UTC) From: Kevin Traynor To: Peter Spreadborough Cc: Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: address uninitialized variables' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:37 +0000 Message-ID: <20250213095933.362078-70-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: avlj14Y7o9-crNURHZS1JG2BWchxKbHBC4xjWgebb2k_1739440945 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0459266ffcac228396ea2e8864bde3bb68478336 Thanks. Kevin --- >From 0459266ffcac228396ea2e8864bde3bb68478336 Mon Sep 17 00:00:00 2001 From: Peter Spreadborough Date: Mon, 2 Dec 2024 16:12:08 -0500 Subject: [PATCH] net/bnxt: address uninitialized variables [ upstream commit 7ef8b9a8a16bcc3574d4c69a29ee2039e3778045 ] This change addresses the CID 449065: Uninitialized variables (UNINIT) issues reported by coverity. Coverity issue: 449065 Fixes: 80317ff6adfd ("net/bnxt/tf_core: support Thor2") Fixes: 0513f0af034d ("net/bnxt/tf_ulp: add stats cache for Thor2") Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/v3/tfc_em.c | 1 + drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/bnxt/tf_core/v3/tfc_em.c b/drivers/net/bnxt/tf_core/v3/tfc_em.c index a70e35b6b1..d460ff2ee0 100644 --- a/drivers/net/bnxt/tf_core/v3/tfc_em.c +++ b/drivers/net/bnxt/tf_core/v3/tfc_em.c @@ -561,4 +561,5 @@ int tfc_em_delete_raw(struct tfc *tfcp, mpc_msg_out.msg_data = &rx_msg[TFC_MPC_HEADER_SIZE_BYTES]; mpc_msg_out.msg_size = TFC_MPC_MAX_RX_BYTES; + mpc_msg_out.chnl_id = 0; rc = tfc_mpc_send(tfcp->bp, diff --git a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c index 5fa8e240db..57cbaaf09c 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c +++ b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c @@ -225,4 +225,5 @@ static uint32_t ulp_stats_cache_main_loop(void *arg) break; + batch_info.enabled = false; rc = tfc_mpc_batch_start(&batch_info); if (unlikely(rc)) { -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:41.975470566 +0000 +++ 0070-net-bnxt-address-uninitialized-variables.patch 2025-02-12 17:29:34.415946318 +0000 @@ -1 +1 @@ -From 7ef8b9a8a16bcc3574d4c69a29ee2039e3778045 Mon Sep 17 00:00:00 2001 +From 0459266ffcac228396ea2e8864bde3bb68478336 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7ef8b9a8a16bcc3574d4c69a29ee2039e3778045 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -32 +33 @@ -index 85b72f328c..753c19b055 100644 +index 5fa8e240db..57cbaaf09c 100644 @@ -35 +36 @@ -@@ -223,4 +223,5 @@ static uint32_t ulp_stats_cache_main_loop(void *arg) +@@ -225,4 +225,5 @@ static uint32_t ulp_stats_cache_main_loop(void *arg)