From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4C7A46211 for ; Thu, 13 Feb 2025 11:02:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A070342F02; Thu, 13 Feb 2025 11:02:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2120542F02 for ; Thu, 13 Feb 2025 11:02:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pcA89+hlpjJpkKL6en+3ZMGbItiehY8kE7bdOxRdW/0=; b=I5A6RJUO7ijTWeXPxulTSozLLoe3TlH7YUQrAbArvOs9mTLxjjLnZ9OAaMwII1+c9oKaZh Sp3OZUZXVaBqvyV6aV5roQxhVMehYuKWnDX2JmDKcTLZh/9U4diXyB4ey2F7/X+ryqgnVf K3w/ygNqFmP48f6ZZOJJjU4XJqEhcAo= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408--fGdFxoaN2yBLCzlF463yw-1; Thu, 13 Feb 2025 05:02:49 -0500 X-MC-Unique: -fGdFxoaN2yBLCzlF463yw-1 X-Mimecast-MFC-AGG-ID: -fGdFxoaN2yBLCzlF463yw Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6967119039C5; Thu, 13 Feb 2025 10:02:48 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B5EB1800570; Thu, 13 Feb 2025 10:02:46 +0000 (UTC) From: Kevin Traynor To: Sasha Neftin Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: reset loop variable' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:47 +0000 Message-ID: <20250213095933.362078-80-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bc5O2F_WX_jBqgyc5YWApkh_MPWxaPj9wLOlwYJG9Cs_1739440968 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/916dc6644e6cebd65eb7da685631771b9f51df44 Thanks. Kevin --- >From 916dc6644e6cebd65eb7da685631771b9f51df44 Mon Sep 17 00:00:00 2001 From: Sasha Neftin Date: Thu, 6 Feb 2025 16:08:28 +0000 Subject: [PATCH] net/igc/base: reset loop variable [ upstream commit 60dca8e0f6b2d8526dc9dc8b54e59b5d68964e8e ] When writing to Shadow RAM, we set rev_val on success, but since the value is already set to success initially, it is possible for none of the writes to be successful, yet ret_val will still be set to success. Fix it by resetting the ret_val to failure before every loop iteration. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index 1277f59885..003c060215 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -566,4 +566,5 @@ static s32 __igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words, for (i = 0; i < words; i++) { + ret_val = -IGC_ERR_NVM; eewr = ((offset + i) << IGC_NVM_RW_ADDR_SHIFT) | (data[i] << IGC_NVM_RW_REG_DATA) | -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:43.127366512 +0000 +++ 0080-net-igc-base-reset-loop-variable.patch 2025-02-12 17:29:34.519946938 +0000 @@ -1 +1 @@ -From 60dca8e0f6b2d8526dc9dc8b54e59b5d68964e8e Mon Sep 17 00:00:00 2001 +From 916dc6644e6cebd65eb7da685631771b9f51df44 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 60dca8e0f6b2d8526dc9dc8b54e59b5d68964e8e ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ - drivers/net/intel/igc/base/igc_i225.c | 1 + + drivers/net/igc/base/igc_i225.c | 1 + @@ -21 +22 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c @@ -23,2 +24,2 @@ ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c