From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F28B46211 for ; Thu, 13 Feb 2025 11:03:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AFFA42F02; Thu, 13 Feb 2025 11:03:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 40E6A42F1F for ; Thu, 13 Feb 2025 11:02:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yj3a8fa3kehB7j/TN97l4P7Lf9fFthWnDz2pKH5ivrs=; b=KML4ynAisHwn+ZRtOLXdSOQjWzTkXq0d4Pv0XqsYVwEVAy63AT2HTQYdAwD6szGXfTzcKZ G2HNMrLm/tOIMBUW4StpJLaf7kyCxQ754JgFxft+Etrfu8y9gIKDxQ3pA/1kvEXGbcWsvu V8WXSik5iF8XcL6c4MIa0KynzPo17OM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-VJl1fW-DPXqRo8411MdKrg-1; Thu, 13 Feb 2025 05:02:57 -0500 X-MC-Unique: VJl1fW-DPXqRo8411MdKrg-1 X-Mimecast-MFC-AGG-ID: VJl1fW-DPXqRo8411MdKrg_1739440976 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 63EC51800875; Thu, 13 Feb 2025 10:02:56 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 67EBC1800365; Thu, 13 Feb 2025 10:02:54 +0000 (UTC) From: Kevin Traynor To: Dima Ruinskiy Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix unused value' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:50 +0000 Message-ID: <20250213095933.362078-83-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oz5mYOIMJ5CWKkZa1KILlKfuTL9HmmU0FIfOVlTkTc8_1739440976 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1e1ea5adb29f015539fb55fa17b2e2d8f859bce3 Thanks. Kevin --- >From 1e1ea5adb29f015539fb55fa17b2e2d8f859bce3 Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:31 +0000 Subject: [PATCH] net/igc/base: fix unused value [ upstream commit c506cc8305b4ca17bae903a54daaeaf5b7005038 ] Static analysis has reported that when there is no get link status callback function, the value set in the if condition is not used and gets overwritten in the "out" section of the code. Fix by not setting the variable. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index c7c2ec8ffe..23c68a3948 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -1115,8 +1115,6 @@ s32 igc_check_for_link_i225(struct igc_hw *hw) * a Link Status Change or Rx Sequence Error interrupt. */ - if (!mac->get_link_status) { - ret_val = IGC_SUCCESS; + if (!mac->get_link_status) goto out; - } /* First we want to see if the MII Status Register reports -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:43.444579740 +0000 +++ 0083-net-igc-base-fix-unused-value.patch 2025-02-12 17:29:34.524946968 +0000 @@ -1 +1 @@ -From c506cc8305b4ca17bae903a54daaeaf5b7005038 Mon Sep 17 00:00:00 2001 +From 1e1ea5adb29f015539fb55fa17b2e2d8f859bce3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c506cc8305b4ca17bae903a54daaeaf5b7005038 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ - drivers/net/intel/igc/base/igc_i225.c | 4 +--- + drivers/net/igc/base/igc_i225.c | 4 +--- @@ -21 +22 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c @@ -23,2 +24,2 @@ ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c