From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F37146211 for ; Thu, 13 Feb 2025 11:03:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A47042EE7; Thu, 13 Feb 2025 11:03:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D9B0442EE7 for ; Thu, 13 Feb 2025 11:03:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pf0KJtgAtZ1JcSZqY1H2FY7zoot2HsDJeR6NFLc6gYg=; b=XzDke1V1HJbPO1ILQS8sphL9jv+zywf/85HWU0vZPi0GW0tzKx7ArYvhD2lUXjMCplu4U/ bMQMn91BssTWKXEuVf5PjQg7yjZqn8rdJMrw6BOoYoLiQaYQZRk7VyOregvd5h5AFSu78r c663Wq0WUTGynCN0ZphmBIFeXxW3SEU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-685-ovVvlyiGNeqGR9Q0gyZEVA-1; Thu, 13 Feb 2025 05:03:06 -0500 X-MC-Unique: ovVvlyiGNeqGR9Q0gyZEVA-1 X-Mimecast-MFC-AGG-ID: ovVvlyiGNeqGR9Q0gyZEVA Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F3033180087B; Thu, 13 Feb 2025 10:03:05 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 20CF01800365; Thu, 13 Feb 2025 10:03:03 +0000 (UTC) From: Kevin Traynor To: Barbara Skobiej Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix data type in MAC hash' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:54 +0000 Message-ID: <20250213095933.362078-87-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qqXUUuN6sK1wwJ2diLNl30ydfNxmmayOFFkrvP_2F3o_1739440986 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/3bb018be50bd0b1759c06f44a4dd44dedf910b4d Thanks. Kevin --- >From 3bb018be50bd0b1759c06f44a4dd44dedf910b4d Mon Sep 17 00:00:00 2001 From: Barbara Skobiej Date: Thu, 6 Feb 2025 16:08:35 +0000 Subject: [PATCH] net/igc/base: fix data type in MAC hash [ upstream commit cad5c51ec3a0e965d6d4bb98166890499597f23a ] One of the bit shifts in MAC hash calculation triggers a static analysis warning about a potential overflow. Fix the data type to avoid this. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_mac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c index c69f8ac73b..cfb74a6443 100644 --- a/drivers/net/igc/base/igc_mac.c +++ b/drivers/net/igc/base/igc_mac.c @@ -540,6 +540,8 @@ u32 igc_hash_mc_addr_generic(struct igc_hw *hw, u8 *mc_addr) } - hash_value = hash_mask & (((mc_addr[4] >> (8 - bit_shift)) | - (((u16)mc_addr[5]) << bit_shift))); + hash_value = (u32)mc_addr[4]; + hash_value = hash_value >> (8 - bit_shift); + hash_value |= (((u32)mc_addr[5]) << bit_shift); + hash_value &= hash_mask; return hash_value; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:43.883987395 +0000 +++ 0087-net-igc-base-fix-data-type-in-MAC-hash.patch 2025-02-12 17:29:34.543947081 +0000 @@ -1 +1 @@ -From cad5c51ec3a0e965d6d4bb98166890499597f23a Mon Sep 17 00:00:00 2001 +From 3bb018be50bd0b1759c06f44a4dd44dedf910b4d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cad5c51ec3a0e965d6d4bb98166890499597f23a ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/igc/base/igc_mac.c | 6 ++++-- + drivers/net/igc/base/igc_mac.c | 6 ++++-- @@ -19 +20 @@ -diff --git a/drivers/net/intel/igc/base/igc_mac.c b/drivers/net/intel/igc/base/igc_mac.c +diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c @@ -21,2 +22,2 @@ ---- a/drivers/net/intel/igc/base/igc_mac.c -+++ b/drivers/net/intel/igc/base/igc_mac.c +--- a/drivers/net/igc/base/igc_mac.c ++++ b/drivers/net/igc/base/igc_mac.c