From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C02BF46211 for ; Thu, 13 Feb 2025 11:03:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCE1042EE7; Thu, 13 Feb 2025 11:03:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3328D42F3F for ; Thu, 13 Feb 2025 11:03:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739440992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x9rBIfkvSNXY4cXUU6hJjHkv1tI3/1IlREV1TER6ArM=; b=OuPgBfC13zjU9bHLxwM0s1IBA7mgitPfijOkjM4x63ALByiKITRM9KZqI+EKayXHtZVQVi JOxBulVJeP+5NqhjlWxhxsKBxbOxJEAfWa51SfRxgvNxZg68s9UVlkjxDbogFZ4bf9w916 DSrIVGdAwF89KmznjvK9BbeUuBHklW8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-eY6T-e4GPNicTTvIWAvXYQ-1; Thu, 13 Feb 2025 05:03:09 -0500 X-MC-Unique: eY6T-e4GPNicTTvIWAvXYQ-1 X-Mimecast-MFC-AGG-ID: eY6T-e4GPNicTTvIWAvXYQ Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 92B7919783BD; Thu, 13 Feb 2025 10:03:08 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 878BA1800570; Thu, 13 Feb 2025 10:03:06 +0000 (UTC) From: Kevin Traynor To: Przemyslaw Ciesielski Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix NVM data type in bit shift' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:58:55 +0000 Message-ID: <20250213095933.362078-88-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wlHM-j0-p2f_C6-N4iHnXm6VZmPCFzDxTNASaDNiNao_1739440988 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/accc5041393d0693307ac3c7c097555339c8369e Thanks. Kevin --- >From accc5041393d0693307ac3c7c097555339c8369e Mon Sep 17 00:00:00 2001 From: Przemyslaw Ciesielski Date: Thu, 6 Feb 2025 16:08:36 +0000 Subject: [PATCH] net/igc/base: fix NVM data type in bit shift [ upstream commit d6ad4cdad361558bfb2c04112bd6650debbc9c7f ] There is a static analysis warning due to wrong data types being used for NVM read data shifts. Fix it via explicit type cast. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_nvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/base/igc_nvm.c b/drivers/net/igc/base/igc_nvm.c index a7c901ab56..d37a3ffb0e 100644 --- a/drivers/net/igc/base/igc_nvm.c +++ b/drivers/net/igc/base/igc_nvm.c @@ -927,5 +927,5 @@ s32 igc_read_pba_num_generic(struct igc_hw *hw, u32 *pba_num) return -IGC_NOT_IMPLEMENTED; } - *pba_num = (u32)(nvm_data << 16); + *pba_num = ((u32)nvm_data << 16); ret_val = hw->nvm.ops.read(hw, NVM_PBA_OFFSET_1, 1, &nvm_data); @@ -934,5 +934,5 @@ s32 igc_read_pba_num_generic(struct igc_hw *hw, u32 *pba_num) return ret_val; } - *pba_num |= nvm_data; + *pba_num |= (u32)nvm_data; return IGC_SUCCESS; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:43.988785243 +0000 +++ 0088-net-igc-base-fix-NVM-data-type-in-bit-shift.patch 2025-02-12 17:29:34.545947093 +0000 @@ -1 +1 @@ -From d6ad4cdad361558bfb2c04112bd6650debbc9c7f Mon Sep 17 00:00:00 2001 +From accc5041393d0693307ac3c7c097555339c8369e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d6ad4cdad361558bfb2c04112bd6650debbc9c7f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/igc/base/igc_nvm.c | 4 ++-- + drivers/net/igc/base/igc_nvm.c | 4 ++-- @@ -19 +20 @@ -diff --git a/drivers/net/intel/igc/base/igc_nvm.c b/drivers/net/intel/igc/base/igc_nvm.c +diff --git a/drivers/net/igc/base/igc_nvm.c b/drivers/net/igc/base/igc_nvm.c @@ -21,2 +22,2 @@ ---- a/drivers/net/intel/igc/base/igc_nvm.c -+++ b/drivers/net/intel/igc/base/igc_nvm.c +--- a/drivers/net/igc/base/igc_nvm.c ++++ b/drivers/net/igc/base/igc_nvm.c