From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E8C446211 for ; Thu, 13 Feb 2025 11:03:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77DF642F37; Thu, 13 Feb 2025 11:03:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B3EA442F51 for ; Thu, 13 Feb 2025 11:03:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739441017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fHUPTKEVZRbpM1PkKlf4AfP2bfLpXhwJuf6TY4O7UeM=; b=atzLmyQaqwavqq/mFUMTbGLruJTEYbKCU188XHz39fkKANdDnQxQ4zF+yKTGHCRitnXDRR KkuuLz+5cnr68IqckKjztn0WeUTnpUISjpgij5JuexhI/aZHh6qRzdhe/mlAf0p1ulLv3u XW8t9+HnI+9ucghqPHJhWr05WmDo5ZQ= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-ouKWx_zLORypmuQgHC3G7g-1; Thu, 13 Feb 2025 05:03:34 -0500 X-MC-Unique: ouKWx_zLORypmuQgHC3G7g-1 X-Mimecast-MFC-AGG-ID: ouKWx_zLORypmuQgHC3G7g Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 25EFC193578F; Thu, 13 Feb 2025 10:03:33 +0000 (UTC) Received: from rh.Home (unknown [10.45.224.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 408B31800570; Thu, 13 Feb 2025 10:03:30 +0000 (UTC) From: Kevin Traynor To: Dima Ruinskiy Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/e1000/base: fix unchecked return' has been queued to stable release 24.11.2 Date: Thu, 13 Feb 2025 09:59:05 +0000 Message-ID: <20250213095933.362078-98-ktraynor@redhat.com> In-Reply-To: <20250213095933.362078-1-ktraynor@redhat.com> References: <20250213095933.362078-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MbLDlp0TLQqz1h9HZnyaNhxrVaZssJP3Xmzsaxn4Zu0_1739441013 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/54d89cacabad676ab32c00c5ef60432be1eeca82 Thanks. Kevin --- >From 54d89cacabad676ab32c00c5ef60432be1eeca82 Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:46 +0000 Subject: [PATCH] net/e1000/base: fix unchecked return [ upstream commit b0b6b50c20b03170c83985194fd9acef9467ded6 ] Static analysis has detected a write that is not checked for errors, leading to ignored error return value. Add a check. Fixes: edcdb3c5f71b ("e1000/base: fix link flap on 82579") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/e1000/base/e1000_ich8lan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c index 14f86b7bdc..f5f91a148c 100644 --- a/drivers/net/e1000/base/e1000_ich8lan.c +++ b/drivers/net/e1000/base/e1000_ich8lan.c @@ -963,4 +963,6 @@ s32 e1000_set_eee_pchlan(struct e1000_hw *hw) ret_val = e1000_write_emi_reg_locked(hw, I82579_LPI_PLL_SHUT, data); + if (ret_val) + goto release; } -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:44.968516440 +0000 +++ 0098-net-e1000-base-fix-unchecked-return.patch 2025-02-12 17:29:34.588947350 +0000 @@ -1 +1 @@ -From b0b6b50c20b03170c83985194fd9acef9467ded6 Mon Sep 17 00:00:00 2001 +From 54d89cacabad676ab32c00c5ef60432be1eeca82 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b0b6b50c20b03170c83985194fd9acef9467ded6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/e1000/base/e1000_ich8lan.c | 2 ++ + drivers/net/e1000/base/e1000_ich8lan.c | 2 ++ @@ -19 +20 @@ -diff --git a/drivers/net/intel/e1000/base/e1000_ich8lan.c b/drivers/net/intel/e1000/base/e1000_ich8lan.c +diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c @@ -21,2 +22,2 @@ ---- a/drivers/net/intel/e1000/base/e1000_ich8lan.c -+++ b/drivers/net/intel/e1000/base/e1000_ich8lan.c +--- a/drivers/net/e1000/base/e1000_ich8lan.c ++++ b/drivers/net/e1000/base/e1000_ich8lan.c