From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E9D44622A for ; Fri, 14 Feb 2025 18:21:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D90DA406B7; Fri, 14 Feb 2025 18:21:52 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 71D3C4069D for ; Fri, 14 Feb 2025 18:21:50 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2fa4493a695so3487741a91.0 for ; Fri, 14 Feb 2025 09:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739553709; x=1740158509; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k4BGX8mrdECUGcDmE3lVhBRuX6KeQ84mN3E1mIvS5WE=; b=At0y04N687L72CKt0S3xgcSxd/lykr3Qd0qqi+isUkczurOgas5V1hODIV+L4bWaVJ esvLPhyJL+IH0G7XsIWXKhmvExMnMCc2pOucjJVRiM3zhDm7papECsGOFpbl0SH1ka/l fHHpRW+m+OHWyV1H/lOps+p7/wU69IQoCIn9yv9meWLR5mGE+79hJV3cJ+fKSa47bhDD AJRBBmlserXEK8/OB21bndO4LN0VdP0AbX96Je1STiBjAzt1LFuYRf1UCUmDLIv+TSFt Scw+RFdzhxwBPfR03pGnQ1q23AXf7bACQjRZprgRkzkh6QfmbVQpizB40I1NZ0OIApcq dbtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739553709; x=1740158509; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k4BGX8mrdECUGcDmE3lVhBRuX6KeQ84mN3E1mIvS5WE=; b=qnBWQhuHJJ0QIqncNUON439b7E4Gfmf0wJ7dy3lniL54yWy+tUba09v9w9vkDAxBRu 13dtC8R7Z3MkrTfvzL01oR2/0YnCN8TSXRKRMMVoK3yQwjMHVSnGRdNGqCjpwasBEcZs y/Xtsidx1KRn+xMzGEfcc3tKbkVZgovs0VsYxYtnv8xw4i4D7YCzojrCjPOQymzWZcbY NTQuk8Uqnky59jtYpAFslH1zuwYvQMUZ7NhzJgsylMtFN2bIfxUs6QDT4Yh12v+yFiBt VOGcNupWjgxBu7V7FDlUkZrVhHoneRjNSCkiz+9X8N3epKX0uIgIUyYpFThD1Lk0fH4U L79w== X-Forwarded-Encrypted: i=1; AJvYcCUJ7T0fRr8HawUFNLAw2Itlq5jMMrw9oNO739K2Nv7Zc9cG5F4lCgxgbQoMZ6J59poE4zBfnrM=@dpdk.org X-Gm-Message-State: AOJu0Ywf70PxVMizINNCKDizkZXcSMoPMWU0dcMcZ4xHPhqzH8RTqMsB ziEYOFEP9Lu8A0DKhSN4JYe9Mf2yU55D3jdkmUlgrrCNEOVlaeBjHLmLMcOOW8E= X-Gm-Gg: ASbGnct09I/8GWsmeM7O8GX1WlleuDINTHVSBeMQxcRJUUqpxyzGwJsuOWe3w342H6o YIgdKxqG8FyOlbFoFar+oX3aZsOD99AqA4qhl+NsyPzc+toO9wbsszV1w1rUe+42aowf8rYGTac C3bnp5uVsf/Nb8TUwXHOLNUKO7iaQDrwNIrh3ClUgd2vBTH6E47BDD4l/aN7EyDD8QwUyI7/iYp c4MiAJuEHGK2peknYncMrVqrUP0GfwuvUVdddVlDSIc1xnZL3MOyl+nLR30LvoZlbsEZXx7OM1i S6Tb12ADfD0YrEVzV9TbfikSRwhyTnJ669OSwY+XxEI2vojNvcOL1SB9yIfjeGvbw/CX X-Google-Smtp-Source: AGHT+IHz9jnNXtJO4peENvzCgcKmKCblXExbzaTZN5E6vrUPAGqEXbfZQVimrAzmBRMwWF1J40KXmw== X-Received: by 2002:a05:6a00:3915:b0:725:b201:2362 with SMTP id d2e1a72fcca58-732617c3c6emr250231b3a.11.1739553709701; Fri, 14 Feb 2025 09:21:49 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-adb5a52af8bsm3134264a12.50.2025.02.14.09.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 09:21:48 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ajit.khaparde@broadcom.com, stable@dpdk.org, Somnath Kotur , Kalesh AP Subject: [PATCH v2 4/7] net/bnxt: fix use after free Date: Fri, 14 Feb 2025 09:20:12 -0800 Message-ID: <20250214172134.73908-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250214172134.73908-1-stephen@networkplumber.org> References: <20250127180842.97907-1-stephen@networkplumber.org> <20250214172134.73908-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The filter cleanup loop was using STAILQ_FOREACH and rte_free and would dereference the filter after free. Found by build with -Dbsanitize=address,undefined Fixes: e8fe0e067b68 ("net/bnxt: fix allocation of PF info struct") Cc: ajit.khaparde@broadcom.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index 7b90ba651f..f083f3aa94 100644 --- a/drivers/net/bnxt/bnxt_filter.c +++ b/drivers/net/bnxt/bnxt_filter.c @@ -3,14 +3,12 @@ * All rights reserved. */ -#include - #include #include #include #include #include -#include +#include #include "bnxt.h" #include "bnxt_filter.h" @@ -151,7 +149,9 @@ void bnxt_free_filter_mem(struct bnxt *bp) bp->filter_info = NULL; for (i = 0; i < bp->pf->max_vfs; i++) { - STAILQ_FOREACH(filter, &bp->pf->vf_info[i].filter, next) { + struct bnxt_filter_info *tmp; + + STAILQ_FOREACH_SAFE(filter, &bp->pf->vf_info[i].filter, next, tmp) { rte_free(filter); STAILQ_REMOVE(&bp->pf->vf_info[i].filter, filter, bnxt_filter_info, next); -- 2.47.2