From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C5064623D for ; Sun, 16 Feb 2025 18:01:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 880B840E36; Sun, 16 Feb 2025 18:01:36 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id E42EA40E36 for ; Sun, 16 Feb 2025 18:01:29 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-22128b7d587so4725775ad.3 for ; Sun, 16 Feb 2025 09:01:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739725289; x=1740330089; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c8mVx65OZgwlPD3YqCSP4AJR4DoGBjJVIPIjf98KaNw=; b=Rk9NXfxX9bshNuibx/07c+o1fV4mI97LUAsaj0Ee8Ln75m0kvZGrsNrqAhGg4Eib1m /TKw3SR6pozGqhCsAt3EdH9IsYs+oucBKDiJ2DOO014R0TttTziSZU48k1K9ZGCFACI8 YP1MTfJrj9bNomPnRakye6UThRMO08rNBbs24armVFJnjlWpsP2uc/B9pzCCbyctSPrN v3GDaFismx/cOUTVwi1kXEMY3SGp3zklAUiMlE5gNRXPBPt3csKTx1zGLRLftoqayPbb SWjC2sBdEWlZSLd+6xEmGsAf1tE2MKPtUTpI+sKfzEpRoXcRNwDCpO9nX4ZOTlUBI8ha BT4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739725289; x=1740330089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c8mVx65OZgwlPD3YqCSP4AJR4DoGBjJVIPIjf98KaNw=; b=TD5ql5i7yEKGDlHGNsDMESgqMgtrx+M8c9OePBX8qDDWhYokhniGxugo+vTUDMC+4+ hZos5oYR7FqUtZqoJ35fHO2TuOLcmWxhRnwIsVowQwSeMSjBORcvp1+JLa0z9VsfVNK1 gW+xIoSqCRpxWuGlJIyW86Mj0Rt27d6DGqA55DzzQRmO2Vs44JS3mHOuuAbBzKaSAPhK FcGkV0UkxzUFhYic7BTv0wQYeLrBFparEhLiFFyUyV26xYMIl1vRHiRPo4zdvKmJTKer UEXKVz19xLaC5/jtb9CvIC/cFw50/FRB6+CS0qtk9A0AwXH2ASdv2wIBcZjEkoM/dV/k DM3Q== X-Forwarded-Encrypted: i=1; AJvYcCV08++WhspW71zm16VBeyXL3ZHvaTdLeO1x3QUcj/9m/x7xIHsCzm8/qfis1n6OVdVh3XfHMsI=@dpdk.org X-Gm-Message-State: AOJu0YzodwMPggFv4JKtX1zz+sUSiWOOkHpr81+8jXBQJ1Pl7yoiSNjE UrlpvoqGij90z9Fz+qFzzp+uHnoj+v/ZyovugQ5Kmiy4Z2DskgUVTPiVdQmEQ7Y= X-Gm-Gg: ASbGncuQzSi3dn+m91s8vrvRnVK5mkkGgTFu8heIER9PERg0cC/jr9t5Sqd5z0uK0wP nc2aW3eahfYjFz+qj/pWbbaFuLpcg1SOKMsTu3u5szO+xET2FZVmdoAKgpe6IHXgSz7sgO4KdAn qJKuYJ/baXoVw6k39bLnuk3LMSvt8NppVEGoYzcAeyTOtlOYvdwJqEV5RNr9QOBHZfHPY2S3o7H u8Fqntq+hl2OoeCLlitfSqgY8kqF1EmEhreEbZVHImPPvZAHxBnD7A92RSGJC2n55bAAGGks0Nl GpODJ9D+13kqs9AdvGeIsTUA5/kADD/4N2UwPrXnxTqWJ5NO2ki50V0+48lMMzAzUm8a X-Google-Smtp-Source: AGHT+IFdmOJwFsMuEc8aiwFbtI4nPUo6JodbZ9v1KZjETRRECBEiusMIGi4uBTOUHIx1C20ptWCIhg== X-Received: by 2002:a17:902:ecc7:b0:220:c2a8:6fbc with SMTP id d9443c01a7336-221040ac132mr86211975ad.34.1739725288972; Sun, 16 Feb 2025 09:01:28 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2211eafd20dsm11196805ad.182.2025.02.16.09.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 09:01:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Bruce Richardson , Kai Ji , Ciara Power , Fan Zhang Subject: [PATCH v8 10/17] crypto/qat: fix size calculation for memset Date: Sun, 16 Feb 2025 08:53:09 -0800 Message-ID: <20250216170110.7230-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250216170110.7230-1-stephen@networkplumber.org> References: <20241114011129.451243-1-stephen@networkplumber.org> <20250216170110.7230-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The memset was always doing 0 bytes since size computed later. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_sym_session.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 3564a33484..7836c95064 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -2347,7 +2347,7 @@ int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc, return 0; } -int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, +static int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, const uint8_t *authkey, uint32_t authkeylen, uint32_t aad_length, @@ -2620,27 +2620,27 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, break; case ICP_QAT_HW_AUTH_ALGO_SHA3_224: /* Plain SHA3-224 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_256: /* Plain SHA3-256 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_384: /* Plain SHA3-384 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_512: /* Plain SHA3-512 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC: state1_size = ICP_QAT_HW_AES_XCBC_MAC_STATE1_SZ; -- 2.47.2