From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B629C4624E for ; Mon, 17 Feb 2025 18:05:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC95C400D6; Mon, 17 Feb 2025 18:05:32 +0100 (CET) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mails.dpdk.org (Postfix) with ESMTP id 36FDE400D6 for ; Mon, 17 Feb 2025 18:05:32 +0100 (CET) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso50573105e9.1 for ; Mon, 17 Feb 2025 09:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739811932; x=1740416732; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PS5UzAUOJem3YSS5XDGbeC58VeQY3lW5KC6OkOid6dM=; b=fn/csT2pPqVtf2GnaWKU9ksmc2mpzREeK3CJuN5o8fne5gc8ARiNKZAHQodE0hDFEV +P+qUiCycP2iOOGktPgM2DWUg/msQP3f1MF/OXL8+FJ02gUuv3ZQL1ZPs4tyhak2Wd1q 1Wx0qUTBL6jWwgFAHYOFcCSQQ3NyIfoNPcxbZdW8Szm0P2XPjI9lWyXZfbLTLGIp2hpJ 2Gvabx9L6hYsP6IoagLUbiTllL6XuuphJz0U+PKuHf2fAiqAFBEfj/AqpTOUu5pcpQKD ddytsOMUyDR09qo++T0GmbldDDLLhOV/VnqnZ7nE1bZLg849P/rPMlV5kjXakbPlw7aO bPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739811932; x=1740416732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PS5UzAUOJem3YSS5XDGbeC58VeQY3lW5KC6OkOid6dM=; b=wqDTe69VREv9gkf4wlFvptrlIcHE9XurzoA1j0g9mzcjx0Rb+nCnqDdI2rPn0clgaH gZSuTYPCeqns7nDB/GXJdZroOD6Ao/SbF6hnR0TExEI1Ofwx18/ToyWRNLEs+b5EE2zR j4rJJ8hzJi77kc7asymlS+t8A8yamh+g2qiuCrvSPyMT1Lwz/Cjg8EkW+kGRAEkvBFSC Z8Q0mQOIm+sX42K8JyZYgs/WDMI8zACLtYxT+GKH+4Lp7+o+PCojnU2d4aIqQPUrC1MQ NM07r2sdtRaYRPqt/9LzHLBFFCIzTZxjaGJlY5jeihQVDWEDtyC+sCszWGjZah9P+YzJ 0wAw== X-Gm-Message-State: AOJu0YyN+/K1Y7SrmE2TR0DwPKgO80Trvc1gSAJbfmAr2AhO3/9pnuaS jPf3GKa1MNjhb8TaIuhvXBEgXg3GvBU63zNnFtJReRoaxasfWS0v X-Gm-Gg: ASbGncuJFuORkeSzm8ztPD5E1/EK6ernzooaI16Zo/MgxybSwg/mOr8KkrBX2+7htiz 8ZbjlLofoYIlVIDtaIn4RJXLNEd9OjjalSgg15+evY1H5OXFiyoTLJ2pxKLy+7PZ7n8oFD5LlMU wpDW0J8nkYTirzdgTgROYl62bBVify77gMQTQwlmlvUUdU5Am2NkWTqndxOzd5jZvpVGfCCG3D3 V5EJVVpwWnwaD4/tnDxtzfWXYMy33b7gXY7jwj04UPfMl8DHaxd5uVb+z8tgo+Tf3Yq603bzN4t EfRYxH2C4mnjYMcy1NUpNg== X-Google-Smtp-Source: AGHT+IFmmLWk5Ow0Y84Ag9lLlT4xMG68oxSjJVBcEtRzlyQHhfwzcCoC+0k8pYcnDDE4lbPa9KNf2w== X-Received: by 2002:a05:600d:8:b0:439:86c4:a8ec with SMTP id 5b1f17b1804b1-43986c4ac03mr40712705e9.15.1739811931469; Mon, 17 Feb 2025 09:05:31 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43987396d3dsm25822355e9.36.2025.02.17.09.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:05:31 -0800 (PST) From: luca.boccassi@gmail.com To: Ariel Otilibili Cc: dpdk stable Subject: patch 'net/sfc: remove unnecessary assignment' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:03:44 +0000 Message-ID: <20250217170456.1068278-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ff415bac32c84488567e15997421a7736a271f32 Thanks. Luca Boccassi --- >From ff415bac32c84488567e15997421a7736a271f32 Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Wed, 15 Jan 2025 13:11:51 +0100 Subject: [PATCH] net/sfc: remove unnecessary assignment [ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ] The same field was being set twice. Coverity issue: 384444 Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure") Signed-off-by: Ariel Otilibili --- drivers/net/sfc/sfc_repr.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c index 79025e9052..4234d63144 100644 --- a/drivers/net/sfc/sfc_repr.c +++ b/drivers/net/sfc/sfc_repr.c @@ -797,11 +797,7 @@ static void sfc_repr_close(struct sfc_repr *sr) { SFC_ASSERT(sfc_repr_lock_is_locked(sr)); - SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED); - sr->state = SFC_ETHDEV_CLOSING; - - /* Put representor close actions here */ sr->state = SFC_ETHDEV_INITIALIZED; } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:17.282207920 +0000 +++ 0011-net-sfc-remove-unnecessary-assignment.patch 2025-02-17 16:13:16.794441593 +0000 @@ -1 +1 @@ -From de87641d5c004ef505d58d542a66d66f6a1cb2be Mon Sep 17 00:00:00 2001 +From ff415bac32c84488567e15997421a7736a271f32 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit de87641d5c004ef505d58d542a66d66f6a1cb2be ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index c2e5d4eb9e..2c1421b959 100644 +index 79025e9052..4234d63144 100644 @@ -21 +22 @@ -@@ -769,11 +769,7 @@ static void +@@ -797,11 +797,7 @@ static void