From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2EDDE4624E
for <public@inbox.dpdk.org>; Mon, 17 Feb 2025 18:05:53 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1A562402C9;
Mon, 17 Feb 2025 18:05:53 +0100 (CET)
Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com
[209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id C7C0A400D6
for <stable@dpdk.org>; Mon, 17 Feb 2025 18:05:51 +0100 (CET)
Received: by mail-wr1-f48.google.com with SMTP id
ffacd0b85a97d-38f1e8efe82so5091729f8f.0
for <stable@dpdk.org>; Mon, 17 Feb 2025 09:05:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739811951; x=1740416751; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=xB5QEgeqw3qDeFlaLA+hd3YyhFzNLhjX+Xwklb/F1ac=;
b=ejujjJONBFjyZhy9E3oKt4gfNxjBhD3TanmugfPYLqqp8164inX9GO8YrZzkVgM+JI
AXXFmsDKzI5fHaF8hjVOh+l/NcBP0zHhcxx8MTwdnVtll7gFGCKvthMxFZGQ4YWi+hOK
dt6vzWcvoGECWY9XuP/L4D593nC+8c0Gaht+BqE2IfdOEXRD4chAtTGjdCOW9/tHNa7r
MmacspiFVPqMMLjMOEJeOegnd3HYzXHCdyiIri7yHc1EZyrfNvy0B2IOeqdGRppAL/sn
U9zoyxlxImgVZd8ExCZKRFU5Anv8UjXgFsR3104MDywfRaZs9I1AjBNlXan9wji0cPWg
VECQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739811951; x=1740416751;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=xB5QEgeqw3qDeFlaLA+hd3YyhFzNLhjX+Xwklb/F1ac=;
b=HGfDKf5UL5DVtSuha9MCWUZhKyu0D+f+dYaUcLSPUd2tqjS4tf6GS1fupaqtAQ0pMh
3m+Zp9ImPoLFNJJjZgY9XB8imPjIKzl8B1EXXno8ZDzl9aHV1JhCGeIDJYg9EDd8j6LA
uZ85zTDN2mbdkoM9jdnU1iS6gKxKy1sh/3R7DfqdhMLMNG+MKpExrjuKmIPoushAM+8k
ht4FgMaOl9cNfTRc8pRw/FbqMm9iAgTHM8ypWNxjLK2FNXsn5P+2m+dqew9gI1hgzaBH
ch/gn1lDG2pQzdKFkNEecz/HaeavAK2PFcWrHBi+ioq/IiZGMZrH1oPxhl4GxAC+dXU7
m1rQ==
X-Forwarded-Encrypted: i=1;
AJvYcCXdOAaMTLqQZn2DaH2VGFfLrM1RPEqUibY/PWQy09tpdQE5ZhQ5wiYJmMyH5rOnIt3uXsee/z4=@dpdk.org
X-Gm-Message-State: AOJu0YwBm4f/fribyS43Dp0eXSJD2Va/WokU3sA7DMGUegyvvqspsJBA
Pu3Xk4i70G3sEOpNYdi0UsxVLO1OVcVHwhD7zoj+EvoVg+09R4Up8NgupvRbwLL3dA==
X-Gm-Gg: ASbGncs/SJ4OVPAOg2ZU3W1lhn10pNFg/PFqqvghfF8CqpVgpbFcePrcJGDS+acdSWj
1m0UnNomCvTtloEmXKomsIvQQkrF8fl5hc53l+0/M+e0BgKEwXGA75k4pOIq8tVBocdfMkKfyQ9
gR1/iBFfLxuybbd1WEOKtyV2rk+/XP+b8ZbQe2xzPNCC+scnXSC555DF6cY5/DEuCGwkeUW55em
IlDLzz+2NczEIPQRRA5yTrW8C2d0hwLXF+jvX5OHunyDepXgcYYjDPu5MjVvrCPNhN5QzVDrd4W
9NP72R8yMxzciqJ0Bi8R6w==
X-Google-Smtp-Source: AGHT+IHJK/wyoJxIpFiP+Lj2o9BZhuVGGdks0bjf7Tdhfz919XbbcnDoWSvhPlsaroMfcmO6T8Uh0Q==
X-Received: by 2002:a5d:50cd:0:b0:38c:5e03:5bb with SMTP id
ffacd0b85a97d-38f33f51191mr9451686f8f.41.1739811951140;
Mon, 17 Feb 2025 09:05:51 -0800 (PST)
Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997])
by smtp.gmail.com with UTF8SMTPSA id
ffacd0b85a97d-38f258ccdabsm12736487f8f.28.2025.02.17.09.05.50
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 17 Feb 2025 09:05:50 -0800 (PST)
From: luca.boccassi@gmail.com
To: Wathsala Vithanage <wathsala.vithanage@arm.com>
Cc: Jack Bond-Preston <jack.bond-preston@foss.arm.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'crypto/openssl: fix CMAC auth context update' has been queued
to stable release 22.11.8
Date: Mon, 17 Feb 2025 17:03:51 +0000
Message-ID: <20250217170456.1068278-18-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.47.2
In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com>
References: <20250217170456.1068278-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Hi,
FYI, your patch has been queued to stable release 22.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/fab6dc3fdbe9db3ab64d3f1b670effdf0b7fe492
Thanks.
Luca Boccassi
---
>From fab6dc3fdbe9db3ab64d3f1b670effdf0b7fe492 Mon Sep 17 00:00:00 2001
From: Wathsala Vithanage <wathsala.vithanage@arm.com>
Date: Fri, 29 Nov 2024 20:20:22 +0000
Subject: [PATCH] crypto/openssl: fix CMAC auth context update
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
[ upstream commit 0241aebfa3bdc53fb36972fb116298adbdbd3957 ]
This patch removes an unnecessary cleanup of the shared CMAC context at
the end of the CMAC authentication function, which causes subsequent
calls to it to fail.
Fixes: 17d5bc6135af ("crypto/openssl: make per-QP auth context clones")
Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
Reviewed-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/crypto/openssl/rte_openssl_pmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index 7eaa9650b6..679a7bbeb6 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1594,9 +1594,6 @@ process_openssl_auth_cmac(struct rte_mbuf *mbuf_src, uint8_t *dst, int offset,
process_auth_final:
if (CMAC_Final(ctx, dst, (size_t *)&dstlen) != 1)
goto process_auth_err;
-
- CMAC_CTX_cleanup(ctx);
-
return 0;
process_auth_err:
--
2.47.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-17 16:13:17.525247203 +0000
+++ 0018-crypto-openssl-fix-CMAC-auth-context-update.patch 2025-02-17 16:13:16.798441593 +0000
@@ -1 +1 @@
-From 0241aebfa3bdc53fb36972fb116298adbdbd3957 Mon Sep 17 00:00:00 2001
+From fab6dc3fdbe9db3ab64d3f1b670effdf0b7fe492 Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit 0241aebfa3bdc53fb36972fb116298adbdbd3957 ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org
@@ -24 +25 @@
-index d2cf20c059..b090611bd0 100644
+index 7eaa9650b6..679a7bbeb6 100644
@@ -27 +28 @@
-@@ -1595,9 +1595,6 @@ process_openssl_auth_cmac(struct rte_mbuf *mbuf_src, uint8_t *dst, int offset,
+@@ -1594,9 +1594,6 @@ process_openssl_auth_cmac(struct rte_mbuf *mbuf_src, uint8_t *dst, int offset,