From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57C474624E for ; Mon, 17 Feb 2025 18:06:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47876400D6; Mon, 17 Feb 2025 18:06:58 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id C09F2400D6 for ; Mon, 17 Feb 2025 18:06:56 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4397e5d5d99so8388385e9.1 for ; Mon, 17 Feb 2025 09:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812016; x=1740416816; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=snn5+4BlwXn6S+N80x3RuWysMGNER0C5Bm9LS9sZ/mw=; b=l5GcjLuoBTHvXTHXAWqX0ztjfsTPWwRtukjMz6nWQ2Ws7hR0MPed7ypHrHqJPoZ+6T bwOqRwzbM7MR/h8UQ2Iv0o3bDzElH0SzIZtZyOyShDPBjQmSRxGLdGtJngeAFJCuIhC2 wbdPuBleUG85jXjWvRYtrze4b2wbnzzwHLECtxGJ+gqbpU5O4QneD7mmfiKo9GfOXF6/ TJiAexLdpGNkqyvWN4dDOru5Sc9j/fX+ZvzbrvHg4BffcW+Sr4EGk0rxCPXJoKp7wUkT Ha0gmyFQWa4v1m3BPlK3bpcNy/AkldpwUZfEF1913UgcFybrQtTeMSFPxlev7ykNSlAX kxlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812016; x=1740416816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=snn5+4BlwXn6S+N80x3RuWysMGNER0C5Bm9LS9sZ/mw=; b=OoMcQ8SbpOKIwpR1NJiX5HzP2GYrWoxWR/1tR6316M9IJUFqFF/H5ffK3HobLtGtDG 2NR54XTXgJZ5BcWnwaCYTrgXqdCzGnFRo9Qv67eRyjproaOVe2gM9xlyBIp3BiD8Wyc1 28wWWu41mHks+O21XWrFbeLxraTR89soVVCq3vntNa4jW/gSZmUQ+1f0HGspdvcqaupH 5y7ysImHGFDjfE2FSqrUzsvc6Z4vy3WoZn9VpZMTJjyCHZUhaf8HoAD0vWMMVFR6Yolu iAuy/R4DjqxkKffOC1n/wa354+sVrnQ9m6UnHx8FYa8g/IEbBctLTgB39Qc+JRBkkgn4 1c8w== X-Forwarded-Encrypted: i=1; AJvYcCX4nRKGIQ3tANBfjWIuitWy+qtsO2FJXs+rmTSevTsVBa+EISCxUbn1BCeqHbjaIE68teYjELg=@dpdk.org X-Gm-Message-State: AOJu0Ywo3htJfZdfGfRHy198I7aMx6WvGOlI3rZ5mdd0a1tP49rFOdd5 LwcD7lggmJmo6UMwdneHTsl5np1oUCLM4ZmCU+RVxVRLog6rIXfM0coaWyKrgd2iJw== X-Gm-Gg: ASbGnctd3slavurSMmzelH2zS4fRmv7TAd1j4iBFqMjQ7SOLeDCpmBMAqZwGz69Gk4n D5YgnfrRoZdo1XZQcBDkjLSIcqrLG+mnJlzx8FXCEkY50fq7Z9Iopwh127f7m9snvet5SiJuIZ3 hDXWtGWa3fC6kqGEWujLbevDI5Un3l3PC6JBxHcfsyH17Gfx3dScEbTJzvhZKGQYU3hGFVW0gdD wJJtJ8/2CM0w58hv1HJ4JeF7Hoz+L9H2LRnXcXzIS8xWJtmquU8FUf8zuj1kSIY8jXjLOPMHhwA 9IAm6D/7MqQJ94CMnLqgbg== X-Google-Smtp-Source: AGHT+IGtpNq3L6anIAw64vuMVeeDTcjaatvC2nRUqdrsqadDVS5d1DUucVPlbkmR8cLWllU8OmrZ6A== X-Received: by 2002:a05:600c:35d5:b0:439:4036:e925 with SMTP id 5b1f17b1804b1-4396e6eb290mr116010465e9.11.1739812015993; Mon, 17 Feb 2025 09:06:55 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4395a1b8471sm159488235e9.37.2025.02.17.09.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:06:54 -0800 (PST) From: luca.boccassi@gmail.com To: Przemyslaw Ciesielski Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix bitwise operation type' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:09 +0000 Message-ID: <20250217170456.1068278-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/74b1b8ee6e81a11702cd14363ecd21eddbaddc8d Thanks. Luca Boccassi --- >From 74b1b8ee6e81a11702cd14363ecd21eddbaddc8d Mon Sep 17 00:00:00 2001 From: Przemyslaw Ciesielski Date: Thu, 6 Feb 2025 16:08:26 +0000 Subject: [PATCH] net/igc/base: fix bitwise operation type [ upstream commit bf51125b75b18a3a43439edb2c6e1f0b14793d51 ] Static analysis has found type mismatch between mask and register value. Fix the bitwise operation type to avoid potential issues. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index c2fae6e797..97dc7f454d 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -341,7 +341,7 @@ void igc_release_swfw_sync_i225(struct igc_hw *hw, u16 mask) } swfw_sync = IGC_READ_REG(hw, IGC_SW_FW_SYNC); - swfw_sync &= ~mask; + swfw_sync &= ~(u32)mask; IGC_WRITE_REG(hw, IGC_SW_FW_SYNC, swfw_sync); igc_put_hw_semaphore_generic(hw); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:18.150549594 +0000 +++ 0036-net-igc-base-fix-bitwise-operation-type.patch 2025-02-17 16:13:16.838441592 +0000 @@ -1 +1 @@ -From bf51125b75b18a3a43439edb2c6e1f0b14793d51 Mon Sep 17 00:00:00 2001 +From 74b1b8ee6e81a11702cd14363ecd21eddbaddc8d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bf51125b75b18a3a43439edb2c6e1f0b14793d51 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/igc/base/igc_i225.c | 2 +- + drivers/net/igc/base/igc_i225.c | 2 +- @@ -19,5 +20,5 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c -index 8f01f8d918..1277f59885 100644 ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c -@@ -344,7 +344,7 @@ void igc_release_swfw_sync_i225(struct igc_hw *hw, u16 mask) +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c +index c2fae6e797..97dc7f454d 100644 +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c +@@ -341,7 +341,7 @@ void igc_release_swfw_sync_i225(struct igc_hw *hw, u16 mask)