From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0C4B4624E for ; Mon, 17 Feb 2025 18:07:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6F18402C6; Mon, 17 Feb 2025 18:07:01 +0100 (CET) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id BDCE6402DF for ; Mon, 17 Feb 2025 18:07:00 +0100 (CET) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4398ec2abc2so3893535e9.1 for ; Mon, 17 Feb 2025 09:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812020; x=1740416820; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V6cVsxKWVlAzGNveODITV9D3YDD8PWP7CFcnHimUZAc=; b=Yw9olC30LIAgFYFmLa7lkSGspkPPAVRmwKhwQszB4rItandMltMezYt6dx1yRop1kr uBlFrt631sOEHNWVHl6RheFOg1mGtSwu+FVxLQmYPoKbnGrlKeCPLfqgZ88LDuiowhgw nJ3KYb3Tin9I2CV0ktKN7G7Ey+63aCzbsyn2/UE2Yra0Own5df7xVFbdtEWzq6tDnvq+ 5OGWG9RCib8tUHT8el1DayynfoywOqJzXvieGdvUJoatNcKhPY4xM5BhYxYUezmOofqP sNSkF4FQeDZPJrCfcIneJRpKSm5YzX5RmqNk18uPzGiOiBDVv+caBg3lg6SQSes6jlva HD/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812020; x=1740416820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V6cVsxKWVlAzGNveODITV9D3YDD8PWP7CFcnHimUZAc=; b=LIV1P/6NQZmQV/ZpVhDTXp1r11w24ZJ/IKQWvETNhu7yhUC7BYyGtdqdXLS5ZOEmug oNoL2KNq2/bsgr4Rkgvz/wrHZGl/Gf8SnBJnI34HiwKEHkfoq5dr7celsXnLp05kSfRn ASHA2b8y5LohvRGtHZR/XahuUt4xDAdUiFRjs9F96bFyviNc59HHzaIRnwI84brr3uIj VXOoPSrYkT0oiB2S702+OepuPSJCwEIvJJ/UJNslABmvJaPTkhwA2Rz84WL9oFyjKOzl WNoN0dZav614uZHzVUqaA39flz43IKsqlYBQVYChRCtUGm7s41L11RPDx3FBJhA34rPH spfw== X-Forwarded-Encrypted: i=1; AJvYcCUmvRvkuurdnkFpG65rnh4h75Oc1F4IBWGMvwtpSJkFfsvQe4eoI1vtkA8HqQYL2XDdeDop0yc=@dpdk.org X-Gm-Message-State: AOJu0YyTJxiMUaVINTNaczNpb0VZfvnzTqL/WaCptMbfLBTqdPwag6H+ RlHHc5+FuHRRLRjVT0tP4k/M7W1NrJLKoFjFglFtWbDb7p0qz9Xe X-Gm-Gg: ASbGncvnWxMYbTP8ZXd0e5ZNJ1XrCD67QTcbhbEG291rIrNrHqbCd0fcrWCcTOMgsDi YOEL6K/2pVBGSzDO1UYztjrKp2J3JlgdRg8qg4ZyGmcBPo6INO/eUu1QTWOhtmPeFgYtwYwJGns 7mGyykK/Z8oKUNEy2ar+VWEhLYxvhOqg55t39FtWwkJQJZDuqRrRMmbbcnD/8762/n0Nx1E3JJZ 5V8yyy9IGTC+ftzVwCeRVRSFeV2LSxoT0zsO8JcSqFfGW0KMn0dM6/LoZ1rZDr4nCA+arnXIacB 32YWDLQO1enUbOazu0qxNQ== X-Google-Smtp-Source: AGHT+IHXoWFAL9d2RxQJ3WYJkliZiPRiUmemq7qZFg/dbEcHaZaRGKgB/wlf+9k3/MbJ4IWaon826g== X-Received: by 2002:a05:600c:3552:b0:439:8bc3:a697 with SMTP id 5b1f17b1804b1-4398bc3ae99mr24973895e9.4.1739812020197; Mon, 17 Feb 2025 09:07:00 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43961884e88sm125238445e9.26.2025.02.17.09.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:06:59 -0800 (PST) From: luca.boccassi@gmail.com To: Sasha Neftin Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix LTR for i225' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:12 +0000 Message-ID: <20250217170456.1068278-39-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/f65e7af5701cbb5c25d05269a4f5048d8024220e Thanks. Luca Boccassi --- >From f65e7af5701cbb5c25d05269a4f5048d8024220e Mon Sep 17 00:00:00 2001 From: Sasha Neftin Date: Thu, 6 Feb 2025 16:08:29 +0000 Subject: [PATCH] net/igc/base: fix LTR for i225 [ upstream commit 6a304bc65269cfd86193663e9b94c73299b54d00 ] i225 specification recommends minus 1 microsecond from a value calculated for a LTR. Fix the calculation to match spec. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index 25cd2a8039..a6f0ac0612 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -1068,7 +1068,9 @@ static s32 igc_set_ltr_i225(struct igc_hw *hw, bool link) scale_max = (ltr_max / 1024) < 1024 ? IGC_LTRMAXV_SCALE_1024 : IGC_LTRMAXV_SCALE_32768; ltr_min /= scale_min == IGC_LTRMINV_SCALE_1024 ? 1024 : 32768; + ltr_min -= 1; ltr_max /= scale_max == IGC_LTRMAXV_SCALE_1024 ? 1024 : 32768; + ltr_max -= 1; /* Only write the LTR thresholds if they differ from before. */ ltrv = IGC_READ_REG(hw, IGC_LTRMINV); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:18.246653784 +0000 +++ 0039-net-igc-base-fix-LTR-for-i225.patch 2025-02-17 16:13:16.838441592 +0000 @@ -1 +1 @@ -From 6a304bc65269cfd86193663e9b94c73299b54d00 Mon Sep 17 00:00:00 2001 +From f65e7af5701cbb5c25d05269a4f5048d8024220e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6a304bc65269cfd86193663e9b94c73299b54d00 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/igc/base/igc_i225.c | 2 ++ + drivers/net/igc/base/igc_i225.c | 2 ++ @@ -19,5 +20,5 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c -index 003c060215..e701d00f80 100644 ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c -@@ -1071,7 +1071,9 @@ static s32 igc_set_ltr_i225(struct igc_hw *hw, bool link) +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c +index 25cd2a8039..a6f0ac0612 100644 +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c +@@ -1068,7 +1068,9 @@ static s32 igc_set_ltr_i225(struct igc_hw *hw, bool link)