From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D4554624E for ; Mon, 17 Feb 2025 18:05:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 574BA400D6; Mon, 17 Feb 2025 18:05:05 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id DE578402C9 for ; Mon, 17 Feb 2025 18:05:03 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-38f3486062eso1704792f8f.0 for ; Mon, 17 Feb 2025 09:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739811903; x=1740416703; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ibqVVoHUa7NNoZoRGhGzgtNaYkvkoSRnq4lxTr5tae4=; b=UGhn+uK2SEbPa7+hrrmIw2/pPoa35h7O9vAT/+NTJvWqbTznvZVStcCvNCQOab1cLE j8+9i1DrmknmxJj0Ag0tEE/HEsQt4ibCEO9WM96j9o/8w8cp72BQm0QzTi2OexjNre6F phdsPwelBrpQURpnOWt42HdCMocqa1PIvjXlaTgw6Bx/nk11s6txm/pPJCKVuDybodh5 JcSCVmpbo0EZ7nVTdpWwbhsW0Gp4zMBZjI7cmYuyyxA+eH3Twfc88XvLZgq25Poh6qZK iyPAPj9EvbHmkhRaQ9zoguu0noTy4aBrrUSnyN+ESbkgFf25u9tLzCZYZu8RrxhkLVTe M/ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739811903; x=1740416703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ibqVVoHUa7NNoZoRGhGzgtNaYkvkoSRnq4lxTr5tae4=; b=LLZ6pB7O/ekDTqgEpyZahEKfzwOLXFEkhHSWWb7heQHfr/zwAlGuM6Rlv6TYT9dC90 8fPUn/WxO0Bs0DJGjk1bp853DzpbNjGxUb3/srInZYgD6RNomq3nAhIcXtYU1aoa4XZE XUyIpJRI2Hl6AD13SfITGh0dyrb38mHlZ4QHN4T7MZOu01CE2b7SJ8/U7V6/oVhYDH+9 JPw69Y/xsFgETFlrMwxaHmgMl4hFNuVR1LTJ+9mCdccIK6jr//WpwTyQ/AwQke+7DkdC Nwx0OMEMTnX4gHeQ5QSfjcnoAa92MdR2jN531M7kiYrOGoAyvzCIVmjpb/HilSbfUBAg myoQ== X-Forwarded-Encrypted: i=1; AJvYcCV5yjmM/NiWKTzVlNi+3LUr6A96uCyGkt6noHbwz7o2zEJGh2Ux9nJRcJ7qvf8+dfy5Hr9fzhI=@dpdk.org X-Gm-Message-State: AOJu0YzsugTFkticITq3w6wvwZX+IcaOYRlewazlpcLogiQXWBBETue/ ntEOX57QIP5sD8uBk39B+wcH6SHORKX2b0Q5Rk4/71X0/5/ruN5j X-Gm-Gg: ASbGnctsIs/NXjTqQGH0YUGC3oFpdl2sydAc7uV0llMqaPjW1BgpiOoHCqQIpHBr+lz 9Z77uBSBb4WfKEKExIvhPazIhCmFJ0B5S0NLjb9vw+5Qck6OuG5MemBD1aDhbiaYFpv0CAo5gD8 tPvk9ELGxu33G/YmRJDfgcO24XMUKnCth9dC0Zxfz6KNTqsEwqbcsFjCLW9fZ947oWuljsdsTlf QBVD5jEyITQBZyd5+XgyJ2Dyd7sc/OiSeC4KO1EclBYYiIAkYu8KUpZsOj8cYJVG5lRRe9p0134 qLbkAGbEXInH6LMaALvHgw== X-Google-Smtp-Source: AGHT+IE/I/5jqAZ8iMzr8bY2vlt2hWgof0LMWwrPeVVruSNpJvqgYwklu+M3ZoUuYzoZUf+Picbm8w== X-Received: by 2002:a05:6000:2c3:b0:38f:2224:738e with SMTP id ffacd0b85a97d-38f33f105a1mr10873579f8f.1.1739811903265; Mon, 17 Feb 2025 09:05:03 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-38f25a0fe5esm12897530f8f.99.2025.02.17.09.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:05:02 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: David Marchand , dpdk stable Subject: patch 'crypto/cnxk: fix build with GCC 15' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:03:37 +0000 Message-ID: <20250217170456.1068278-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a48eaccd798733531513c03baafd4eb018afded1 Thanks. Luca Boccassi --- >From a48eaccd798733531513c03baafd4eb018afded1 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 20 Jan 2025 15:23:38 -0800 Subject: [PATCH] crypto/cnxk: fix build with GCC 15 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 224e37a6a442b6a1f6d179b1756383f1a80cf3ed ] GCC 15 produces warnings about uninitialized variables. In file included from ../lib/mbuf/rte_mbuf.h:36, from ../lib/cryptodev/rte_crypto.h:15, from ../lib/cryptodev/rte_cryptodev.h:19, from ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:5: In function ‘pdcp_chain_sg1_prep’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1621:11, inlined from ‘fill_pdcp_chain_params’ at ../drivers/crypto/cnxk/cnxk_se.h:3114:8, inlined from ‘cpt_sym_inst_fill’ at ../drivers/crypto/cnxk/cnxk_se.h:3364:9, inlined from ‘cn9k_cpt_inst_prep’ at ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:93:10: ../lib/eal/include/rte_common.h:469:38: warning: ‘fc_params.meta_buf.vaddr’ may be used uninitialized [-Wmaybe-uninitialized] 469 | #define RTE_PTR_ADD(ptr, x) ((void*)((uintptr_t)(ptr) + (x))) | ^~~~~~~~~~~~~~~~ ../drivers/common/cnxk/roc_platform.h:47:34: note: in expansion of macro ‘RTE_PTR_ADD’ 47 | #define PLT_PTR_ADD RTE_PTR_ADD | ^~~~~~~~~~~ ../drivers/crypto/cnxk/cnxk_se.h:900:19: note: in expansion of macro ‘PLT_PTR_ADD’ 900 | m_vaddr = PLT_PTR_ADD(m_vaddr, ROC_SE_OFF_CTRL_LEN + PLT_ALIGN_CEIL(hdr_len, 8)); | ^~~~~~~~~~~ In file included from ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:20: ../drivers/crypto/cnxk/cnxk_se.h: In function ‘cn9k_cpt_inst_prep’: ../drivers/crypto/cnxk/cnxk_se.h:3008:33: note: ‘fc_params.meta_buf.vaddr’ was declared here 3008 | struct roc_se_fc_params fc_params; | ^~~~~~~~~ In function ‘pdcp_chain_sg1_prep’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1621:11, inlined from ‘fill_pdcp_chain_params’ at ../drivers/crypto/cnxk/cnxk_se.h:3114:8, inlined from ‘cpt_sym_inst_fill’ at ../drivers/crypto/cnxk/cnxk_se.h:3364:9, inlined from ‘cn9k_cpt_inst_prep’ at ../drivers/crypto/cnxk/cn9k_cryptodev_ops.c:82:10: ../lib/eal/include/rte_common.h:469:38: warning: ‘fc_params.meta_buf.vaddr’ may be used uninitialized [-Wmaybe-uninitialized] 469 | #define RTE_PTR_ADD(ptr, x) ((void*)((uintptr_t)(ptr) + (x))) | ^~~~~~~~~~~~~~~~ ../drivers/common/cnxk/roc_platform.h:47:34: note: in expansion of macro ‘RTE_PTR_ADD’ 47 | #define PLT_PTR_ADD RTE_PTR_ADD | ^~~~~~~~~~~ ../drivers/crypto/cnxk/cnxk_se.h:900:19: note: in expansion of macro ‘PLT_PTR_ADD’ 900 | m_vaddr = PLT_PTR_ADD(m_vaddr, ROC_SE_OFF_CTRL_LEN + PLT_ALIGN_CEIL(hdr_len, 8)); | ^~~~~~~~~~~ ../drivers/crypto/cnxk/cnxk_se.h: In function ‘cn9k_cpt_inst_prep’: ../drivers/crypto/cnxk/cnxk_se.h:3008:33: note: ‘fc_params.meta_buf.vaddr’ was declared here 3008 | struct roc_se_fc_params fc_params; | ^~~~~~~~~ Fixes: d3bff77cc371 ("crypto/cnxk: separate out PDCP chain datapath") Signed-off-by: Stephen Hemminger Acked-by: David Marchand --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index 32e2b2cd64..ea455f41e3 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -2752,7 +2752,7 @@ fill_pdcp_chain_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess, { uint32_t ci_data_length, ci_data_offset, a_data_length, a_data_offset; struct rte_crypto_sym_op *sym_op = cop->sym; - struct roc_se_fc_params fc_params; + struct roc_se_fc_params fc_params = { }; struct rte_mbuf *m_src, *m_dst; uint8_t cpt_op = sess->cpt_op; uint64_t d_offs, d_lens; -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:17.053201612 +0000 +++ 0004-crypto-cnxk-fix-build-with-GCC-15.patch 2025-02-17 16:13:16.786441593 +0000 @@ -1 +1 @@ -From 224e37a6a442b6a1f6d179b1756383f1a80cf3ed Mon Sep 17 00:00:00 2001 +From a48eaccd798733531513c03baafd4eb018afded1 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 224e37a6a442b6a1f6d179b1756383f1a80cf3ed ] + @@ -54 +55,0 @@ -Cc: stable@dpdk.org @@ -63 +64 @@ -index 7262a49945..649e38c495 100644 +index 32e2b2cd64..ea455f41e3 100644 @@ -66 +67 @@ -@@ -3005,7 +3005,7 @@ fill_pdcp_chain_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess, +@@ -2752,7 +2752,7 @@ fill_pdcp_chain_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,